Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

rewrite_domains cuts off dynamic parts of image URLs #311

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 8 comments
Closed

rewrite_domains cuts off dynamic parts of image URLs #311

GoogleCodeExporter opened this issue Apr 6, 2015 · 8 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Check out example page 
http://www.html.de/html-und-xhtml/39659-tweet-follow-button-anpassen.html#post28
8229
2. Notice that the post includes a graphic with the URL 
http://www.html.de/attachment.php?attachmentid=2066&d=1308593673
3. Enable rewrite_domains with domain sharding and the following config:
    ModPagespeedEnableFilters rewrite_domains
    ModPagespeedMapOriginDomain localhost www.html.de
    ModPagespeedMapOriginDomain localhost s10.bmedien.eu
    ModPagespeedMapOriginDomain localhost s11.bmedien.eu
    ModPagespeedShardDomain www.html.de s10.bmedien.eu,s11.bmedien.eu
4. I would expect the original pic URL to get rewritten using domain sharding. 
Sharding does happen, but the URL gets modified and the full SRC of the images 
now "//s11.bmedien.eu/attachment.php". Image can not be loaded any more.



What is the expected output? What do you see instead?

The original parameters in the SRC URL get cut off; URL of the pic is destroyed.
ORIGINAL URL
http://www.html.de/attachment.php?attachmentid=2066&d=1308593673
INCORRECTLY SHARDED URL
//s11.bmedien.eu/attachment.php
EXPECTED OUTPUT
//s11.bmedien.eu/attachment.php?attachmentid=2066&d=1308593673

What version of the product are you using (please check X-Mod-Pagespeed
header)?

0.9.17.7-716

Original issue reported on code.google.com by fxres...@gmail.com on 21 Jun 2011 at 12:20

@GoogleCodeExporter
Copy link
Author

I confirmed this with a tiny testcase.  Should be easy to fix.  Thanks for 
catching this.

Original comment by jmara...@google.com on 21 Jun 2011 at 1:02

@GoogleCodeExporter
Copy link
Author

Fixed in r793

Original comment by jmara...@google.com on 21 Jun 2011 at 8:06

  • Changed state: Fixed
  • Added labels: release-note

@GoogleCodeExporter
Copy link
Author

Issue 315 has been merged into this issue.

Original comment by jmara...@google.com on 1 Jul 2011 at 11:11

@GoogleCodeExporter
Copy link
Author


I need this urgently, where should I get this from?

Should I build tags/0.9.18.5 or trunk?

Thanks,

Original comment by sudha...@gmail.com on 3 Aug 2011 at 6:28

@GoogleCodeExporter
Copy link
Author

Either will work for source builds.

Plus we are right in the process now of cutting a binary office.

Original comment by jmara...@google.com on 3 Aug 2011 at 6:32

@GoogleCodeExporter
Copy link
Author

I should make a specific recommendation for immediate action:  Use tag 0.9.18.5.


Original comment by jmara...@google.com on 3 Aug 2011 at 6:33

@GoogleCodeExporter
Copy link
Author


I was able to build 0.9.18.5 on CentOS 6.0 but that didn't run on RHEL-5.4 
server. 

Cannot load /usr/lib64/httpd/modules/mod_pagespeed.so into server: 
/usr/lib64/libstdc++.so.6: version `GLIBCXX_3.4.10' not found (required by 
/usr/lib64/httpd/modules/mod_pagespeed.so)


==

And following pre-requisite is not available on CentOS-5.X ; what should I do?

We require Apache (>= 2.2), g++ (>= 4.2), Python (>= 2.6), subversion, and make.

Thanks in advance,
- Su

Original comment by sudha...@gmail.com on 3 Aug 2011 at 9:50

@GoogleCodeExporter
Copy link
Author

Can you open up a new Issue regarding the source build problems you've seen?  
This isn't really related to this bug.

Thanks!

Original comment by jmara...@google.com on 3 Aug 2011 at 9:54

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant