Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Provide a pagespeed.conf option to append a custom Header (key->value) to the Serf fetcher #434

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 7 comments

Comments

@GoogleCodeExporter
Copy link

It would be nice if you could change the Serf fetcher to always add a new 
header.  This could work as a pagespeed.conf option to always append a 
particular header name/value.

This would allow for easy identification of the Serf fetcher requests.

Original issue reported on code.google.com by hayes...@gmail.com on 16 May 2012 at 5:30

@GoogleCodeExporter
Copy link
Author

FYI, I think serf adds segment to the User-Agent header (like Serf/... or 
mod_pagespeed/...) Would that be enough? Or would you prefer a distinct header?

Original comment by sligocki@google.com on 16 May 2012 at 5:43

@GoogleCodeExporter
Copy link
Author

A distinct/custom header would be nice.  I think this allows for the most 
flexibility and control.

Original comment by hayes...@gmail.com on 16 May 2012 at 5:46

@GoogleCodeExporter
Copy link
Author

Actually, I could see a use for N number of headers. One header to identify the 
Serf Fetcher to make decisions and another for debug purposes.

Original comment by hayes...@gmail.com on 17 May 2012 at 7:32

@GoogleCodeExporter
Copy link
Author

Original comment by jmara...@google.com on 31 May 2012 at 7:35

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Original comment by jefftk@google.com on 4 Sep 2012 at 3:28

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Fixed in revision r1852; added "ModPagespeedCustomFetchHeader <name> <value>"

Documentation to come.

Original comment by jefftk@google.com on 5 Sep 2012 at 6:27

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Original comment by j...@google.com on 26 Oct 2012 at 5:54

  • Added labels: Milestone-v23

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant