Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

rewrite_css should not apply to files with an @import in the middle. #722

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

See 
http://www.princesspolly.com.au/HttpCombiner.ashx?s=CSSGlobal&t=text/css&v=20121
1141730

Note the @import in the middle.  This must be created by some other combiner 
and it is not a legal result.  Yet mod_pagespeed will rewrite that CSS file, 
moving the import to the top:

http://www.princesspolly.com.au/A.HttpCombiner.ashx,qs=CSSGlobal,at=text,_css,av
=201211141730.pagespeed.cf.FNJS1LATKX.css

mod_pagespeed should consider this file invalid and avoid applying rewrite_css 
(though fallback_rewrite_css can work).

Original issue reported on code.google.com by jmara...@google.com on 19 Jun 2013 at 3:57

@GoogleCodeExporter
Copy link
Author

I believe this is a CSS parser problems, since MPS only manipulate compiled CSS 
not raw CSS, and if the parser had detected an error with the CSS then MPS 
wouldn't combine it.

Original comment by matterb...@google.com on 19 Jun 2013 at 8:33

@GoogleCodeExporter
Copy link
Author

This issue was closed by revision r3194.

Original comment by sligocki@google.com on 24 Jun 2013 at 3:43

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Original comment by sligocki@google.com on 24 Jun 2013 at 3:44

  • Added labels: Milestone-v29, release-note

@GoogleCodeExporter
Copy link
Author

Original comment by sligocki@google.com on 25 Jun 2013 at 5:08

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant