improve stub for [fileevent]

partcl · Jun 27, 2010 · 6bb906f · 6bb906f
1 parent c40557f
commit 6bb906f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/Partcl/commands/main.pm b/src/Partcl/commands/main.pm
@@ -160,6 +160,14 @@ our sub expr(*@args) {
 }
 
 our sub fileevent(*@args) {
+    if +@args < 2 || +@args > 3 {
+        error('wrong # args: should be "fileevent channelId event ?script?"');
+    }
+    my $channelId := @args.shift;
+    my $event     := @args.shift;
+    if $event ne 'readable' || $event ne 'writable' {
+        error("bad event name \"$event\": must be readable or writable");
+    }
     '';
 }
 

diff --git a/t/cmd_fileevent.t b/t/cmd_fileevent.t
@@ -5,15 +5,15 @@ plan 4
 
 eval_is {fileevent foo} \
   {wrong # args: should be "fileevent channelId event ?script?"} \
-  {too few args} {TODO NQPRX}
+  {too few args}
 
 eval_is {fileevent foo bar baz qux} \
   {wrong # args: should be "fileevent channelId event ?script?"} \
-  {too many args} {TODO NQPRX}
+  {too many args}
 
 eval_is {fileevent sock1 ontehoeni} \
   {bad event name "ontehoeni": must be readable or writable} \
-  {bad channel *and* event} {TODO NQPRX}
+  {bad channel *and* event}
 
 eval_is {fileevent sock1 readable} \
   {can not find channel named "sock1"} \