Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Fixed #176: Calculation of CIS metric is incorrect.
- Loading branch information
1 parent
72f3ea7
commit 1193f4a
Showing
9 changed files
with
303 additions
and
58 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
117 changes: 117 additions & 0 deletions
117
tests/PHP/Depend/Bugs/ClassInterfaceSizeShouldNotSumComplexityBug176Test.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| <?php | ||
| /** | ||
| * This file is part of PHP_Depend. | ||
| * | ||
| * PHP Version 5 | ||
| * | ||
| * Copyright (c) 2008-2010, Manuel Pichler <mapi@pdepend.org>. | ||
| * All rights reserved. | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions | ||
| * are met: | ||
| * | ||
| * * Redistributions of source code must retain the above copyright | ||
| * notice, this list of conditions and the following disclaimer. | ||
| * | ||
| * * Redistributions in binary form must reproduce the above copyright | ||
| * notice, this list of conditions and the following disclaimer in | ||
| * the documentation and/or other materials provided with the | ||
| * distribution. | ||
| * | ||
| * * Neither the name of Manuel Pichler nor the names of his | ||
| * contributors may be used to endorse or promote products derived | ||
| * from this software without specific prior written permission. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS | ||
| * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE | ||
| * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, | ||
| * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, | ||
| * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; | ||
| * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
| * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | ||
| * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN | ||
| * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| * POSSIBILITY OF SUCH DAMAGE. | ||
| * | ||
| * @category PHP | ||
| * @package PHP_Depend | ||
| * @subpackage Bugs | ||
| * @author Manuel Pichler <mapi@pdepend.org> | ||
| * @copyright 2008-2010 Manuel Pichler. All rights reserved. | ||
| * @license http://www.opensource.org/licenses/bsd-license.php BSD License | ||
| * @version SVN: $Id$ | ||
| * @link http://tracker.pdepend.org/pdepend/issue_tracker/issue/176 | ||
| */ | ||
|
|
||
| require_once dirname(__FILE__) . '/AbstractTest.php'; | ||
|
|
||
| /** | ||
| * Test case for ticket #176. | ||
| * | ||
| * @category PHP | ||
| * @package PHP_Depend | ||
| * @subpackage Bugs | ||
| * @author Manuel Pichler <mapi@pdepend.org> | ||
| * @copyright 2008-2010 Manuel Pichler. All rights reserved. | ||
| * @license http://www.opensource.org/licenses/bsd-license.php BSD License | ||
| * @version Release: @package_version@ | ||
| * @link http://tracker.pdepend.org/pdepend/issue_tracker/issue/176 | ||
| * | ||
| * @covers stdClass | ||
| */ | ||
| class PHP_Depend_Bugs_ClassInterfaceSizeShouldNotSumComplexityBug176Test | ||
| extends PHP_Depend_Bugs_AbstractTest | ||
| { | ||
| /** | ||
| * testAnalyzerCountsNumberOfMethodsForClassInterfaceSize | ||
| * | ||
| * @return void | ||
| * @group pdepend | ||
| * @group pdepend::bugs | ||
| * @group regressiontest | ||
| */ | ||
| public function testAnalyzerCountsNumberOfMethodsForClassInterfaceSize() | ||
| { | ||
| $packages = self::parseCodeResourceForTest(); | ||
|
|
||
| $class = $packages->current() | ||
| ->getClasses() | ||
| ->current(); | ||
|
|
||
| $analyzer = new PHP_Depend_Metrics_ClassLevel_Analyzer(); | ||
| $analyzer->addAnalyzer(new PHP_Depend_Metrics_CyclomaticComplexity_Analyzer()); | ||
| $analyzer->analyze($packages); | ||
|
|
||
| $metrics = $analyzer->getNodeMetrics($class); | ||
|
|
||
| self::assertEquals(2, $metrics['cis']); | ||
| } | ||
|
|
||
| /** | ||
| * testAnalyzerCountsNumberOfMethodsForClassSize | ||
| * | ||
| * @return void | ||
| * @group pdepend | ||
| * @group pdepend::bugs | ||
| * @group regressiontest | ||
| */ | ||
| public function testAnalyzerCountsNumberOfMethodsForClassSize() | ||
| { | ||
| $packages = self::parseCodeResourceForTest(); | ||
|
|
||
| $class = $packages->current() | ||
| ->getClasses() | ||
| ->current(); | ||
|
|
||
| $analyzer = new PHP_Depend_Metrics_ClassLevel_Analyzer(); | ||
| $analyzer->addAnalyzer(new PHP_Depend_Metrics_CyclomaticComplexity_Analyzer()); | ||
| $analyzer->analyze($packages); | ||
|
|
||
| $metrics = $analyzer->getNodeMetrics($class); | ||
|
|
||
| self::assertEquals(6, $metrics['csz']); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.