Closes #277: serialize(): "comment" is returned …

… from __sleep multiple times in store in FileCacheDriver.php
pdepend · Nov 23, 2016 · 31cf053 · 31cf053
1 parent cc609c8
commit 31cf053
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/src/main/php/PDepend/Source/AST/ASTAnonymousClass.php b/src/main/php/PDepend/Source/AST/ASTAnonymousClass.php
@@ -236,7 +236,7 @@ public function accept(ASTVisitor $visitor, $data = null)
      */
     public function __sleep()
     {
-        return array_merge(array('comment', 'metadata', 'nodes'), parent::__sleep());
+        return array_merge(array('metadata'), parent::__sleep());
     }
 
     /**

diff --git a/src/test/php/PDepend/Source/AST/ASTAnonymousClassTest.php b/src/test/php/PDepend/Source/AST/ASTAnonymousClassTest.php
@@ -42,6 +42,8 @@
 
 namespace PDepend\Source\AST;
 
+use PDepend\Util\Cache\Driver\MemoryCacheDriver;
+
 /**
  * Test case for the {@link \PDepend\Source\AST\ASTCatchStatement} class.
  *
@@ -91,6 +93,38 @@ public function testAnonymousClassHasExpectedEndColumn()
         $this->assertEquals(5, $expr->getEndColumn());
     }
 
+    /**
+     * testMagicSleepMethodReturnsExpectedSetOfPropertyNames
+     *
+     * @return void
+     */
+    public function testMagicSleepMethodReturnsExpectedSetOfPropertyNames()
+    {
+        $class = new ASTAnonymousClass(__CLASS__);
+        $class->setCache(new MemoryCacheDriver());
+
+        $this->assertEquals(
+            array(
+                'metadata',
+                'constants',
+                'interfaceReferences',
+                'parentClassReference',
+                'cache',
+                'context',
+                'comment',
+                'endLine',
+                'modifiers',
+                'name',
+                'nodes',
+                'namespaceName',
+                'startLine',
+                'userDefined',
+                'id'
+            ),
+            $class->__sleep()
+        );
+    }
+
     /**
      * @return \PDepend\Source\AST\ASTAnonymousClass
      */