Use StringBuilder in subst instead of manually collect pieces.

perl6 · May 15, 2010 · 05c8f66 · 05c8f66
1 parent 7516db0
commit 05c8f66
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/setting/Regex.pm b/src/setting/Regex.pm
@@ -38,21 +38,21 @@ sub subst ($text, $regex, $repl, :$global?) {
                            !! [ $text ~~ $regex ];
     my $is_code := pir::isa($repl, 'Sub');
     my $offset  := 0;
-    my @pieces;
+    my $result  := pir::new__Ps('StringBuilder');
 
     for @matches -> $match {
         my $repl_string := $is_code ?? $repl($match) !! $repl;
-        @pieces.push( pir::substr($text, $offset, $match.from - $offset))
+        pir::push($result, pir::substr($text, $offset, $match.from - $offset))
             if $match.from > $offset;
-        @pieces.push($repl_string);
+        pir::push($result, $repl_string);
         $offset := $match.to;
     }
 
     my $chars := pir::length($text);
-    @pieces.push(pir::substr($text, $offset, $chars))
+    pir::push($result, pir::substr($text, $offset, $chars))
         if $chars > $offset;
 
-    @pieces.join('');
+    ~$result;
 }
 
 # vim: ft=perl6