@@ -1,7 +1,9 @@ Revision history for autodie * TEST: Check for autodie leaking out of scope in the - presence of string evals. + presence of string evals. (string-eval-leak.t) + Thanks to Florian Ragwitz and Vincent Pit for identifying + this. 2.05 Sat Jul 4 16:33:01 AUSEST 2009 Changes @@ -1,7 +1,7 @@ #!/usr/bin/perl -w use strict; use warnings; -use Test::More tests => 1; +use Test::More tests => 2; # Under Perl 5.10.x, a string eval can cause a copy to be taken of # %^H, which delays stringification of our scope guard objects, @@ -18,4 +18,22 @@ eval { open(my $fh, '<', 'this_file_had_better_not_exist'); }; -is("$@","","Autodie should not leak out of scope"); +TODO: { + local $TODO; + + if ( $] >= 5.010 ) { + $TODO = "Autodie can leak near string evals in 5.10.x"; + } + + is("$@","","Autodie should not leak out of scope"); +} + +# However, we can plug the leak with 'no autodie'. + +no autodie; + +eval { + open(my $fh, '<', 'this_file_had_better_not_exist'); +}; + +is("$@","",'no autodie should be able to workaround this bug'); t/string-eval-leak.t aaf4bd7ce297d62b043f7254e6cfacabde1dde6e Paul Fenwick pjf@perltraining.com.au http://github.com/pfenwick/autodie/commit/71b72f81d616ece224e7a29c5c7b7acbe594930d 71b72f81d616ece224e7a29c5c7b7acbe594930d 2009-07-05T08:27:28-07:00 2009-07-05T08:27:28-07:00 Tests for explicitly plugging leaks with 'no autodie' near string evals. c70de98bbde8725415df33abfe79493b7b7d77da Paul Fenwick pjf@perltraining.com.au