@@ -38,7 +38,9 @@ Features * `click 'the_button_id', :wait_for => :element, :element => 'new_element_id'` * `click 'the_button_id', :wait_for => :no_element, :element => 'disappearing_element_id'` * `click 'the_button_id', :wait_for => :text, :text => 'New Text'` + * `click 'the_button_id', :wait_for => :text, :element => 'notification_box', :text => 'New Text'` * `click 'the_button_id', :wait_for => :no_text, :text => 'Disappearing Text'` + * `click 'the_button_id', :wait_for => :no_text, :element => 'notification_box', :text => 'Disappearing Text'` * `click 'the_button_id', :wait_for => :effects` * `click 'the_button_id', :wait_for => :condition, :javascript => "some arbitrary javascript expression"` README.markdown @@ -60,7 +60,9 @@ module Selenium end def example_hash(example) - Digest::MD5.hexdigest example.backtrace.first + # backtrace is not reliable anymore using the implementation proc + implementation = example.instance_variable_get :'@_implementation' + Digest::MD5.hexdigest implementation.inspect end end lib/selenium/rspec/reporting/file_path_strategy.rb @@ -14,19 +14,25 @@ unit_tests do assert_equal File.expand_path("/another/dir"), second_strategy.base_report_dir end - test "example_hash is distinct when examples first backtrace entry is different" do + test "example_hash is distinct when examples implementation is different" do strategy = Selenium::RSpec::Reporting::FilePathStrategy.new "report.html" - first_example = stub('example',:backtrace => [ "a", "c" ]) - second_example = stub('example',:backtrace => [ "b", "c" ]) + first_example = Object.new + first_example.instance_variable_set :'@_implementation', Proc.new {} + second_example = Object.new + second_example.instance_variable_set :'@_implementation', Proc.new {} + assert strategy.example_hash(first_example) != strategy.example_hash(second_example) end - test "example_hash is the same when examples first backtrace entry is identical" do + test "example_hash is the same when examples implementation is identical" do strategy = Selenium::RSpec::Reporting::FilePathStrategy.new "report.html" - - first_example = stub('example',:backtrace => [ "a", "b" ]) - second_example = stub('example',:backtrace => [ "a", "c" ]) + + same_implementation = Proc.new {} + first_example = Object.new + first_example.instance_variable_set :'@_implementation', same_implementation + second_example = Object.new + second_example.instance_variable_set :'@_implementation', same_implementation assert_equal strategy.example_hash(first_example), strategy.example_hash(second_example) end test/unit/selenium/rspec/reporting/file_path_strategy_test.rb d351fc94dc35d6d244d27036d1d812dec78e00a8 Philippe Hanrigou philippe.hanrigou@gmail.com http://github.com/ph7/selenium-client/commit/d1cde31cb7ae677a116869d2bb32ddf835375b77 d1cde31cb7ae677a116869d2bb32ddf835375b77 2009-02-02T20:41:28-08:00 2009-02-02T20:41:28-08:00 Fixing collision in example unique ids (RSpec reports) 0a05d9fd61e8ccebc1f909f13bb338044f6c107c Philippe Hanrigou philippe.hanrigou@gmail.com