From 77d4a3dda27a10ec956c1e9e5f3281c76c54a25a Mon Sep 17 00:00:00 2001 From: Ryan Willoughby Date: Mon, 10 Jun 2013 16:36:11 -0700 Subject: [PATCH] [spec] update specs to cordova.require/define --- spec/barcodescanner.tests.js | 32 ++++++++++++++++++-------------- www/barcodescanner.js | 4 ++-- 2 files changed, 20 insertions(+), 16 deletions(-) diff --git a/spec/barcodescanner.tests.js b/spec/barcodescanner.tests.js index cb2838f6..1b797156 100644 --- a/spec/barcodescanner.tests.js +++ b/spec/barcodescanner.tests.js @@ -19,35 +19,39 @@ * */ -describe('Plugin object (window.plugins)', function () { +var scanner; + +describe('cordova.require object should exist', function () { it("should exist", function() { - expect(window.plugins).toBeDefined(); + expect(window.cordova).toBeDefined(); + expect(typeof cordova.require == 'function').toBe(true); }); - it("should contain a barcodeScanner object", function() { - expect(window.plugins.barcodeScanner).toBeDefined(); - expect(typeof window.plugins.barcodeScanner == 'object').toBe(true); + it("BarcodeScanner plugin should exist", function() { + scanner = cordova.require("cordova/plugin/BarcodeScanner") + expect(scanner).toBeDefined(); + expect(typeof scanner == 'object').toBe(true); }); it("should contain a scan function", function() { - expect(window.plugins.barcodeScanner.scan).toBeDefined(); - expect(typeof window.plugins.barcodeScanner.scan == 'function').toBe(true); + expect(scanner.scan).toBeDefined(); + expect(typeof scanner.scan == 'function').toBe(true); }); it("should contain an encode function", function() { - expect(window.plugins.barcodeScanner.encode).toBeDefined(); - expect(typeof window.plugins.barcodeScanner.encode == 'function').toBe(true); + expect(scanner.encode).toBeDefined(); + expect(typeof scanner.encode == 'function').toBe(true); }); it("should contain three DestinationType constants", function() { - expect(BarcodeScanner.Encode.TEXT_TYPE).toBe("TEXT_TYPE"); - expect(BarcodeScanner.Encode.EMAIL_TYPE).toBe("EMAIL_TYPE"); - expect(BarcodeScanner.Encode.PHONE_TYPE).toBe("PHONE_TYPE"); - expect(BarcodeScanner.Encode.SMS_TYPE).toBe("SMS_TYPE"); + expect(scanner.Encode.TEXT_TYPE).toBe("TEXT_TYPE"); + expect(scanner.Encode.EMAIL_TYPE).toBe("EMAIL_TYPE"); + expect(scanner.Encode.PHONE_TYPE).toBe("PHONE_TYPE"); + expect(scanner.Encode.SMS_TYPE).toBe("SMS_TYPE"); }); /* it("should call scan successfully", function() { - window.plugins.barcodeScanner.scan(function() {}, function() {}); + scanner.scan(function() {}, function() {}); }); */ }); diff --git a/www/barcodescanner.js b/www/barcodescanner.js index cfc11ee1..3224aad3 100644 --- a/www/barcodescanner.js +++ b/www/barcodescanner.js @@ -54,12 +54,12 @@ cordova.define("cordova/plugin/BarcodeScanner", } if (typeof errorCallback != "function") { - console.log("BarcodeScanner.scan failure: failure parameter not a function"); + console.log("BarcodeScanner.encode failure: failure parameter not a function"); return } if (typeof successCallback != "function") { - console.log("BarcodeScanner.scan failure: success callback parameter must be a function"); + console.log("BarcodeScanner.encode failure: success callback parameter must be a function"); return }