@@ -417,28 +417,28 @@ NSString *PBGitIndexOperationFailed = @"PBGitIndexOperationFailed"; NSNotificationCenter *nc = [NSNotificationCenter defaultCenter]; // Other files (not tracked, not ignored) + refreshStatus++; NSFileHandle *handle = [PBEasyPipe handleForCommand:[PBGitBinary path] withArgs:[NSArray arrayWithObjects:@"ls-files", @"--others", @"--exclude-standard", @"-z", nil] inDir:[workingDirectory path]]; [nc addObserver:self selector:@selector(readOtherFiles:) name:NSFileHandleReadToEndOfFileCompletionNotification object:handle]; [handle readToEndOfFileInBackgroundAndNotify]; - refreshStatus++; // Unstaged files + refreshStatus++; handle = [PBEasyPipe handleForCommand:[PBGitBinary path] withArgs:[NSArray arrayWithObjects:@"diff-files", @"-z", nil] inDir:[workingDirectory path]]; [nc addObserver:self selector:@selector(readUnstagedFiles:) name:NSFileHandleReadToEndOfFileCompletionNotification object:handle]; [handle readToEndOfFileInBackgroundAndNotify]; - refreshStatus++; // Staged files + refreshStatus++; handle = [PBEasyPipe handleForCommand:[PBGitBinary path] withArgs:[NSArray arrayWithObjects:@"diff-index", @"--cached", @"-z", [self parentTree], nil] inDir:[workingDirectory path]]; [nc addObserver:self selector:@selector(readStagedFiles:) name:NSFileHandleReadToEndOfFileCompletionNotification object:handle]; [handle readToEndOfFileInBackgroundAndNotify]; - refreshStatus++; } - (void)readOtherFiles:(NSNotification *)notification PBGitIndex.m ce89e0f4684d4c6eea1fd87e99bfe8b9560344e5 Pieter de Bie pdebie@ai.rug.nl http://github.com/pieter/gitx/commit/5be8aed2b75b428139a4aaefe4b0b89439c07e66 5be8aed2b75b428139a4aaefe4b0b89439c07e66 2009-10-01T12:17:32-07:00 2009-10-01T12:17:32-07:00 GitIndex: increase refreshStatus before launching task We used to increase this variable after handing it over to the [handle readToEndOfFileInBackgroundAndNotify], but sometimes a task would quit before getting to that point, causing a premature index refresh event to be called. 06d73ccfd58e981e921b982d164989e947d291bc Pieter de Bie pdebie@ai.rug.nl