Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] DataObject Grid - filter by relation fields #10022

Merged
merged 19 commits into from Nov 2, 2021

Conversation

fszenborn
Copy link
Contributor

@fszenborn fszenborn commented Aug 12, 2021

Changes in this pull request

Filter by relation on grid.

Additional info

Could someone review/test my changes and leave some feedback or suggestions?
Here is the quick demo of the functionality:
https://user-images.githubusercontent.com/54931392/123623624-f6b28080-d80d-11eb-8274-8c091e409235.mp4
Supported field types are:
one to many
many to many
many to many object
advanced many to many
advanced many to many object
image
advanced image

@fszenborn fszenborn changed the base branch from 10.x to 10.1 August 13, 2021 00:23
@dvesh3
Copy link
Contributor

dvesh3 commented Aug 13, 2021

@fszenborn I just had a look at the demo video and the feature looks great 🤩 we'll review it soon. Meanwhile could you please check why tests are failing? thanks! great work 👏

One more thing, please rebase it on 10.x, since this a new feature.

@dvesh3 dvesh3 added this to the 10.2.0 milestone Aug 13, 2021
@dpfaffenbauer
Copy link
Contributor

THIS IS 🔥

@dvesh3
Copy link
Contributor

dvesh3 commented Aug 24, 2021

@fszenborn please rebase it on branch 10.x, so that we can start the review. thanks!

@fszenborn
Copy link
Contributor Author

Sorry for delay - I will do it soon. I was on vacation.

@dvesh3
Copy link
Contributor

dvesh3 commented Aug 31, 2021

Sorry for delay - I will do it soon. I was on vacation.

@fszenborn hope you had a great one 😉 no worries, take your time!

@kubaplas kubaplas force-pushed the divante-filter-by-relation branch 3 times, most recently from 1eafdf3 to 9b07255 Compare September 3, 2021 19:03
@brusch
Copy link
Member

brusch commented Sep 27, 2021

@fszenborn please check feedback of @jdevries14 Thanks!

@fszenborn
Copy link
Contributor Author

@brusch @dvesh3 I have just rebased on 10.x and applied suggestions from @jdevries14

@dvesh3 dvesh3 changed the base branch from 10.1 to 10.x September 28, 2021 07:39
@dvesh3
Copy link
Contributor

dvesh3 commented Sep 28, 2021

@brusch @dvesh3 I have just rebased on 10.x and applied suggestions from @jdevries14

@fszenborn thanks for your changes! After changing the base to 10.x, there's a conflict. Could you please resolve it?

@dvesh3 dvesh3 self-assigned this Sep 28, 2021
@dvesh3
Copy link
Contributor

dvesh3 commented Oct 4, 2021

@fszenborn please see my comments above. thanks!

@dvesh3
Copy link
Contributor

dvesh3 commented Oct 7, 2021

@fszenborn any chance to work on the reported issues soon? we should get this done in 10.2 release 🚀 thanks!

@dvesh3 dvesh3 modified the milestones: 10.2.0, 10.3.0 Oct 13, 2021
@fszenborn
Copy link
Contributor Author

@dvesh3 just fixed reported issues

@dvesh3 dvesh3 self-requested a review October 21, 2021 09:48
@dvesh3 dvesh3 changed the title GridFilter by relation field [Admin] DataObject Grid - filter by relation fields Oct 27, 2021
fszenborn and others added 2 commits October 29, 2021 09:33
…lterConditionParser.php


coding standard update

Co-authored-by: Divesh Pahuja <divesh.pahuja@pimcore.com>
@fszenborn fszenborn requested a review from dvesh3 October 29, 2021 07:37
@dvesh3 dvesh3 merged commit 3e8e418 into pimcore:10.x Nov 2, 2021
@dvesh3
Copy link
Contributor

dvesh3 commented Nov 2, 2021

@fszenborn great work 👏 thanks a lot!

@kubaplas @jdevries14 thanks for the review 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants