New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Admin] DataObject Grid - filter by relation fields #10022
Conversation
b45f0d2
to
9b07255
Compare
@fszenborn I just had a look at the demo video and the feature looks great 🤩 we'll review it soon. Meanwhile could you please check why tests are failing? thanks! great work 👏 One more thing, please rebase it on 10.x, since this a new feature. |
THIS IS 🔥 |
@fszenborn please rebase it on branch 10.x, so that we can start the review. thanks! |
Sorry for delay - I will do it soon. I was on vacation. |
@fszenborn hope you had a great one 😉 no worries, take your time! |
1eafdf3
to
9b07255
Compare
bundles/AdminBundle/Resources/public/js/pimcore/element/helpers/gridColumnConfig.js
Outdated
Show resolved
Hide resolved
models/DataObject/ClassDefinition/Data/Extension/RelationFilterConditionParser.php
Outdated
Show resolved
Hide resolved
bundles/AdminBundle/Resources/public/js/pimcore/object/tags/manyToManyRelation.js
Outdated
Show resolved
Hide resolved
@fszenborn please check feedback of @jdevries14 Thanks! |
9b07255
to
3b8df8a
Compare
@brusch @dvesh3 I have just rebased on 10.x and applied suggestions from @jdevries14 |
@fszenborn thanks for your changes! After changing the base to 10.x, there's a conflict. Could you please resolve it? |
models/DataObject/ClassDefinition/Data/Extension/RelationFilterConditionParser.php
Outdated
Show resolved
Hide resolved
bundles/AdminBundle/Resources/public/js/pimcore/element/helpers/gridColumnConfig.js
Outdated
Show resolved
Hide resolved
models/DataObject/ClassDefinition/Data/Extension/RelationFilterConditionParser.php
Outdated
Show resolved
Hide resolved
@fszenborn please see my comments above. thanks! |
bundles/AdminBundle/Resources/public/js/pimcore/object/tags/manyToManyRelation.js
Outdated
Show resolved
Hide resolved
@fszenborn any chance to work on the reported issues soon? we should get this done in 10.2 release 🚀 thanks! |
…mcore into divante-filter-by-relation
@dvesh3 just fixed reported issues |
models/DataObject/ClassDefinition/Data/Extension/RelationFilterConditionParser.php
Outdated
Show resolved
Hide resolved
…lterConditionParser.php coding standard update Co-authored-by: Divesh Pahuja <divesh.pahuja@pimcore.com>
@fszenborn great work 👏 thanks a lot! @kubaplas @jdevries14 thanks for the review 😊 |
Changes in this pull request
Additional info
Could someone review/test my changes and leave some feedback or suggestions?
Here is the quick demo of the functionality:
https://user-images.githubusercontent.com/54931392/123623624-f6b28080-d80d-11eb-8274-8c091e409235.mp4
Supported field types are:
one to many
many to many
many to many object
advanced many to many
advanced many to many object
image
advanced image