Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Asset] Grid Improvements - Batch edit Asset metadata #5157

Merged
merged 23 commits into from Nov 11, 2019
Merged

Conversation

dvesh3
Copy link
Contributor

@dvesh3 dvesh3 commented Oct 28, 2019

Changes in this pull request

Resolves #1662

Additional info

This is dependent of #5093

# Conflicts:
#	bundles/AdminBundle/Resources/public/js/pimcore/object/helpers/gridTabAbstract.js
@dvesh3 dvesh3 changed the title Asset grid editing [Asset] Grid Improvements - Batch edit Asset metadata Oct 29, 2019
@kubaplas
Copy link
Contributor

kubaplas commented Oct 30, 2019

@dvesh3 Nice work! As the code is similar to one in DataObject controllers, do you have plans to extract the common base to separate services or helpers?

@brusch as I've been looking into moving out some code from Controller is there a preffered place for code (sql, logic) out of them?
EDIT: I see that additional work is done in #5093, you've already noticed the duplicated code and some logic has been moved to services - really nice ;)

@dvesh3
Copy link
Contributor Author

dvesh3 commented Nov 4, 2019

Hi @kubaplas thanks for your review! we are trying our best to refactor the common functionality as it also leads to testing DataObject grid,..however it will be great if you can review it again after we merge this one and provide new PR for your changes :)

For SQL queries, I would say preferred way is to go with Dao classes.

# Conflicts:
#	bundles/AdminBundle/Controller/Admin/Asset/AssetHelperController.php
#	bundles/AdminBundle/Controller/Admin/AssetController.php
#	bundles/AdminBundle/Helper/GridHelperService.php
#	bundles/AdminBundle/Resources/public/js/pimcore/asset/helpers/gridConfigDialog.js
#	bundles/AdminBundle/Resources/public/js/pimcore/asset/helpers/gridTabAbstract.js
#	bundles/AdminBundle/Resources/public/js/pimcore/asset/listfolder.js
#	bundles/AdminBundle/Resources/public/js/pimcore/element/helpers/gridColumnConfig.js
#	bundles/AdminBundle/Resources/views/Admin/Index/index.html.php
#	bundles/CoreBundle/Resources/migrations/Version20191015131700.php
#	models/Asset/Service.php
#	models/GridConfig.php
@dvesh3 dvesh3 marked this pull request as ready for review November 5, 2019 12:01
@dvesh3 dvesh3 added this to the 6.2.4 ("Berliner Weißbier") milestone Nov 5, 2019
@weisswurstkanone
Copy link
Contributor

what happens if one creates a predefined metadata definition out of the set of default metadata fields (copyright, alt, title) ?

image

image

Copy link
Contributor

@weisswurstkanone weisswurstkanone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review, first round

@dvesh3
Copy link
Contributor Author

dvesh3 commented Nov 6, 2019

Predefined Metadata will not show up in grid config if it has same key as Default Metadata.

what happens if one creates a predefined metadata definition out of the set of default metadata fields (copyright, alt, title) ?

image

image

@brusch brusch self-assigned this Nov 11, 2019
@brusch brusch merged commit c31dc97 into master Nov 11, 2019
@brusch brusch deleted the asset_grid_editing branch November 11, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset folder -> List - add filter for Metadata
4 participants