Support localized calculated fields in object bricks #5390
Conversation
|
could you resolve the conflicts please ? thx |
| @@ -338,12 +344,32 @@ public function getGetterCodeLocalizedfields($class) | |||
| $code .= "\t\t" . '}' . "\n"; | |||
| $code .= "\t" . '}' . "\n"; | |||
|
|
|||
| if($class instanceof DataObject\Objectbrick\Definition) { | |||
| $ownerType = 'objectbrick'; | |||
| $ownerName = $class->getClassDefinitions()[0]['fieldname']; // todo this is not really correct. Actually we need to find out the name of the brick container (an instance of \Pimcore\Model\DataObject\Objectbrick). This must happen during runtime as one brick can be used in multiple brick containers. | |||
There was a problem hiding this comment.
what is the right interpretation of the comment ?
There was a problem hiding this comment.
This means that we cannot determine the name of the class with the brick container field when the brick gets saved. Actually we need to add some code in the generated getter function to determine the brick container field during runtime but I did not find a way to do that because the generated brick class does not know anything in which brick container / data object class it is being used.
And because of that I chose a way to at least enhance the status quo (although this solution is not perfect) by setting the $ownerName to the first configured brick container field of the object brick.
There was a problem hiding this comment.
Hi, just noticed something.
The calculator only gets called if there are other fields with data in the localized field container?
What do you think?
There was a problem hiding this comment.
Why not just take it from $this ?
There was a problem hiding this comment.
Is fieldname the calculated value field in the brick or the brick container field in the data object class? I need the latter.
There was a problem hiding this comment.
the one in the data object class
There was a problem hiding this comment.
Oh, then have overseen this. Thanks, I will change it.
There was a problem hiding this comment.
Done. My test was positive.
There was a problem hiding this comment.
Can you also check this "I noticed something" thing ?
…ized-calculated-value-context-in-objectbrick # Conflicts: # models/DataObject/ClassDefinition/Data/Objectbricks.php
Could you give this a try? The customer which I needed this for has Pimcore 5.8 - there it worked: I have only calculated value fields in the localizedfields container in the brick. I currently have not the time to set up a Pimcore 6 with a localized calculated value in a brick. Could you please give it a try, @weisswurstkanone - if it does not work I will revert the last commit. |
|
It bombs out here because there is no container, $context is empty
|
|
Forgot the context for getFieldDefinitions() - now it is the same call as in Localizedfield::getLazyLoadedFieldNames(). Better? |
|
looks OK from my side |
|
thanks a lot! |
* support localized calculated fields in object bricks * support localized calculated fields in object bricks * bugfix: localized calculated field in object class * set brick container field as ownerName * calculate value also if no real data fields are in localized field collection * calculate value also if no real data fields are in localized field collection
* support localized calculated fields in object bricks * support localized calculated fields in object bricks * bugfix: localized calculated field in object class * set brick container field as ownerName * calculate value also if no real data fields are in localized field collection * calculate value also if no real data fields are in localized field collection
With this PR it is possible to have localized calculated value fields in object bricks.
Resolves #5337