restore: support table partition #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
=========================================
Coverage ? 72.95%
=========================================
Files ? 33
Lines ? 3257
Branches ? 0
=========================================
Hits ? 2376
Misses ? 591
Partials ? 290
Continue to review full report at Codecov.
|
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
overvenus
reviewed
Jan 6, 2020
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
3pointer
reviewed
Jan 6, 2020
3pointer
reviewed
Jan 6, 2020
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
overvenus
reviewed
Jan 7, 2020
| // Sort the tables by id for ensuring the new tables has same id ordering as the old tables. | ||
| // We require this constrain since newTableID of tableID+1 must be not bigger | ||
| // than newTableID of tableID. | ||
| sort.Sort(utils.Tables(tables)) |
| rewriteRules.Table = append(rewriteRules.Table, rules.Table...) | ||
| rewriteRules.Data = append(rewriteRules.Data, rules.Data...) | ||
| newTables = append(newTables, newTableInfo) | ||
| } | ||
| // If tableID + 1 has already exist, then we don't need to add a new rewrite rule for it. | ||
| for oldID, newID := range tableIDMap { |
There was a problem hiding this comment.
We should update validate.go since we change the rewrite process.
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support table partition: