types: floatStrToIntStr will failed in some case such as the param is +999.9999e2 #11376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #11376 +/- ##
================================================
+ Coverage 81.3776% 82.1068% +0.7291%
================================================
Files 424 425 +1
Lines 90939 94360 +3421
================================================
+ Hits 74004 77476 +3472
+ Misses 11620 11488 -132
- Partials 5315 5396 +81 |
|
/run-all-tests |
/run-all-tests |
|
@H-ZeX please follow https://github.com/pingcap/tidb/blob/master/CONTRIBUTING.md to refine the PR title. |
H-ZeX
changed the title
+999.9999e2
H-ZeX
changed the title
+999.9999e2 +999.9999e2
H-ZeX
changed the title
+999.9999e2
crazycs520
reviewed
Jul 24, 2019
types/convert.go
Outdated
| func roundIntStr(numNextDot byte, intStr string) string { | ||
| if numNextDot < '5' { | ||
| return intStr | ||
| } | ||
| retStr := []byte(intStr) | ||
| for i := len(intStr) - 1; i >= 0; i-- { | ||
| if !isDigit(intStr[i]) { |
There was a problem hiding this comment.
yes, but this a valid int string, so we needn't to check whether it is 0.
There was a problem hiding this comment.
If i must be 0, can we move if !isDigit(intStr[i]) logic to outside the for loop?
This was referenced Jul 25, 2019
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
…nto fix-bug-of-floatStrToIntStr
|
ping @crazycs520 |
zz-jason
added
status/can-merge
|
/run-all-tests |
|
@H-ZeX merge failed. |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In the origin
floatStrToIntStr, it may fail in some casenumNextDotis+/-in some case+999.9999e2(return,00000) because theroundIntStrcan not handler+/-correctly.Tests
Related changes