session, executor: support setting tidb_enable_stmt_summary in session scope (#12217) #12308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n scope (pingcap#12217) cherry-pick 12217 to release-3.0
djshow832
added
sig/execution
|
/run-all-tests |
|
LGTM |
bb7133
added
status/LGT2
|
Sorry @bb7133, you don't have permission to trigger auto merge event on this branch. |
bb7133
added a commit
to bb7133/tidb
that referenced
this pull request
Sep 26, 2019
…n session scope (pingcap#12217) (pingcap#12308)" This reverts commit f33c908.
|
/run-cherry-picker |
|
cherry pick to release-3.1 failed |
djshow832
added a commit
to djshow832/tidb
that referenced
this pull request
Sep 30, 2019
…n scope (pingcap#12217) (pingcap#12308) cherry-pick 12308 to release-3.1
winkyao
pushed a commit
that referenced
this pull request
Oct 11, 2019
djshow832
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #12217 to release-3.0, with little conflict-resolve
What problem does this PR solve?
Support setting tidb_enable_stmt_summary in session scope. It was only supported in global scope. Actually, session scope here equals server scope, and global scope here equals cluster scope.
What is changed and how it works?
When statement summary is enabled in global scope, it'll work immediately on the current server and work in 2 seconds on the other servers in the cluster.
When statement summary is enabled in session scope, it'll work immediately on the current server, and subsequent settings in the global scope won't work.
If tidb_enable_stmt_summary is set to '' in session scope, then tidb_enable_stmt_summary in global scope works in the current server.
Check List
Tests
Code changes
Side effects
Related changes
Release Note