*: add a flag EncodeType for response to use Arrow/Default format to decode. #12536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 8, 2019
|
/run-all-tests tikv=pr/5584 |
|
Why the build failed? |
Codecov Report
@@ Coverage Diff @@
## master #12536 +/- ##
===========================================
Coverage 79.9053% 79.9053%
===========================================
Files 460 460
Lines 103137 103137
===========================================
Hits 82412 82412
Misses 14710 14710
Partials 6015 6015 |
|
/run-all-tests tikv=pr/5584 |
XuHuaiyu
reviewed
Oct 8, 2019
|
/run-integration-compatibility-test |
|
/run-integration-compatibility-test tikv=pr/5584 |
|
I change the proto and adjust tidb and tikv's code. |
SunRunAway
added
status/LGT2
|
/run-all-tests |
|
@wshwsh12 merge failed. |
|
/run-all-tests tikv=pr/5584 |
|
/run-all-tests tikv=pr/5584 |
|
/run-all-tests tikv=pr/5584 |
This was referenced Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Now the
SelectResponseuse two field to save Arrow/Default format data. But they are both bytes array and can use the same field. We can add fieldEncodeTypeinstead of fieldRowBatchData.What is changed and how it works?
Remove the field
RowBatchDataand add the flag fieldEncodeType.Check List
Tests
Code changes
Side effects
Related changes
Release note