fix the STR_TO_DATE incompatible between MySQL and TiDB #12623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12623 +/- ##
===========================================
Coverage ? 79.8518%
===========================================
Files ? 462
Lines ? 105007
Branches ? 0
===========================================
Hits ? 83850
Misses ? 14944
Partials ? 6213 |
lonng
changed the title
|
LGTM |
tiancaiamao
reviewed
Oct 11, 2019
wjhuang2016
previously approved these changes
Oct 11, 2019
wjhuang2016
dismissed
their stale review
Failed to select str_to_date('20190101', '%Y%m%d%f');
|
@AilinKid, @tiancaiamao, @wjhuang2016, PTAL. |
|
Please address comment @lonng |
Signed-off-by: Lonng <heng@lonng.org>
ghost
requested review from
qw4990 and
XuHuaiyu
and removed request for
a team
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
|
/run-all-tests |
|
/run-integration-common-test |
|
LGTM |
tiancaiamao
approved these changes
Oct 15, 2019
|
cherry pick to release-3.0 in PR #12725 |
|
cherry pick to release-3.1 in PR #12726 |
|
cherry pick to release-2.1 failed |
ngaut
pushed a commit
that referenced
this pull request
Oct 16, 2019
ngaut
pushed a commit
that referenced
this pull request
Oct 16, 2019
ngaut
pushed a commit
that referenced
this pull request
Oct 16, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Signed-off-by: Lonng <heng@lonng.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
The result of
select str_to_date('20190101','%Y%m%d%H%i%s')is incompitable between MySQL and TiDB.MySQL
TiDB
What is changed and how it works?
Fix it.
Check List
Tests
Release note