*: fix rolling_update_fail when using Arrow format. #12899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wshwsh12
force-pushed
the
rolling_update_fail
branch
from
2fa9e14
to
2185ed1
Compare
Codecov Report
@@ Coverage Diff @@
## master #12899 +/- ##
===========================================
Coverage 80.0299% 80.0299%
===========================================
Files 468 468
Lines 109424 109424
===========================================
Hits 87572 87572
Misses 15138 15138
Partials 6714 6714 |
|
/run-all-tests |
|
/run-all-tests tikv=release-3.0 |
wshwsh12
force-pushed
the
rolling_update_fail
branch
from
2185ed1
to
22fed4b
Compare
|
/run-all-tests tikv=release-3.0 |
|
/run-all-tests tikv=release-3.0 tidb-test=release-3.0 pd=release-3.0 |
wshwsh12
force-pushed
the
rolling_update_fail
branch
from
22fed4b
to
2ff5fc3
Compare
|
/run-all-tests tikv=release-3.0 tidb-test=release-3.0 pd=release-3.0 |
|
/run-all-tests tikv=release-3.0 |
wshwsh12
force-pushed
the
rolling_update_fail
branch
from
2ff5fc3
to
3174116
Compare
|
/run-all-tests tikv=release-3.0 pd=release-3.0 |
|
/run-integration-common-test tikv=release-3.0 pd=release-3.0 |
This was referenced Oct 29, 2019
wshwsh12
force-pushed
the
rolling_update_fail
branch
from
3174116
to
fb6b58d
Compare
|
/run-integration-common-test tikv=release-3.0 pd=release-3.0 |
wshwsh12
force-pushed
the
rolling_update_fail
branch
from
fb6b58d
to
c5e1cb7
Compare
|
/run-all-tests tikv=pr/5754 |
|
/run-all-tests tikv=pr/5754 |
|
CI failed? |
|
/run-all-tests tikv=pr/5754 |
|
@breeswish The fail case in CI has nothing to do with this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In pingcap/tipb#135 , I change the photo and use the same number to indicate it. It will cause a compatibility problem, and rolling_update will fail.
What is changed and how it works?
Use a new number to indicate the new field.
Check List
Tests
Code changes
Side effects
Related changes
Release note