Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: rename Arrow to Chunk #13060

Merged
merged 5 commits into from Nov 6, 2019
Merged

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Oct 31, 2019

What problem does this PR solve?

In tidb, use arrow instead of chunk in some places. This can be misleading.

What is changed and how it works?

In this pr, I change all arrow to chunk.

Check List

Tests

Code changes

Side effects

Related changes

Release note

Related PR

pingcap/tipb#151

@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #13060 into master will decrease coverage by 0.1085%.
The diff coverage is 95.2381%.

@@               Coverage Diff                @@
##             master     #13060        +/-   ##
================================================
- Coverage   80.2132%   80.1046%   -0.1086%     
================================================
  Files           469        468         -1     
  Lines        111534     110840       -694     
================================================
- Hits          89465      88788       -677     
- Misses        15163      15197        +34     
+ Partials       6906       6855        -51

@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Nov 1, 2019

/run-all-tests

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Nov 4, 2019

PTAL @zz-jason

@XuHuaiyu XuHuaiyu added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 4, 2019
@wshwsh12 wshwsh12 force-pushed the rename_arrow_to_chunk branch 2 times, most recently from 4aaafaa to 2a33082 Compare November 5, 2019 12:37
@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Nov 5, 2019

/run-all-tests

# Enable chunk encoded data.
enable-arrow = true
# Enable chunk encoded data for coprocessor requests.
enable-chunk-response = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about s/enable-chunk-response/enable-chunk-rpc/?

} else {
dagReq.EncodeType = tipb.EncodeType_TypeDefault
}
}

func enableTypeArrow(ctx sessionctx.Context) bool {
if !ctx.GetSessionVars().EnableArrow {
func enableTypeChunk(ctx sessionctx.Context) bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about s/enableTypeChunk/canUseChunkRPC/

// tidb_enable_arrow enables TiDB to use Chunk format for coprocessor requests.
TiDBEnableArrow = "tidb_enable_arrow"
// tidb_enable_chunk_response enables TiDB to use Chunk format for coprocessor requests.
TiDBEnableChunkResponse = "tidb_enable_chunk_response"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

util/chunk/chunk.go Outdated Show resolved Hide resolved
util/chunk/chunk_test.go Outdated Show resolved Hide resolved
util/chunk/column.go Outdated Show resolved Hide resolved
Signed-off-by: wshwsh12 <793703860@qq.com>
Signed-off-by: wshwsh12 <793703860@qq.com>
Signed-off-by: wshwsh12 <793703860@qq.com>
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 6, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 6, 2019

Your auto merge job has been accepted, waiting for 13169

@sre-bot
Copy link
Contributor

sre-bot commented Nov 6, 2019

/run-all-tests

@sre-bot sre-bot merged commit 538077f into pingcap:master Nov 6, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@wshwsh12 wshwsh12 deleted the rename_arrow_to_chunk branch April 21, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants