Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: log last executed prepared stmt when panic (#12905) #14322

Merged
merged 1 commit into from Jan 2, 2020
Merged

server: log last executed prepared stmt when panic (#12905) #14322

merged 1 commit into from Jan 2, 2020

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Jan 2, 2020 •
edited

cherry-pick #12905 to 3.0

conflict at preparedStmt2String method

This change is Reviewable

jackysp
jackysp reviewed Jan 2, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 2, 2020
@lysu
Copy link
Collaborator Author

lysu commented Jan 2, 2020

/run-all-tests

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 2, 2020
@ngaut ngaut merged commit 81d276e into pingcap:release-3.0 Jan 2, 2020
@lysu lysu deleted the cp30-panic-sql branch January 3, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
component/server status/LGT2 Indicates that a PR has LGTM 2. type/usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lysu @tiancaiamao @jackysp @ngaut