@@ -226,7 +226,8 @@ protected rd.close $stdout.reopen wr $stderr.reopen wr - exec cmd, *args + exec(cmd, *args) rescue nil + exit! 1 # never gets here unless exec threw or failed end wr.close out = '' Library/Homebrew/formula.rb @@ -88,8 +88,8 @@ end def safe_system cmd, *args puts "#{cmd} #{args*' '}" if ARGV.verbose? fork do - trap("EXIT") {} # no bt on exit from this short-lived fork - exit! 1 unless exec(cmd, *args) + exec(cmd, *args) rescue nil + exit! 1 # never gets here unless exec failed end Process.wait raise ExecutionError.new(cmd, args, $?) unless $?.success? Library/Homebrew/utils.rb ab7697f528071f7e150383ffa20476f5082fd912 Max Howell max@methylblue.com http://github.com/piranha/homebrew/commit/cf04a0b4463cb48be1c69de2fd20e64c3fe14eee cf04a0b4463cb48be1c69de2fd20e64c3fe14eee 2009-11-11T11:42:35-08:00 2009-11-11T11:42:35-08:00 Fix system() exception showing regression Rather than showing a backtrace that says "couldn't find command blah". Admittedly it's possible that the error will be something else, but unlikely. And this is neater. Ideally we'd push the bt through an error pipe like we do with install.rb. And I guess we'll do this eventually. fc47b9c53ae9a204a1de58d76b6b86c576cd2f3a Max Howell max@methylblue.com