85de079ec2af1c3eac452b4f888064ade626aed9 Alex Chaffee alex@stinky.com http://github.com/pivotal/erector/commit/46499e000372f7bae4db9808f7c03aa383b27eec 46499e000372f7bae4db9808f7c03aa383b27eec 2009-12-04T09:11:28-08:00 2009-12-04T09:11:28-08:00 Revert "Reintroducting an Output object, to factor out indentation and the like." This reverts commit 85de079ec2af1c3eac452b4f888064ade626aed9. 6473014e1b7e0974ed425c88125d739972e1352c Alex Chaffee alex@stinky.com e352ca9d3a1ce7897bbb98744b26a8a78ce49d58 Alex Chaffee alex@stinky.com http://github.com/pivotal/erector/commit/85de079ec2af1c3eac452b4f888064ade626aed9 85de079ec2af1c3eac452b4f888064ade626aed9 2009-12-03T12:44:46-08:00 2009-12-03T12:44:46-08:00 Reintroducting an Output object, to factor out indentation and the like. 9c28c242673c8ae0fd6dd41d160ca0d373918083 Alex Chaffee alex@stinky.com 10b9a961a5883c7fa1ff1d402584af5d1b74942f Alex Chaffee alex@stinky.com http://github.com/pivotal/erector/commit/e352ca9d3a1ce7897bbb98744b26a8a78ce49d58 e352ca9d3a1ce7897bbb98744b26a8a78ce49d58 2009-12-03T07:19:47-08:00 2009-12-03T07:16:03-08:00 ActionController::Base omits a few variables from its 'protected_instance_variables' list, so these were getting improperly passed to widgets and tripping up the 'needs' alert. 6473014e1b7e0974ed425c88125d739972e1352c Alex Chaffee alex@stinky.com 5288253db76abe74f1f6c98e2335f1e76382a8e4 Alex Chaffee alex@stinky.com http://github.com/pivotal/erector/commit/10b9a961a5883c7fa1ff1d402584af5d1b74942f 10b9a961a5883c7fa1ff1d402584af5d1b74942f 2009-12-02T23:37:42-08:00 2009-12-02T23:37:42-08:00 bump up some geminstaller gem versions 988b7fabde31a55c0a00ff55d49569c393f653c3 Alex Chaffee alex@stinky.com 1f45314fe2ae110c80faa700c176597d60600097 Alex Chaffee alex@stinky.com http://github.com/pivotal/erector/commit/5288253db76abe74f1f6c98e2335f1e76382a8e4 5288253db76abe74f1f6c98e2335f1e76382a8e4 2009-12-02T23:30:47-08:00 2009-12-02T23:30:47-08:00 oops dad46e9e5168c0231212c2637029a91e166f2023 Alex Chaffee alex@stinky.com aaea5bcb394ee795b15fd63181481439fb267a4d Alex Chaffee alex@stinky.com http://github.com/pivotal/erector/commit/1f45314fe2ae110c80faa700c176597d60600097 1f45314fe2ae110c80faa700c176597d60600097 2009-12-02T23:21:30-08:00 2009-12-02T23:21:30-08:00 updating to rails 2.3.5 -- two tests still failing in some environments 0e3f7481f53a93e146dd34cfcce28b99d887726c Alex Chaffee alex@stinky.com 97b19575827b528c31edf427d7e9c3b9282259f6 Alex Chaffee alex@stinky.com http://github.com/pivotal/erector/commit/aaea5bcb394ee795b15fd63181481439fb267a4d aaea5bcb394ee795b15fd63181481439fb267a4d 2009-12-02T22:59:52-08:00 2009-12-02T22:59:52-08:00 wrap some things in parens to shush Ruby 1.8.6 92b07515859e35d744eeab2dcf50a973e3e4d0b9 Alex Chaffee alex@stinky.com 5961e6a258aa9373ffc20422e60f8c60558973d8 Alex Chaffee alex@stinky.com http://github.com/pivotal/erector/commit/97b19575827b528c31edf427d7e9c3b9282259f6 97b19575827b528c31edf427d7e9c3b9282259f6 2009-12-01T21:52:14-08:00 2009-12-01T21:52:14-08:00 print build environment info in cruise task 5bb1f479e65bbeecf457dfe63bfb40482893fe81 Alex Chaffee alex@stinky.com e7eb9854a6e83820639b69633eb5adda0f3267ff Alex Chaffee alex@stinky.com http://github.com/pivotal/erector/commit/5961e6a258aa9373ffc20422e60f8c60558973d8 5961e6a258aa9373ffc20422e60f8c60558973d8 2009-12-01T17:35:36-08:00 2009-12-01T17:35:36-08:00 Regenerated gemspec for version 0.7.3 4216f67f5df10dceb3245aff3d6907f82db8c984 Alex Chaffee alex@stinky.com 6b5f7ed2029d1e7e06e1547b7f6d117014fd9f1d 6294e5ad1bc468bb4d52050121264e02064767ab Alex Chaffee alex@stinky.com http://github.com/pivotal/erector/commit/e7eb9854a6e83820639b69633eb5adda0f3267ff e7eb9854a6e83820639b69633eb5adda0f3267ff 2009-12-01T17:30:07-08:00 2009-12-01T17:30:07-08:00 Merge remote branch 'remotes/ageweke/master' * remotes/ageweke/master: Fix spec failures. Move ignore_extra_controller_assigns and controller_assigns_propagate_to_partials to Erector::Rails::WidgetExtensions, so they're only added in Rails contexts. Default ignore_extra_controller_assigns to true. Make Erector work with the Cells plugin for Rails (http://cells.rubyforge.org/). Add --method switch to 'erector', in case you don't want the base 'content' method overridden, but something it calls in your superclass, instead. Factor out directly-delegated methods into an array; add url_for and image_path. Make sure 'erector' adds parentheses to function calls when necessary. Don't add empty strings to the end of converted attributes. Don't omit empty attribute strings. Allow setting an alternate superclass for the new widget coming from the 'erector' tool. a few 0.7.2 doc cleanups Add specs that cover the render :widget case and ignore_extra_controller_assigns. Add Widget.controller_assigns_propagate_to_partials: lets you keep controller instance variables from propagating to partials, so that you don't have this giant "global" namespace that partials can pull from. Enforces encapsulation much better. Add Widget.ignore_extra_controller_assigns, which allows widgets to use #needs but silently ignore excess controller variables, rather than raising an exception instead. This can be very useful for transitioning large codebases to Erector. Fix docs to match the code. Fix spec failures -- getting the grammar exactly right is tricky. Make 'erector' ignore ERb trim markers ("-%>"). Make 'erector' process ERb escapes in HTML attributes correctly. 450f361d5e7dcc68daff6bf579eff5c0149dbf22 Alex Chaffee alex@stinky.com 9560e00a2ce7d9098045fbe4cb8a66dd7423c6e7 Alex Chaffee alex@stinky.com http://github.com/pivotal/erector/commit/6b5f7ed2029d1e7e06e1547b7f6d117014fd9f1d 6b5f7ed2029d1e7e06e1547b7f6d117014fd9f1d 2009-12-01T17:26:44-08:00 2009-12-01T17:26:44-08:00 Revert "form improvements, sadly untested" This reverts commit ef4e4985c6e849f096c2435b025c7a925f9ea17f. 01cd80c2286fab304378d5278255f70f7b1d371c Alex Chaffee alex@stinky.com ef4e4985c6e849f096c2435b025c7a925f9ea17f Alex Chaffee alex@stinky.com http://github.com/pivotal/erector/commit/9560e00a2ce7d9098045fbe4cb8a66dd7423c6e7 9560e00a2ce7d9098045fbe4cb8a66dd7423c6e7 2009-12-01T09:03:26-08:00 2009-12-01T09:03:26-08:00 external file improvements 114d8bbae9a4372169a8640870cdf4c86e2b0735 Alex Chaffee alex@stinky.com 206671fee7600acdcb2f556b981bb57e90c469d2 Alex Chaffee alex@stinky.com http://github.com/pivotal/erector/commit/ef4e4985c6e849f096c2435b025c7a925f9ea17f ef4e4985c6e849f096c2435b025c7a925f9ea17f 2009-12-01T08:59:55-08:00 2009-12-01T08:59:55-08:00 form improvements, sadly untested 4d784cbcba2bd896e51448de9617cda85e3ce7f0 Alex Chaffee alex@stinky.com 66170eafbf494240a7a6010cad637d5353203216 Alex Chaffee alex@stinky.com http://github.com/pivotal/erector/commit/206671fee7600acdcb2f556b981bb57e90c469d2 206671fee7600acdcb2f556b981bb57e90c469d2 2009-12-01T07:06:14-08:00 2009-12-01T07:00:09-08:00 externals can accept a File (or any IO, actually) 8985d376426a715916dd85b486e611db928e6d51 Alex Chaffee alex@stinky.com bb4c7d4792fa37ca9a39d468eb95c985692a5476 1d548accda7f001c28a6c07c1f664f5aac4245e7 Alex Chaffee alex@stinky.com http://github.com/pivotal/erector/commit/66170eafbf494240a7a6010cad637d5353203216 66170eafbf494240a7a6010cad637d5353203216 2009-11-24T20:41:16-08:00 2009-11-24T20:41:16-08:00 Merge branch 'master' of github.com:pivotal/erector into recycler * 'master' of github.com:pivotal/erector: a few 0.7.2 doc cleanups Conflicts: History.txt 45e51b0a06677a2fe66e3d29506cdf67a6448651 Alex Chaffee alex@stinky.com 506663e7fdbbeb3c4706a4cfb7cb0839d7224ad5 Andrew Geweke andrew@geweke.org http://github.com/pivotal/erector/commit/6294e5ad1bc468bb4d52050121264e02064767ab 6294e5ad1bc468bb4d52050121264e02064767ab 2009-11-23T18:27:02-08:00 2009-11-23T18:27:02-08:00 Fix spec failures. 27b188fdbe4f29afad41cf31163058a859881b73 Andrew Geweke andrew@geweke.org 1cb39a3eb0af22adcd0b2a117d3a40c38afb4052 Andrew Geweke andrew@geweke.org http://github.com/pivotal/erector/commit/506663e7fdbbeb3c4706a4cfb7cb0839d7224ad5 506663e7fdbbeb3c4706a4cfb7cb0839d7224ad5 2009-11-23T18:24:21-08:00 2009-11-23T18:24:21-08:00 Move ignore_extra_controller_assigns and controller_assigns_propagate_to_partials to Erector::Rails::WidgetExtensions, so they're only added in Rails contexts. Default ignore_extra_controller_assigns to true. 5a5ec636bd9aa7498ebd08c2597be7cce9fc4402 Andrew Geweke andrew@geweke.org 2c100ff187fe686855a26bdd49d72fc53185a323 Andrew Geweke andrew@geweke.org http://github.com/pivotal/erector/commit/1cb39a3eb0af22adcd0b2a117d3a40c38afb4052 1cb39a3eb0af22adcd0b2a117d3a40c38afb4052 2009-11-23T14:25:00-08:00 2009-11-23T14:25:00-08:00 Make Erector work with the Cells plugin for Rails (http://cells.rubyforge.org/). ba01b004686984797efd04df37fd1288ffa5155b Andrew Geweke andrew@geweke.org 89fea9048f1606f43c4f0a0e9620e6a0f88e85fa Andrew Geweke andrew@geweke.org http://github.com/pivotal/erector/commit/2c100ff187fe686855a26bdd49d72fc53185a323 2c100ff187fe686855a26bdd49d72fc53185a323 2009-11-22T13:19:46-08:00 2009-11-22T13:19:46-08:00 Add --method switch to 'erector', in case you don't want the base 'content' method overridden, but something it calls in your superclass, instead. 1f94e68b2fa0bd03c54f201d1155de2101998a9b Andrew Geweke andrew@geweke.org 0093bf762af286573666e3d9a50cf074db2eb955 Alex Chaffee alex@stinky.com http://github.com/pivotal/erector/commit/bb4c7d4792fa37ca9a39d468eb95c985692a5476 bb4c7d4792fa37ca9a39d468eb95c985692a5476 2009-11-19T15:22:52-08:00 2009-11-19T15:22:16-08:00 fix bug in pass-block-to-new inline page rendering c4b9e09c11ddc6bca10ea110dadd1d32f932f0e3 Alex Chaffee alex@stinky.com b9a001e68e2c5e15ce00cd5c3fb77e108a63d8bc Andrew Geweke andrew@geweke.org http://github.com/pivotal/erector/commit/89fea9048f1606f43c4f0a0e9620e6a0f88e85fa 89fea9048f1606f43c4f0a0e9620e6a0f88e85fa 2009-11-17T21:57:30-08:00 2009-11-17T21:57:30-08:00 Factor out directly-delegated methods into an array; add url_for and image_path. 56b16ad402e34926b6ba595119334933f28cc198 Andrew Geweke andrew@geweke.org 99affdfb9d2f01364ea646d2531a06ef647c2c74 Andrew Geweke andrew@geweke.org http://github.com/pivotal/erector/commit/b9a001e68e2c5e15ce00cd5c3fb77e108a63d8bc b9a001e68e2c5e15ce00cd5c3fb77e108a63d8bc 2009-11-17T21:18:01-08:00 2009-11-17T21:18:01-08:00 Make sure 'erector' adds parentheses to function calls when necessary. ac895d1f89677856b48cbe69f5082e04ce19c7cd Andrew Geweke andrew@geweke.org 87451b55e07892581b9f281609db630835afcdd9 Andrew Geweke andrew@geweke.org http://github.com/pivotal/erector/commit/99affdfb9d2f01364ea646d2531a06ef647c2c74 99affdfb9d2f01364ea646d2531a06ef647c2c74 2009-11-17T16:23:37-08:00 2009-11-17T16:23:37-08:00 Don't add empty strings to the end of converted attributes. 556dc6f86af0411e2ec034446ef82f1b8a4b47f5 Andrew Geweke andrew@geweke.org 5676b001bb7a6de21eb68fad89e4bc9d0bdbf020 Andrew Geweke andrew@geweke.org http://github.com/pivotal/erector/commit/87451b55e07892581b9f281609db630835afcdd9 87451b55e07892581b9f281609db630835afcdd9 2009-11-17T16:18:41-08:00 2009-11-17T16:18:41-08:00 Don't omit empty attribute strings. af19c1856b31050c4139eb7c5c568324d26e5e81 Andrew Geweke andrew@geweke.org 9a385e518a3f56b534937c3f373a85c8caf1d074 Andrew Geweke andrew@geweke.org http://github.com/pivotal/erector/commit/5676b001bb7a6de21eb68fad89e4bc9d0bdbf020 5676b001bb7a6de21eb68fad89e4bc9d0bdbf020 2009-11-17T15:19:55-08:00 2009-11-17T15:19:55-08:00 Allow setting an alternate superclass for the new widget coming from the 'erector' tool. 76daa4ced951bfe8deb1fb43ca93195ad59f9f5d Andrew Geweke andrew@geweke.org 5b5971eaa2302e65be01d6ed100f7167c38a6660 Alex Chaffee alex@stinky.com http://github.com/pivotal/erector/commit/9a385e518a3f56b534937c3f373a85c8caf1d074 9a385e518a3f56b534937c3f373a85c8caf1d074 2009-11-17T13:07:00-08:00 2009-11-16T09:41:53-08:00 a few 0.7.2 doc cleanups 6203ff9ea4d99b2385f3640bb5927d5cb6c68271 ageweke andrew_github@geweke.org 3bd7580ebb9ad0420146839d32c83715b97b0ad6 Andrew Geweke andrew@geweke.org http://github.com/pivotal/erector/commit/5b5971eaa2302e65be01d6ed100f7167c38a6660 5b5971eaa2302e65be01d6ed100f7167c38a6660 2009-11-17T13:05:35-08:00 2009-11-17T13:05:35-08:00 Add specs that cover the render :widget case and ignore_extra_controller_assigns. 2cb2b17bc45c34ed11042d31464d8d978c10998a Andrew Geweke andrew@geweke.org dd7676fbe1da4260dc35cb9a76ee97c657aef058 Andrew Geweke andrew@geweke.org http://github.com/pivotal/erector/commit/3bd7580ebb9ad0420146839d32c83715b97b0ad6 3bd7580ebb9ad0420146839d32c83715b97b0ad6 2009-11-17T12:42:06-08:00 2009-11-17T12:42:06-08:00 Add Widget.controller_assigns_propagate_to_partials: lets you keep controller instance variables from propagating to partials, so that you don't have this giant "global" namespace that partials can pull from. Enforces encapsulation much better. bebab8acfdf51e46da426cdf907aabf94e3ac1ad Andrew Geweke andrew@geweke.org 5126f2486de8de42da0dffaf9b22864c0ad0bc06 Andrew Geweke andrew@geweke.org http://github.com/pivotal/erector/commit/dd7676fbe1da4260dc35cb9a76ee97c657aef058 dd7676fbe1da4260dc35cb9a76ee97c657aef058 2009-11-17T12:27:03-08:00 2009-11-17T12:27:03-08:00 Add Widget.ignore_extra_controller_assigns, which allows widgets to use #needs but silently ignore excess controller variables, rather than raising an exception instead. This can be very useful for transitioning large codebases to Erector. aa7da89f338cc46f6203d8bfd50639752d38c2cd Andrew Geweke andrew@geweke.org 8ede63ab56737d360fe3cec9cd0eb9dc91440e34 Andrew Geweke andrew@geweke.org http://github.com/pivotal/erector/commit/5126f2486de8de42da0dffaf9b22864c0ad0bc06 5126f2486de8de42da0dffaf9b22864c0ad0bc06 2009-11-17T11:41:15-08:00 2009-11-17T11:41:15-08:00 Fix docs to match the code. 31581793e81e057da9e097c6ecfef332ca9f8b51 Andrew Geweke andrew@geweke.org