From ad149e16f337ae03fddd69b60ce12a54555ac377 Mon Sep 17 00:00:00 2001 From: "jerico.dev" Date: Tue, 31 Aug 2010 01:21:32 -0300 Subject: [PATCH] *5557* edit_assignments table should be deleted in favor of workflow stage assignement table --- classes/submission/editor/EditorSubmissionDAO.inc.php | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/classes/submission/editor/EditorSubmissionDAO.inc.php b/classes/submission/editor/EditorSubmissionDAO.inc.php index 01cff2a8a28..f6dcc853a30 100644 --- a/classes/submission/editor/EditorSubmissionDAO.inc.php +++ b/classes/submission/editor/EditorSubmissionDAO.inc.php @@ -11,9 +11,9 @@ * @see EditorSubmission * * @brief Operations for retrieving and modifying EditorSubmission objects. + * FIXME #5557: We need a general code cleanup here (remove useless functions), and to integrate with monograph_stage_assignments table */ -/* FIXME #5557: We need a general code cleanup here (remove useless functions), and to integrate with monograph_stage_assignments table */ import('classes.submission.editor.EditorSubmission'); @@ -34,7 +34,8 @@ function EditorSubmissionDAO() { $this->monographDao =& DAORegistry::getDAO('MonographDAO'); $this->authorDao =& DAORegistry::getDAO('AuthorDAO'); $this->userDao =& DAORegistry::getDAO('UserDAO'); - $this->editAssignmentDao =& DAORegistry::getDAO('EditAssignmentDAO'); + // FIXME: Edit assignment DAO has been removed, see #5557. + //$this->editAssignmentDao =& DAORegistry::getDAO('EditAssignmentDAO'); } /** @@ -93,8 +94,9 @@ function &_returnEditorSubmissionFromRow(&$row) { $this->monographDao->_monographFromRow($editorSubmission, $row); // Editor Assignment - $editAssignments =& $this->editAssignmentDao->getByMonographId($row['monograph_id']); - $editorSubmission->setEditAssignments($editAssignments->toArray()); + // FIXME: #5557 breaks this code. + // $editAssignments =& $this->editAssignmentDao->getByMonographId($row['monograph_id']); + // $editorSubmission->setEditAssignments($editAssignments->toArray()); // Editor Decisions $reviewRoundsInfo =& $this->monographDao->getReviewRoundsInfoById($row['monograph_id']);