Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warnings re: is/getDefaultPage #1019

Closed
fulv opened this issue Sep 17, 2015 · 1 comment
Closed

Deprecation warnings re: is/getDefaultPage #1019

fulv opened this issue Sep 17, 2015 · 1 comment
Milestone
Plone 5.0.x

Comments

@fulv
Copy link
Member

fulv commented Sep 17, 2015

This is not in 5.0rc2, but in buildout.coredev:
When starting up an instance, the log shows the following warnings:

/...../plone.app.portlets/plone/app/portlets/portlets/navigation.py:3: DeprecationWarning: isDefaultPage is deprecated. Import from Products.CMFPlone instead
  from plone.app.layout.navigation.defaultpage import isDefaultPage
/...../plone.app.event/plone/app/event/browser/event_listing.py:18: DeprecationWarning: getDefaultPage is deprecated. Import from Products.CMFPlone instead
  from plone.app.layout.navigation.defaultpage import getDefaultPage
fulv added a commit to plone/plone.app.portlets that referenced this issue Sep 17, 2015
@fulv
Fix for plone/Products.CMFPlone#1019.
a8330f2
jensens added a commit to plone/buildout.coredev that referenced this issue Sep 18, 2015
@jensens
[fc] Repository: plone.app.portlets
ed063a6 
Branch: refs/heads/master
Date: 2015-09-17T14:21:44-07:00
Author: Fulvio Casali (fulv) <fulviocasali@gmail.com>
Commit: plone/plone.app.portlets@a8330f2

Fix for plone/Products.CMFPlone#1019.

Files changed:
M plone/app/portlets/portlets/navigation.py
Repository: plone.app.portlets
Branch: refs/heads/master
Date: 2015-09-17T14:22:42-07:00
Author: Fulvio Casali (fulv) <fulviocasali@gmail.com>
Commit: plone/plone.app.portlets@f531a87

Add changelog entry.

Files changed:
M CHANGES.rst
Repository: plone.app.portlets
Branch: refs/heads/master
Date: 2015-09-17T23:29:04+02:00
Author: Johannes Raggam (thet) <raggam-nl@adm.at>
Commit: plone/plone.app.portlets@314b716

Update CHANGES.rst

Files changed:
M CHANGES.rst
Repository: plone.app.portlets
Branch: refs/heads/master
Date: 2015-09-18T18:39:56+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.portlets@a1dc506

Merge pull request #56 from plone/fulv-plone5

Fixes plone/Products.CMFPlone#1019

Files changed:
M CHANGES.rst
M plone/app/portlets/portlets/navigation.py
@fulv fulv reopened this Sep 18, 2015
@fulv
Copy link
Member Author

fulv commented Sep 18, 2015

I have two other PRs for plone.app.event and plone.app.multilingual for the same issue. Also, sorry, but my original commit for plone.app.portlets is probably incorrect.

This was referenced Sep 18, 2015
Merged
Merged
Merged
@polyester polyester added this to the Plone 5.0.x milestone Sep 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Plone 5.0.x
Development

No branches or pull requests
2 participants
@polyester @fulv