@@ -1,5 +1,7 @@ == master +* Fix limits for integer columns being interpreted incorrectly [Michael Grosser] + == 0.1.0 / 2008-12-14 * Remove the PluginAWeek namespace @@ -8,8 +10,8 @@ == 0.0.2 / 2008-06-22 * Remove log files from gems -* Don't check length validation constraints if models were loaded prior to the plugin being loaded [grosser] -* Refactor FormHelper extension to allow for others to easily extend the plugin for things like textarea lengths [grosser] +* Don't check length validation constraints if models were loaded prior to the plugin being loaded [Michael Grosser] +* Refactor FormHelper extension to allow for others to easily extend the plugin for things like textarea lengths [Michael Grosser] * Add support for tracking validates_size_of validations == 0.0.1 / 2008-05-05 CHANGELOG.rdoc @@ -42,8 +42,15 @@ module SmartFieldConstraints # Finds the maximum length according to column limits def column_limit - if column = object.class.columns_hash[method_name] - column.limit + column = object.class.columns_hash[method_name] + + if column && limit = column.limit + if column.text? + limit + elsif column.number? + # Length is bound by the upper limit of the number + 1 (for negatives) + Math.log10(2 ** (limit * 8 - 1)).ceil + 1 + end end end end lib/smart_field_constraints/extensions/form_helper.rb @@ -1,6 +1,7 @@ class CreateUsers < ActiveRecord::Migration def self.up - create_table :users do |t| + create_table :users, :id => false do |t| + t.integer :id, :limit => 4, :null => false # For limit for testing purposes t.string :login, :limit => 12 t.string :password, :limit => 16 t.text :biography test/app_root/db/migrate/001_create_users.rb @@ -57,7 +57,7 @@ class FormHelperWithValidationConstraintsTest < ActionView::TestCase end end -class FormHelperWithColumnConstraintsTest < ActionView::TestCase +class FormHelperWithStringColumnConstraintsTest < ActionView::TestCase tests ActionView::Helpers::FormHelper def setup @@ -85,6 +85,18 @@ class FormHelperWithColumnConstraintsTest < ActionView::TestCase end end +class FormHelperWithNumberColumnConstraintsTest < ActionView::TestCase + tests ActionView::Helpers::FormHelper + + def setup + @user = User.new + end + + def test_should_add_maxlength + assert_equal '<input id="user_id" maxlength="11" name="user[id]" size="30" type="text" />', text_field(:user, :id) + end +end + class FormHelperForModelNotTrackedTest < ActionView::TestCase tests ActionView::Helpers::FormHelper test/helpers/form_helper_test.rb 8708aafc2a8e242b90ef42207167c3dc3714e6f1 Aaron Pfeifer aaron.pfeifer@gmail.com http://github.com/pluginaweek/smart_field_constraints/commit/4a8b5dccac31413b437a5050a66ecb40a1d12b90 4a8b5dccac31413b437a5050a66ecb40a1d12b90 2009-03-15T13:23:50-07:00 2009-03-15T13:23:50-07:00 Fix limits for integer columns being interpreted incorrectly d3068e983111a41bc05cd354ea75a32301fa8046 Aaron Pfeifer aaron.pfeifer@gmail.com