@@ -1,5 +1,6 @@ == master +* Don't style hidden inputs * Fix input styling not always being included on classes directly including ActionView::Helpers::TagHelper == 0.1.0 / 2008-12-14 CHANGELOG.rdoc @@ -6,7 +6,7 @@ ActionView::Helpers::TagHelper.class_eval do # for the tag. def styled_input(name, options = nil) options = (options || {}).stringify_keys - options['class'] = "#{options['class']} #{options['type']}".strip if name.to_s == 'input' && options.include?('type') + options['class'] = "#{options['class']} #{options['type']}".strip if name.to_s == 'input' && options.include?('type') && options['type'] != 'hidden' options end lib/styled_inputs/extensions/tag_helper.rb @@ -1,8 +1,8 @@ require File.dirname(__FILE__) + '/../test_helper' class DateHelperTest < ActionView::TestCase - def test_should_style_hidden_date_fields_if_using_hidden - assert_equal '<input class="hidden" id="date_year" name="date[year]" type="hidden" value="1980" />', select_year(1980, :use_hidden => true).strip + def test_should_not_style_hidden_date_fields_if_using_hidden + assert_equal '<input id="date_year" name="date[year]" type="hidden" value="1980" />', select_year(1980, :use_hidden => true).strip end def test_should_not_style_hidden_date_fields_if_not_using_hidden test/helpers/date_helper_test.rb @@ -20,8 +20,8 @@ class FormHelperTest < ActionView::TestCase assert_equal '<input class="password" id="person_secret" name="person[secret]" size="30" type="password" />', password_field(:person, :secret) end - def test_should_style_hidden_field - assert_equal '<input class="hidden" id="person_name" name="person[name]" type="hidden" />', hidden_field(:person, :name) + def test_should_not_style_hidden_field + assert_equal '<input id="person_name" name="person[name]" type="hidden" />', hidden_field(:person, :name) end def test_should_style_file_field @@ -31,7 +31,7 @@ class FormHelperTest < ActionView::TestCase def test_should_style_check_box expected = '<input class="checkbox" id="person_agree" name="person[agree]" type="checkbox" value="1" />' + - '<input class="hidden" name="person[agree]" type="hidden" value="0" />' + '<input name="person[agree]" type="hidden" value="0" />' assert_equal expected, check_box(:person, :agree) end test/helpers/form_helper_test.rb @@ -5,8 +5,8 @@ class FormTagHelperTest < ActionView::TestCase assert_equal '<input class="text" id="name" name="name" type="text" />', text_field_tag('name') end - def test_should_style_hidden_field_tag - assert_equal '<input class="hidden" id="name" name="name" type="hidden" />', hidden_field_tag('name') + def test_should_not_style_hidden_field_tag + assert_equal '<input id="name" name="name" type="hidden" />', hidden_field_tag('name') end def test_should_style_file_field_tag test/helpers/form_tag_helper_test.rb f0fe1327bb950ae86e7211004cac30d1465d1d82 Aaron Pfeifer aaron.pfeifer@gmail.com http://github.com/pluginaweek/styled_inputs/commit/e21d703e96008cf37f363ae7c50de414f5436665 e21d703e96008cf37f363ae7c50de414f5436665 2008-12-28T14:18:52-08:00 2008-12-28T14:18:52-08:00 Don't style hidden inputs 61a1b6189d062604d9297a4fe8e0b099d396cee4 Aaron Pfeifer aaron.pfeifer@gmail.com