@@ -830,18 +830,25 @@ static NSError *ASIUnableToCreateRequestError; // Handle cookies NSArray *cookies = [NSHTTPCookie cookiesWithResponseHeaderFields:responseHeaders forURL:url]; - [self setResponseCookies:cookies]; + NSMutableArray *newCookies = [[[NSMutableArray alloc] init] autorelease]; + for (NSHTTPCookie *cookie in cookies) { + NSMutableDictionary *properties = [[[NSMutableDictionary alloc] initWithDictionary:[cookie properties]] autorelease]; + [properties setValue:[cookie decodedValue] forKey:NSHTTPCookieValue]; + [newCookies addObject:[NSHTTPCookie cookieWithProperties:properties]]; + } + + [self setResponseCookies:newCookies]; if (useCookiePersistance) { // Store cookies in global persistent store - [[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookies:cookies forURL:url mainDocumentURL:nil]; + [[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookies:newCookies forURL:url mainDocumentURL:nil]; // We also keep any cookies in the sessionCookies array, so that we have a reference to them if we need to remove them later if (!sessionCookies) { [ASIHTTPRequest setSessionCookies:[[[NSMutableArray alloc] init] autorelease]]; NSHTTPCookie *cookie; - for (cookie in cookies) { + for (cookie in newCookies) { [[ASIHTTPRequest sessionCookies] addObject:cookie]; } } Classes/ASIHTTPRequest.m @@ -302,7 +302,6 @@ success = [html isEqualToString:@"I have 'Test Value' as the value of 'ASIHTTPRequestTestCookie'"]; GHAssertTrue(success,@"Custom cookie not presented to the server with cookie persistance OFF"); - // Test removing all cookies works [ASIHTTPRequest clearSession]; @@ -534,4 +533,5 @@ GHAssertTrue(success,@"Failed to correctly display increment progress for a partial download"); } + @end Classes/Tests/ASIHTTPRequestTests.m 83393425435ef4ea69498cbc71c217e797e760ca Ben Copsey ben@allseeing-i.com http://github.com/pokeb/asi-http-request/commit/05ffabc47512aa55c2bd1692340bfb4cf528f916 05ffabc47512aa55c2bd1692340bfb4cf528f916 2009-03-22T11:14:22-07:00 2009-03-22T11:14:22-07:00 Fix cookies values being re-encoded 9657875597955226f58452fea277a60c5446e6be Ben Copsey ben@allseeing-i.com