@@ -212,6 +212,9 @@ static NSError *ASIUnableToCreateRequestError; - (void)appendPostData:(NSData *)data { [self setupPostBody]; + if ([data length] == 0) { + return; + } if ([self shouldStreamPostDataFromDisk]) { [[self postBodyWriteStream] write:[data bytes] maxLength:[data length]]; } else { Classes/ASIHTTPRequest.m @@ -17,5 +17,5 @@ } - (void)testPostWithFileUpload; - +- (void)testEmptyData; @end Classes/Tests/ASIFormDataRequestTests.h @@ -51,6 +51,21 @@ GHAssertTrue(success,@"Failed to upload the correct data (using NSData)"); } +// Test fix for bug where setting an empty string for a form post value would cause the rest of the post body to be ignored (because an NSOutputStream won't like it if you try to write 0 bytes) +- (void)testEmptyData +{ + ASIFormDataRequest *request = [ASIFormDataRequest requestWithURL:[NSURL URLWithString:@"http://allseeing-i.com/ASIHTTPRequest/tests/post-empty"]]; + [request setPostValue:@"hello" forKey:@"a_non_empty_string"]; + [request setPostValue:@"" forKey:@"zzz_empty_string"]; + [request setPostValue:@"there" forKey:@"xxx_non_empty_string"]; + [request setShouldStreamPostDataFromDisk:YES]; + [request buildPostBody]; + [request start]; + + BOOL success = ([[request responseString] isEqualToString:@"a_non_empty_string: hello\r\nzzz_empty_string: \r\nxxx_non_empty_string: there"]); + GHAssertTrue(success,@"Failed to send the correct post data"); + +} @end Classes/Tests/ASIFormDataRequestTests.m 03a71b6a61018521af4eec75e0adb556d80ae74f Ben Copsey ben@allseeing-i.com http://github.com/pokeb/asi-http-request/commit/194cc4035fc8d6288122a30e5420b20b9d402639 194cc4035fc8d6288122a30e5420b20b9d402639 2009-06-16T05:39:17-07:00 2009-06-16T05:39:17-07:00 Fixed issue with specifying an empty string for ASIFormDataRequest parameters Added test for same issue dccda6786c002b9e370c1093995c5d5378c3d9b6 Ben Copsey ben@allseeing-i.com