pokeb / asi-http-request

Easy to use CFNetwork wrapper for HTTP requests, Objective-C, Mac OS X and iPhone

Sort by: Priority | Votes | Last Updated

Loading…

1.

0 votes

ASIHTTPRequest wont cancel when it is downloading data
1 comment Created 5 months ago by nskboy

Title

Body
I noticed strange thing with ASIHTTPRequest when it downloads ~50Kb image over slow cellular connection. In my code I configure ASIHTTPRequest to download ~50Kb image over cellular network. When user wants to cancel the download I send `-[NSOperationQueue cancelAllOperations]` to cancel the request. ASIHTTPRequest's delegate receives `requestDidFailed:` message with ASIRequestCancelledErrorType error. But afterwards delegate receives `requestDidFinished:` message with properly downloaded image. To workaround this issue I send `-[ASIHTTPRequest cancel]` in `requestDidFailed:` if request failed with error ASIRequestCancelledErrorType. I think it's a bug.
or cancel

I noticed strange thing with ASIHTTPRequest when it downloads ~50Kb image over slow cellular connection. In my code I configure ASIHTTPRequest to download ~50Kb image over cellular network. When user wants to cancel the download I send -[NSOperationQueue cancelAllOperations] to cancel the request. ASIHTTPRequest's delegate receives requestDidFailed: message with ASIRequestCancelledErrorType error. But afterwards delegate receives requestDidFinished: message with properly downloaded image. To workaround this issue I send -[ASIHTTPRequest cancel] in requestDidFailed: if request failed with error ASIRequestCancelledErrorType.

I think it's a bug.

Comments

nskboy Fri Jul 17 04:18:42 -0700 2009 | link

It seems like this issue was fixed by c73fb11

Comment
It seems like this issue was fixed by c73fb11abc5d4839cb38fa5ebf55319fade5439a
or cancel

Parsed with GitHub Flavored Markdown
2.

0 votes

readStream null on occasion
7 comments Created 4 months ago by uprise78

Title

Body
I don't have really good reproduce instructions for you on this one because it is so rare but it does happen. I use a standard NSOperationQueue to push all ASIHTTPRequests into and I push a lot of requests through it limited to 4 simulataneously. Around line 717 of ASIHTTPRequest.m there are (rare) occasions when the readStream is NULL and the following line crashes the app: [self setTotalBytesSent:[[(NSNumber *)CFReadStreamCopyProperty(readStream, kCFStreamPropertyHTTPRequestBytesWrittenCount) autorelease] unsignedLongLongValue]];
or cancel

I don't have really good reproduce instructions for you on this one because it is so rare but it does happen. I use a standard NSOperationQueue to push all ASIHTTPRequests into and I push a lot of requests through it limited to 4 simulataneously.

Around line 717 of ASIHTTPRequest.m there are (rare) occasions when the readStream is NULL and
the following line crashes the app:

[self setTotalBytesSent:[[(NSNumber *)CFReadStreamCopyProperty(readStream, kCFStreamPropertyHTTPRequestBytesWrittenCount) autorelease] unsignedLongLongValue]];

Comments

pokeb Sat Aug 22 15:41:51 -0700 2009 | link

Hi

Someone else reported a similar issue earlier this week. I have a what I hope is a fix sorted out, will push it up to GitHub tomorrow.

ta

Ben

Comment
Hi Someone else reported a similar issue earlier this week. I have a what I hope is a fix sorted out, will push it up to GitHub tomorrow. ta Ben
or cancel

uprise78 Sat Aug 22 15:51:46 -0700 2009 | link

Thanks Ben! Sorry I didn't send a patch with the bug. If only there
was more time in each day...

Comment
Thanks Ben! Sorry I didn't send a patch with the bug. If only there was more time in each day...
or cancel

pokeb Sat Aug 22 15:59:57 -0700 2009 | link

I know the feeling... :)

Comment
I know the feeling... :)
or cancel

pokeb Sun Aug 23 02:37:49 -0700 2009 | link

This fix is on GitHub now, do let me know if you are still having problems!

Thanks

Ben

Comment
This fix is on GitHub now, do let me know if you are still having problems! Thanks Ben
or cancel

uprise78 Sun Aug 23 18:45:38 -0700 2009 | link

Looks good to me so far after some testing. Thanks Ben.

Comment
Looks good to me so far after some testing. Thanks Ben.
or cancel

pokeb Mon Aug 24 05:12:14 -0700 2009 | link

Cool, will close the ticket.

Thanks again!

b

Comment
Cool, will close the ticket. Thanks again! b
or cancel

nskboy Tue Oct 06 07:57:29 -0700 2009 | link

Ben, is there a way to link issue fix with commit id?

Comment
Ben, is there a way to link issue fix with commit id?
or cancel

Parsed with GitHub Flavored Markdown
3.

0 votes

POST to basic authed resource fails
6 comments Created 4 months ago by marcusramberg

Title

Body
Seems like asi-http-request is throwing away the POST request body on the second request.
or cancel

Seems like asi-http-request is throwing away the POST request body on the second request.

Comments

pokeb Thu Aug 27 03:16:12 -0700 2009 | link

Hi

Thanks for your report. Can you provide more information on how you are supplying credentials? (eg [request setUsername:], the built-in dialog, via your delegate, etc)

Thanks

Ben

Comment
Hi Thanks for your report. Can you provide more information on how you are supplying credentials? (eg [request setUsername:], the built-in dialog, via your delegate, etc) Thanks Ben
or cancel

zcohan Thu Aug 27 03:34:28 -0700 2009 | link

We're providing credentials using setUsername: and setPassword in the authenticationNeededForRequest delegate method.

Actually we've pinpointed the problem. It only occurs when the ASIFormDataRequest object includes file data to post, added using the setFile:forKey method.

I can give you a sample app if required.

Comment
We're providing credentials using setUsername: and setPassword in the authenticationNeededForRequest delegate method. Actually we've pinpointed the problem. It only occurs when the ASIFormDataRequest object includes file data to post, added using the setFile:forKey method. I can give you a sample app if required.
or cancel

zcohan Thu Aug 27 03:50:21 -0700 2009 | link

using setData:forKey also causes this problem

Comment
using setData:forKey also causes this problem
or cancel

pokeb Thu Aug 27 04:00:48 -0700 2009 | link

Ok, have found the problem. The setFile / setData methods trigger the post body to be streamed from disk, and it looks like the temporary file ASIHTTPRequest creates for the body is being deleted when authentication fails.

Will try to get a fix up in the next couple of hours.

b

Comment
Ok, have found the problem. The setFile / setData methods trigger the post body to be streamed from disk, and it looks like the temporary file ASIHTTPRequest creates for the body is being deleted when authentication fails. Will try to get a fix up in the next couple of hours. b
or cancel

pokeb Thu Aug 27 04:52:37 -0700 2009 | link

I think this problem should be fixed in the last commit - can you try it out your end?

Thanks

Ben

Comment
I think this problem should be fixed in the last commit - can you try it out your end? Thanks Ben
or cancel

pokeb Thu Aug 27 08:08:12 -0700 2009 | link

Confirmed fixed.

Comment
Confirmed fixed.
or cancel

Parsed with GitHub Flavored Markdown
4.

0 votes

Crash when incorrect credentials are sent
2 comments Created 4 months ago by zcohan

Title

Body
I'm setting the credentials with using setUserName and setPassword in the delegate method authenticationNeededForRequest. If credentials are wrong the app crashes. It looks like the authentication delegate method is being called 3 times before the crash occurs, and from what I understand from the code this shouldn't be happening, and the request should just fail if the authorisation attempt count is 2. The crash occurs on the line "[self setRequestCredentials:nil];" in ASIHTTPRequest's "attemptToApplyCredentials". I have an example app if necessary.
or cancel

I'm setting the credentials with using setUserName and setPassword in the delegate method authenticationNeededForRequest. If credentials are wrong the app crashes.

It looks like the authentication delegate method is being called 3 times before the crash occurs, and from what I understand from the code this shouldn't be happening, and the request should just fail if the authorisation attempt count is 2.

The crash occurs on the line "[self setRequestCredentials:nil];" in ASIHTTPRequest's "attemptToApplyCredentials".

I have an example app if necessary.

Comments

pokeb Thu Aug 27 04:57:36 -0700 2009 | link

Ignore 'authenticationRetryCount', it is only used for handling NTLM authentication. I don't think there's any limit on the number of times authenticationNeededForRequest can be called, assuming the wrong credentials are supplied each time.

A sample project would be really helpful => ben@allseeing-i.com.

Thanks!

Ben

Comment
Ignore 'authenticationRetryCount', it is only used for handling NTLM authentication. I don't think there's any limit on the number of times authenticationNeededForRequest can be called, assuming the wrong credentials are supplied each time. A sample project would be really helpful => ben@allseeing-i.com. Thanks! Ben
or cancel

pokeb Thu Aug 27 08:38:21 -0700 2009 | link

Closing - seems to be fixed now.

Comment
Closing - seems to be fixed now.
or cancel

Parsed with GitHub Flavored Markdown
5.

0 votes

responseString returns nil and responseData returns data
3 comments Created 3 months ago by uprise78

Title

Body
The issue is with the following url and any url after this (replace the 100 with 200, 300, 400, etc): http://www.craigslist.org/about/best/all/index100.html The first page of the 'best of' section (http://www.craigslist.org/about/best/all/) works fine. For all other pages responseString returns nil due to trying to convert the responseData (which is properly downloaded) with the wrong encoding. ASI tries to use UTF8 when the actual data is ASCII (or at least using NSASCIIStringEncoding will allow the data to be converted to string). This may or may not be an ASI issue. I will see if I can get some more info and a fix or if it is just a craigslist.org issue with sending different encoding and actual data.
or cancel

The issue is with the following url and any url after this (replace the 100 with 200, 300, 400, etc):
http://www.craigslist.org/about/best/all/index100.html

The first page of the 'best of' section (http://www.craigslist.org/about/best/all/) works fine. For all other pages responseString returns nil due to trying to convert the responseData (which is properly downloaded) with the wrong encoding. ASI tries to use UTF8 when the actual data is ASCII (or at least using NSASCIIStringEncoding will allow the data to be converted to string).

This may or may not be an ASI issue. I will see if I can get some more info and a fix or if it is just a craigslist.org issue with sending different encoding and actual data.

Comments

pokeb Sun Sep 13 03:49:56 -0700 2009 | link

This is definitely an issue with craigslist. The headers specify the content is in UTF8, while the page content itself is in Latin 1. You can test this yourself by changing the encoding in Safari, all the odd question mark characters are replaced with the characters they are supposed to represent when you set the text encoding to Latin 1. ASIHTTPRequest will default to Latin 1 unless the HTTP headers tell it the otherwise, so the HTTP header is tripping it up.

You can have a mismatch between the HTTP headers and the charset specified in HTML or XML content, I think browsers will always give precedence to the later, though ASIHTTPRequest won't attempt to read charsets from the page content. In this case, craigslist doesn't specify a charset in the HTML anyway.

I expect the issue doesn't show up on the first page because it doesn't contain any non-ascii characters.

You could workaround this issue by setting responseEncoding to NSISOLatin1StringEncoding.

Comment
This is definitely an issue with craigslist. The headers specify the content is in UTF8, while the page content itself is in Latin 1. You can test this yourself by changing the encoding in Safari, all the odd question mark characters are replaced with the characters they are supposed to represent when you set the text encoding to Latin 1. ASIHTTPRequest will default to Latin 1 unless the HTTP headers tell it the otherwise, so the HTTP header is tripping it up. You can have a mismatch between the HTTP headers and the charset specified in HTML or XML content, I think browsers will always give precedence to the later, though ASIHTTPRequest won't attempt to read charsets from the page content. In this case, craigslist doesn't specify a charset in the HTML anyway. I expect the issue doesn't show up on the first page because it doesn't contain any non-ascii characters. You could workaround this issue by setting responseEncoding to NSISOLatin1StringEncoding.
or cancel

uprise78 Sun Sep 13 10:53:18 -0700 2009 | link

As always, you are the man. Thanks for looking into this.

Comment
As always, you are the man. Thanks for looking into this.
or cancel

pokeb Wed Sep 30 08:12:39 -0700 2009 | link

Cool, will close this.

Best!

Comment
Cool, will close this. Best!
or cancel

Parsed with GitHub Flavored Markdown
7.

0 votes

[PATCH] Properly encoding form data + setting correct character set header.
5 comments Created 3 months ago by lhunath

Title

Body
The following patch adds proper URL encoding of form data to ASIFormDataRequest. It also sets the charset to UTF-8, the charset that is used throughout ASIFormDataRequest to encode strings into data. Without the former, URL injection is easily possible and people could just pass maliciously crafted data to an application to forge an incorrect request. Without the latter many servers misinterprete the form data as ISO-8859-1 and certain characters get manhandled. diff --git a/device/iphone/safe-online-iphone-client/Sources/ASIHttpRequest/Classes/ASIFormDataRequest.h b/device/iphone/safe-online-iphone-client/Sources/ASIHttpRequest/Classes/ASIFormDataRequest.h index a0991ad..dbc73ed 100644 --- a/device/iphone/safe-online-iphone-client/Sources/ASIHttpRequest/Classes/ASIFormDataRequest.h +++ b/device/iphone/safe-online-iphone-client/Sources/ASIHttpRequest/Classes/ASIFormDataRequest.h @@ -26,6 +26,9 @@ typedef enum _ASIPostFormat { ASIPostFormat postFormat; } +#pragma mark utilities ++ (NSString*) encodeURL:(CFStringRef) string; + #pragma mark setup request // Add a POST variable to the request diff --git a/device/iphone/safe-online-iphone-client/Sources/ASIHttpRequest/Classes/ASIFormDataRequest.m b/device/iphone/safe-online-iphone-client/Sources/ASIHttpRequest/Classes/ASIFormDataRequest.m index 803cf33..29c7827 100644 --- a/device/iphone/safe-online-iphone-client/Sources/ASIHttpRequest/Classes/ASIFormDataRequest.m +++ b/device/iphone/safe-online-iphone-client/Sources/ASIHttpRequest/Classes/ASIFormDataRequest.m @@ -19,6 +19,17 @@ @implementation ASIFormDataRequest +#pragma mark utilities ++ (NSString*) encodeURL:(CFStringRef)string +{ + CFStringRef result = CFURLCreateStringByAddingPercentEscapes(kCFAllocatorDefault, + string, + NULL, + CFSTR(":/?#[]@!$ &'()*+,;=\"<>%{}|\\^~`"), + kCFStringEncodingUTF8); + return [(NSString*) result autorelease]; +} + #pragma mark init / dealloc + (id)requestWithURL:(NSURL *)newURL @@ -181,7 +192,7 @@ return; } - [self addRequestHeader:@"Content-Type" value:@"application/x-www-form-urlencoded"]; + [self addRequestHeader:@"Content-Type" value:@"application/x-www-form-urlencoded; charset=UTF-8"]; NSEnumerator *e = [[self postData] keyEnumerator]; @@ -189,7 +200,7 @@ int i=0; int count = [[self postData] count]-1; while (key = [e nextObject]) { - NSString *data = [NSString stringWithFormat:@"%@=%@%@",[key stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding],[[[self postData] objectForKey:key] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding],(i<count ? @"&" : @"")]; + NSString *data = [NSString stringWithFormat:@"%@=%@%@", [ASIFormDataRequest encodeURL:(CFStringRef)key], [ASIFormDataRequest encodeURL:(CFStringRef)[[self postData] objectForKey:key]],(i<count ? @"&" : @"")]; [self appendPostData:[data dataUsingEncoding:NSUTF8StringEncoding]]; i++; }
or cancel
The following patch adds proper URL encoding of form data to ASIFormDataRequest. It also sets the charset to UTF-8, the charset that is used throughout ASIFormDataRequest to encode strings into data.

Without the former, URL injection is easily possible and people could just pass maliciously crafted data to an application to forge an incorrect request.

Without the latter many servers misinterprete the form data as ISO-8859-1 and certain characters get manhandled.
```
diff --git a/device/iphone/safe-online-iphone-client/Sources/ASIHttpRequest/Classes/ASIFormDataRequest.h b/device/iphone/safe-online-iphone-client/Sources/ASIHttpRequest/Classes/ASIFormDataRequest.h
index a0991ad..dbc73ed 100644
--- a/device/iphone/safe-online-iphone-client/Sources/ASIHttpRequest/Classes/ASIFormDataRequest.h
+++ b/device/iphone/safe-online-iphone-client/Sources/ASIHttpRequest/Classes/ASIFormDataRequest.h
@@ -26,6 +26,9 @@ typedef enum _ASIPostFormat {
    ASIPostFormat postFormat;
 }

+#pragma mark utilities 
++ (NSString*) encodeURL:(CFStringRef) string; 
+ 
 #pragma mark setup request

 // Add a POST variable to the request
diff --git a/device/iphone/safe-online-iphone-client/Sources/ASIHttpRequest/Classes/ASIFormDataRequest.m b/device/iphone/safe-online-iphone-client/Sources/ASIHttpRequest/Classes/ASIFormDataRequest.m
index 803cf33..29c7827 100644
--- a/device/iphone/safe-online-iphone-client/Sources/ASIHttpRequest/Classes/ASIFormDataRequest.m
+++ b/device/iphone/safe-online-iphone-client/Sources/ASIHttpRequest/Classes/ASIFormDataRequest.m
@@ -19,6 +19,17 @@

 @implementation ASIFormDataRequest

+#pragma mark utilities
++ (NSString*) encodeURL:(CFStringRef)string
+{
+   CFStringRef result = CFURLCreateStringByAddingPercentEscapes(kCFAllocatorDefault,
+                                                                 string,
+                                                                 NULL,
+                                                                 CFSTR(":/?#[]@!$ &'()*+,;=\"<>%{}|\\^~`"),
+                                                                 kCFStringEncodingUTF8);
+   return [(NSString*) result autorelease];
+}
+
 #pragma mark init / dealloc

 + (id)requestWithURL:(NSURL *)newURL
@@ -181,7 +192,7 @@
        return;
    }

-   [self addRequestHeader:@"Content-Type" value:@"application/x-www-form-urlencoded"];
+   [self addRequestHeader:@"Content-Type" value:@"application/x-www-form-urlencoded; charset=UTF-8"];


    NSEnumerator *e = [[self postData] keyEnumerator];
@@ -189,7 +200,7 @@
    int i=0;
    int count = [[self postData] count]-1;
    while (key = [e nextObject]) {
-       NSString *data = [NSString stringWithFormat:@"%@=%@%@",[key stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding],[[[self postData] objectForKey:key] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding],(i<count ? @"&" : @"")];
+       NSString *data = [NSString stringWithFormat:@"%@=%@%@", [ASIFormDataRequest encodeURL:(CFStringRef)key], [ASIFormDataRequest encodeURL:(CFStringRef)[[self postData] objectForKey:key]],(i<count ?  @"&" : @"")]; 
        [self appendPostData:[data dataUsingEncoding:NSUTF8StringEncoding]];
        i++;
    }
```
Comments

kevinoneill Mon Sep 28 22:05:52 -0700 2009 | link

i applied this patch and it sorted out problems i was having with posting fields with special characters (eg &).

-k.

Comment
i applied this patch and it sorted out problems i was having with posting fields with special characters (eg &). -k.
or cancel

lhunath Tue Sep 29 02:53:51 -0700 2009 | link

note that the charset should be specified in a few more places. See http://github.com/lhunath/asi-http-request/commit/747280371a7e1c6155e6acb611c657b557abc3a9

Comment
note that the charset should be specified in a few more places. See http://github.com/lhunath/asi-http-request/commit/747280371a7e1c6155e6acb611c657b557abc3a9
or cancel

pokeb Wed Sep 30 08:21:46 -0700 2009 | link

Awesome, thanks, both. :)

Will do some testing over the next couple of days, and get this patch merged in.

Thanks again!

Ben

Comment
Awesome, thanks, both. :) Will do some testing over the next couple of days, and get this patch merged in. Thanks again! Ben
or cancel

pokeb Fri Oct 02 05:40:51 -0700 2009 | link

Ok, this is in the newest version, and I have updated the test based on Alessandro's post to the google group. Please let me know if you find any problems!

Thanks

Ben

Comment
Ok, this is in the newest version, and I have updated the test based on Alessandro's post to the google group. Please let me know if you find any problems! Thanks Ben
or cancel

pokeb Tue Oct 06 15:20:15 -0700 2009 | link

Will close this ticket now, thanks for all your help!

Ben

Comment
Will close this ticket now, thanks for all your help! Ben
or cancel

Parsed with GitHub Flavored Markdown
8.

0 votes

Setting request encodings is not possible
4 comments Created 3 months ago by jorfermo

Title

Body
We were discussing it in this post of the group: http://groups.google.com/group/asihttprequest/browse_thread/thread/1aad7e268ed1444e It would be interesting that we could set the character encoding of the form requests Thank you
or cancel

We were discussing it in this post of the group:

http://groups.google.com/group/asihttprequest/browse_thread/thread/1aad7e268ed1444e

It would be interesting that we could set the character encoding of the form requests

Thank you

Comments

pokeb Wed Sep 30 08:23:09 -0700 2009 | link

This sounds like a great idea, thanks!

Will get something sorted once I've had a chance to catch up on the google group discussions.

Best!

Ben

Comment
This sounds like a great idea, thanks! Will get something sorted once I've had a chance to catch up on the google group discussions. Best! Ben
or cancel

jorfermo Wed Sep 30 08:34:24 -0700 2009 | link

Ok thank you.

Feel free to contact me to make any test if needed.

Regards.

Comment
Ok thank you. Feel free to contact me to make any test if needed. Regards.
or cancel

pokeb Sat Oct 03 06:21:08 -0700 2009 | link

Ok, have added stringEncoding property to ASIFormDataRequest. Please give it a try and let me know how you get on.

Comment
Ok, have added stringEncoding property to ASIFormDataRequest. Please give it a try and let me know how you get on.
or cancel

pokeb Tue Oct 06 15:19:02 -0700 2009 | link

I'm going to close this ticket now, please open a new ticket it you find problems.

Best

Ben

Comment
I'm going to close this ticket now, please open a new ticket it you find problems. Best Ben
or cancel

Parsed with GitHub Flavored Markdown
9.

0 votes

No Progress for ASIS3Request's queued in ASINetworkQueue
11 comments Created 2 months ago by mobilemelting

Title

Body
I've setup multiple ASIS3Request's and added them to a ASINetworkQueue. The S3 Requests have a download and temporary download path, resume download is allowed. I've setup a UIProgressView as downloadProgressDelegate for the queue. However it seems that the progress is not updated. I've debugged the methods: - (void)incrementDownloadSizeBy:(unsigned long long)bytes and - (void)incrementDownloadProgressBy:(unsigned long long)bytes in the ASINetworkQueue class and both times the "bytes" value passed to these methods is 0. Any ideas how to solve this?
or cancel

I've setup multiple ASIS3Request's and added them to a ASINetworkQueue.
The S3 Requests have a download and temporary download path, resume download is allowed.

I've setup a UIProgressView as downloadProgressDelegate for the queue.

However it seems that the progress is not updated.
I've debugged the methods:
- (void)incrementDownloadSizeBy:(unsigned long long)bytes and
- (void)incrementDownloadProgressBy:(unsigned long long)bytes in the ASINetworkQueue class and both times the "bytes" value passed to these methods is 0.

Any ideas how to solve this?

Comments

pokeb Tue Oct 20 09:50:43 -0700 2009 | link

Hi

Have you set showAccurateProgress to YES on the queue?

Thanks

Ben

Comment
Hi Have you set showAccurateProgress to YES on the queue? Thanks Ben
or cancel

mobilemelting Tue Oct 20 10:29:12 -0700 2009 | link

Yes I did that.
[self setNetworkQueue:[ASINetworkQueue queue]]; [[self networkQueue] setShowAccurateProgress:YES];

I've debugged the ASIHTTPRequest class. In the method
- (void)updateDownloadProgress it seems that the "responseHeaders" is empty, because the "if" always fails. // We won't update download progress until we've examined the headers, since we might need to authenticate if (responseHeaders) {
.....

Comment
Yes I did that. [self setNetworkQueue:[ASINetworkQueue queue]]; [[self networkQueue] setShowAccurateProgress:YES]; I've debugged the ASIHTTPRequest class. In the method - (void)updateDownloadProgress it seems that the "responseHeaders" is empty, because the "if" always fails. // We won't update download progress until we've examined the headers, since we might need to authenticate if (responseHeaders) { .....
or cancel

pokeb Tue Oct 20 10:38:11 -0700 2009 | link

If the response headers are empty, it's unlikely to be downloading any data at all.

Did you start the queue ([[self networkQueue] go]?) If so, are you getting an error in your requestDidFailSelector delegate method?

Comment
If the response headers are empty, it's unlikely to be downloading any data at all. Did you start the queue ([[self networkQueue] go]?) If so, are you getting an error in your requestDidFailSelector delegate method?
or cancel

mobilemelting Tue Oct 20 10:51:55 -0700 2009 | link

Well the data is downloaded.

I've setup the delegate methods like you recommended in the gist http://gist.github.com/150447: /> [[self networkQueue] setRequestDidFinishSelector:@selector(requestFinished:)]; [[self networkQueue] setRequestDidFailSelector:@selector(requestFailed:)]; [[self networkQueue] setQueueDidFinishSelector:@selector(queueFinished:)];

However none of the delegate methods is called (I've added log messages).
Not even the "queueFinished" delegate method. Although the data is downloaded successfully.

Comment
Well the data is downloaded. I've setup the delegate methods like you recommended in the gist http://gist.github.com/150447: [[self networkQueue] setRequestDidFinishSelector:@selector(requestFinished:)]; [[self networkQueue] setRequestDidFailSelector:@selector(requestFailed:)]; [[self networkQueue] setQueueDidFinishSelector:@selector(queueFinished:)]; However none of the delegate methods is called (I've added log messages). Not even the "queueFinished" delegate method. Although the data is downloaded successfully.
or cancel

pokeb Tue Oct 20 10:54:34 -0700 2009 | link

Ok. Can you mail me your code, (ben@allseeing-i.com) and I'll take a look?

Thanks

Ben

Comment
Ok. Can you mail me your code, (ben@allseeing-i.com) and I'll take a look? Thanks Ben
or cancel

mobilemelting Tue Oct 20 22:57:38 -0700 2009 | link

Source can be found here: http://gist.github.com/214556

Comment
Source can be found here: http://gist.github.com/214556
or cancel

mobilemelting Tue Oct 20 23:55:51 -0700 2009 | link

If I do set the UIProgressView Delegate directly for each s3Request it works.

// [s3Request setDownloadProgressDelegate:[dc progress]];

However this causes the progress bar to flicker, because each s3Request reports its own
progress. It seems that the ASIS3Request is capable of reporting progress. But the queue
seems to be unable to query and summarize the request's progress.

Comment
If I do set the UIProgressView Delegate directly for each s3Request it works. // [s3Request setDownloadProgressDelegate:[dc progress]]; However this causes the progress bar to flicker, because each s3Request reports its own progress. It seems that the ASIS3Request is capable of reporting progress. But the queue seems to be unable to query and summarize the request's progress.
or cancel

pokeb Thu Oct 22 03:23:48 -0700 2009 | link

Ok, I think I see the problem. It will work when accurate progress is off, but not when it is turned on. ASIS3Requests don't have their HEAD request built properly when using an ASINetworkQueue. Will try to fix this morning.

Comment
Ok, I think I see the problem. It will work when accurate progress is off, but not when it is turned on. ASIS3Requests don't have their HEAD request built properly when using an ASINetworkQueue. Will try to fix this morning.
or cancel

pokeb Thu Oct 22 08:03:31 -0700 2009 | link

Refactor ASIHTTPRequest, ASIS3Request to allow HEAD requests created by ASINetworkQueues to override headers on their main request
This should fix accurate progress tracking for ASINetworkQueues containing ASIS3Requests
Added progress test for ASIS3Request
Hopefully closed by 47b4e2c

Comment
Refactor ASIHTTPRequest, ASIS3Request to allow HEAD requests created by ASINetworkQueues to override headers on their main request This should fix accurate progress tracking for ASINetworkQueues containing ASIS3Requests Added progress test for ASIS3Request Hopefully closed by 47b4e2cc35e094799db094a74ed6d4e8dc9a5e7e
or cancel

pokeb Thu Oct 22 08:04:45 -0700 2009 | link

Ok, this was a bit more tricky to fix than I thought... can you try with the latest version and let me know if it seems to be working now?

Comment
Ok, this was a bit more tricky to fix than I thought... can you try with the latest version and let me know if it seems to be working now?
or cancel

mobilemelting Fri Oct 23 03:13:44 -0700 2009 | link

Perfect!
Works like a charm!
Thanks!

Comment
Perfect! Works like a charm! Thanks!
or cancel

Parsed with GitHub Flavored Markdown
10.

1 vote

Can ASINetworkQueue get a NSDictionary "userInfo" ?
8 comments Created 2 months ago by mobilemelting

Title

Body
In order to distinguish between multiple queues it would be great if ASINetworkQueue gets a "userInfo" NSDictionary. I've already added it to this gist source here: http://gist.github.com/215015
or cancel

In order to distinguish between multiple queues it would be great if ASINetworkQueue gets a "userInfo" NSDictionary.

I've already added it to this gist source here: http://gist.github.com/215015

Comments

pokeb Thu Oct 22 12:15:38 -0700 2009 | link

Hi again

Can you explain more about when you might need to be able to do this? In general you should avoid having several queues in use at the same time, if requests are running in each it will degrade performance and increase the chances that requests will timeout.

Perhaps you'd like to use a feature like this in some other way, if I can understand more about why you want this, it will help. :)

Best

Ben

Comment
Hi again Can you explain more about when you might need to be able to do this? In general you should avoid having several queues in use at the same time, if requests are running in each it will degrade performance and increase the chances that requests will timeout. Perhaps you'd like to use a feature like this in some other way, if I can understand more about why you want this, it will help. :) Best Ben
or cancel

mobilemelting Fri Oct 23 02:59:34 -0700 2009 | link

Actually I don't run multiple queues at the same time. Its always one after the other.

But, when a queue is finished I want to broadcast some events. Therefore I need some information about the resources this queue and its request have been working on.

In my case I mark a "container" for download. This container has information about resources, which should be downloaded. So I create a queue for this container and add multiple request for the single downloads. I start the queue and when its finished I want to trigger some events to let the application know that the resources (a.k.a. container) are now available locally.

I figured that having a NSDictionary 'userInfo' for storing this kind of information with the queue would be a good thing.

Comment
Actually I don't run multiple queues at the same time. Its always one after the other. But, when a queue is finished I want to broadcast some events. Therefore I need some information about the resources this queue and its request have been working on. In my case I mark a "container" for download. This container has information about resources, which should be downloaded. So I create a queue for this container and add multiple request for the single downloads. I start the queue and when its finished I want to trigger some events to let the application know that the resources (a.k.a. container) are now available locally. I figured that having a NSDictionary 'userInfo' for storing this kind of information with the queue would be a good thing.
or cancel

pokeb Fri Oct 23 03:07:30 -0700 2009 | link

Ok, cool. I'll add this in the next couple of days.

Alternatively, if you create an ASIHTTPRequest fork on GitHub (it's really easy if you haven't done it before) and publish this change there, I can merge it in easily and you'll be credited as the author directly in the commit.

Thanks

Ben

Comment
Ok, cool. I'll add this in the next couple of days. Alternatively, if you create an ASIHTTPRequest fork on GitHub (it's really easy if you haven't done it before) and publish this change there, I can merge it in easily and you'll be credited as the author directly in the commit. Thanks Ben
or cancel

mobilemelting Mon Oct 26 09:40:27 -0700 2009 | link

Hi Ben,

I've forked your project and added the NSDictionary "userInfo" addition to ASINetworkQueue. Please find the fork here: http://github.com/mobilemelting/asi-http-request

Comment
Hi Ben, I've forked your project and added the NSDictionary "userInfo" addition to ASINetworkQueue. Please find the fork here: http://github.com/mobilemelting/asi-http-request
or cancel

mobilemelting Mon Oct 26 09:41:08 -0700 2009 | link

Do I need to do anything else or can you simple merge this into your trunk?

Comment
Do I need to do anything else or can you simple merge this into your trunk?
or cancel

pokeb Mon Oct 26 10:31:01 -0700 2009 | link

Great, thanks very much! I'll merge it in later this week.

One small issue - the dictionary needs to be a retained property.

Best,

Ben

Comment
Great, thanks very much! I'll merge it in later this week. One small issue - the dictionary needs to be a retained property. Best, Ben
or cancel

mobilemelting Tue Oct 27 14:49:10 -0700 2009 | link

Fixed that and commited to the branch.

Comment
Fixed that and commited to the branch.
or cancel

pokeb Fri Oct 30 12:02:30 -0700 2009 | link

Ok, it's in master now.

Comment
Ok, it's in master now.
or cancel

Parsed with GitHub Flavored Markdown
11.

0 votes

immediateCancel test is failing
1 comment Created 2 months ago by pokeb

Title

Body
In the right circumstances, the same request is able to call both its success and failure delegate methods, this shouldn't be possible. Must have been broken as a result of recent changes.
or cancel

In the right circumstances, the same request is able to call both its success and failure delegate methods, this shouldn't be possible. Must have been broken as a result of recent changes.

Comments

pokeb Sat Oct 31 04:32:44 -0700 2009 | link

Don't cancel a request if it has already finished
Closed by 35fd545

Comment
Don't cancel a request if it has already finished Closed by 35fd545f67e14acb0f12cfb873805f0967693324
or cancel

Parsed with GitHub Flavored Markdown
12.

0 votes

reachability 2.0 support
1 comment Created 2 months ago by TheAggie

Title

Body
apple has updated its reachability class to version 2.0 which currently breaks ASIHTTPRequest
or cancel

apple has updated its reachability class to version 2.0 which currently breaks ASIHTTPRequest

Comments

pokeb Fri Oct 23 02:00:23 -0700 2009 | link

Hi Scott

A few people have sent in patches over the last few months, however, I don't believe the updated class works on 2.2.1, so I'm holding off changing it for now.

Best

Ben

Comment
Hi Scott A few people have sent in patches over the last few months, however, I don't believe the updated class works on 2.2.1, so I'm holding off changing it for now. Best Ben
or cancel

Parsed with GitHub Flavored Markdown
14.

0 votes

S3 upload file missing data on device, but not on simulator
5 comments Created about 1 month ago by rpstro02

Title

Body
I'm experiencing an issue with an Amazon S3 file upload. The simulator works great. But the exact same code on the device doesn't seem to upload the entire 166 Kb .png picture file. It only seems to upload 159 Kb. When I try to open the image, I get an error. I've tried both 3G network and WiFi. Both with the same result. Anyone experienced this issue or know what the problem could be? I am on an iPhone 3Gs running OS 3.1.
or cancel

I'm experiencing an issue with an Amazon S3 file upload. The simulator works great. But the exact same code on the device doesn't seem to upload the entire 166 Kb .png picture file. It only seems to upload 159 Kb. When I try to open the image, I get an error. I've tried both 3G network and WiFi. Both with the same result. Anyone experienced this issue or know what the problem could be? I am on an iPhone 3Gs running OS 3.1.

Comments

rpstro02 Sat Nov 21 12:16:28 -0800 2009 | link

Update. The issue seems to only be with PNG files. I think it might be similar to the same problem that occurs on the cocoahttpserver here:

http://code.google.com/p/cocoahttpserver/issues/detail?id=15#c4

I'm not sure what the deal is with png files on the iPhone.

Comment
Update. The issue seems to only be with PNG files. I think it might be similar to the same problem that occurs on the cocoahttpserver here: http://code.google.com/p/cocoahttpserver/issues/detail?id=15#c4 I'm not sure what the deal is with png files on the iPhone.
or cancel

rpstro02 Sat Nov 21 13:30:56 -0800 2009 | link

I think I could fix the issue the same way the cocoahttpserver fixes the issue if I stream a file from memory as opposed to from the disk. I'm not sure how to do that right now. If anyone does, please post.

Comment
I think I could fix the issue the same way the cocoahttpserver fixes the issue if I stream a file from memory as opposed to from the disk. I'm not sure how to do that right now. If anyone does, please post.
or cancel

pokeb Sun Nov 22 00:59:10 -0800 2009 | link

Are you trying to upload a png you added to your project?

If I'm reading it correctly, the problem on the link you sent seems to be related to Xcode pre-multiplying the alpha on the image, which makes the png unreadable by other apps.

To use the fix they suggest, try something like this:

UIImage imagePNG= [UIImage imageWithContentsOfFile:filePath];
NSData pngData= UIImagePNGRepresentation(imagePNG);
[pngData writeToFile:somewhere atomically:NO]; ASIS3Request *request = [ASIS3Request PUTRequestForFile:somewhere withBucket:bucket path:path];

Writing it back to a file is necessary because ASIS3Request doesn't have support for uploading data except from a file, though I think this would be a worthwhile addition to the class.

Thanks

Ben

Comment
Are you trying to upload a png you added to your project? If I'm reading it correctly, the problem on the link you sent seems to be related to Xcode pre-multiplying the alpha on the image, which makes the png unreadable by other apps. To use the fix they suggest, try something like this: UIImage *imagePNG= [UIImage imageWithContentsOfFile:filePath]; NSData *pngData= UIImagePNGRepresentation(imagePNG); [pngData writeToFile:somewhere atomically:NO]; ASIS3Request *request = [ASIS3Request PUTRequestForFile:somewhere withBucket:bucket path:path]; Writing it back to a file is necessary because ASIS3Request doesn't have support for uploading data except from a file, though I think this would be a worthwhile addition to the class. Thanks Ben
or cancel

rpstro02 Sun Nov 22 10:00:31 -0800 2009 | link

Thanks for the reply. I'm trying to upload a png that I added to the project bundle. I tried to read the file straight from disk. I will try what you're suggesting. I am pretty sure there is some sort of issue with the alpha on the image because when I view image info of the uploaded file, it's different from the alpha value of the original image.

Uploading from data would rock!

Comment
Thanks for the reply. I'm trying to upload a png that I added to the project bundle. I tried to read the file straight from disk. I will try what you're suggesting. I am pretty sure there is some sort of issue with the alpha on the image because when I view image info of the uploaded file, it's different from the alpha value of the original image. Uploading from data would rock!
or cancel

pokeb Fri Dec 18 10:41:13 -0800 2009 | link

Added PUTRequestForData:etc to ASIS3Request
Closed by b3de943.

Also fixed unit tests for S3 on Mac, continued fallout from that setDoubleValue: debacle

Comment
Added PUTRequestForData:etc to ASIS3Request Closed by b3de943af8c6f37192990c413666c85217146d07. Also fixed unit tests for S3 on Mac, continued fallout from that setDoubleValue: debacle
or cancel

Parsed with GitHub Flavored Markdown
6.

0 votes

iPhone 3.1 and FileUpload
1 comment Created 3 months ago by haligasd

Title

Body
Been using the File upload for quite some time and every since 3.1 came out on the iPhone I get the error "Domain=ASIHTTPRequestErrorDomain Code = 1 UserInfo == xxxx 'A connection failure occurred: SSL problem (possibly a bad/expired/self-signed certificate)'" Our hosting provider assures us all is good on the cert/config areas. This is totally random and when I am good 3G coverage. I can immediately retry and it may or may not work. Not sure if this is an issue in the ASI code just wanted to toss it out there in case anyone else is having this.
or cancel

Been using the File upload for quite some time and every since 3.1 came out on the iPhone I get the error "Domain=ASIHTTPRequestErrorDomain Code = 1 UserInfo == xxxx 'A connection failure occurred: SSL problem (possibly a bad/expired/self-signed certificate)'"

Our hosting provider assures us all is good on the cert/config areas.

This is totally random and when I am good 3G coverage. I can immediately retry and it may or may not work. Not sure if this is an issue in the ASI code just wanted to toss it out there in case anyone else is having this.

Comments

pokeb Wed Sep 30 08:19:12 -0700 2009 | link

Hi

Sorry for the delay in getting back to you on this, I've been away for a couple of weeks.

Hmm, that does sound like a curious issue. If you have any 3.0 or 2.2.1 devices, can you see this issue? Does it make any difference if you set validatesSecureCertificate to NO? (I don't recommend you do this in shipping apps)

I guess it's possible that a bug has crept in somewhere which is causing this error to be erroneously triggered, perhaps the release of the problem ASIHTTPRequest code coincided with the 3.1 release. Are you using the latest version of ASIHTTPRequest?

It would be helpful if you could drop me details on the url(s) you're seeing this problem with - ben@allseeing-i.com.

Thanks

Ben

Comment
Hi Sorry for the delay in getting back to you on this, I've been away for a couple of weeks. Hmm, that does sound like a curious issue. If you have any 3.0 or 2.2.1 devices, can you see this issue? Does it make any difference if you set validatesSecureCertificate to NO? (I don't recommend you do this in shipping apps) I guess it's possible that a bug has crept in somewhere which is causing this error to be erroneously triggered, perhaps the release of the problem ASIHTTPRequest code coincided with the 3.1 release. Are you using the latest version of ASIHTTPRequest? It would be helpful if you could drop me details on the url(s) you're seeing this problem with - ben@allseeing-i.com. Thanks Ben
or cancel

Parsed with GitHub Flavored Markdown
13.

0 votes

Refactor progress tracking code
0 comments Created about 1 month ago by pokeb

Title

Body
Progress tracking code feels messy and contains lots of repetition. [lhunath's fork](http://github.com/lhunath/asi-http-request/commit/d28fe4062bc2bb665e3d5828e2266584800f30d2) has moved the queue progress methods into a protocol, it would be worth looking at this too.
or cancel

Progress tracking code feels messy and contains lots of repetition.

lhunath's fork has moved the queue progress methods into a protocol, it would be worth looking at this too.

Comments

Parsed with GitHub Flavored Markdown

Labels

pokeb / asi-http-request

Pledgie Donations

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments