From 2c986d8eaff47a6a181a1c1f43d88443cedfa418 Mon Sep 17 00:00:00 2001 From: Juriy Zaytsev Date: Sun, 22 Mar 2009 10:53:08 -0400 Subject: [PATCH] Remove unused local variables. Fix failing form test. --- CHANGELOG | 2 ++ src/dom/dom.js | 2 +- test/unit/form_test.js | 4 ++-- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index 08cff6f57..5788fc965 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3 +1,5 @@ +* Remove unused local variables from `Element.extend`. Fix one of the form tests to remove `_extendedByPrototype` by setting it to `undefined` rather than `false` (`_extendedByPrototype` being `false` does not force `Element.extend` to re-extend element). (T.J. Crowder, kangax) + * Make test for `escapeHTML`/`unescapeHTML` more strict. (Chrome 1.x escapes "<" and "&" with `innerHTML`, but not ">") (kangax) * Remove another sniffing from one of DOM tests. Fixes last IE8 failure. (kangax) diff --git a/src/dom/dom.js b/src/dom/dom.js index 8dc9f2ee5..f7c8d090b 100644 --- a/src/dom/dom.js +++ b/src/dom/dom.js @@ -1690,7 +1690,7 @@ Element.extend = (function() { element.nodeType != 1 || element == window) return element; var methods = Object.clone(Methods), - tagName = element.tagName.toUpperCase(), property, value; + tagName = element.tagName.toUpperCase(); // extend methods for specific tags if (ByTag[tagName]) Object.extend(methods, ByTag[tagName]); diff --git a/test/unit/form_test.js b/test/unit/form_test.js index f3ae5384d..502691e7f 100644 --- a/test/unit/form_test.js +++ b/test/unit/form_test.js @@ -291,8 +291,8 @@ new Test.Unit.Runner({ form = $('bigform'); var input = form['tf_text'], select = form['tf_selectOne']; - input._extendedByPrototype = select._extendedByPrototype = false; - + input._extendedByPrototype = select._extendedByPrototype = void 0; + this.assert($(input).anInputMethod); this.assert(!input.aSelectMethod); this.assertEqual('input', input.anInputMethod());