Filter the for(var k in ...) entries with hasOwnProperty() call in Ro…

…leEditor. Fixes #789
pydio · Dec 30, 2014 · 3c9029f · 3c9029f
1 parent 62bbed7
commit 3c9029f
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/core/src/plugins/editor.ajxp_role/class.RoleEditor.js b/core/src/plugins/editor.ajxp_role/class.RoleEditor.js
@@ -114,8 +114,10 @@ Class.create("RoleEditor", AbstractEditor, {
             var objectValue = pair.value.evalJSON();
             var repoScope = pName;
             for(var pluginId in objectValue){
+                if(!objectValue.hasOwnProperty(pluginId)) continue;
                 var pluginData = objectValue[pluginId];
                 for(var paramName in pluginData){
+                    if(!pluginData.hasOwnProperty(paramName)) continue;
                     // update roleWrite
                     if(!this.roleWrite.PARAMETERS[repoScope]) this.roleWrite.PARAMETERS[repoScope] = {};
                     if(!this.roleWrite.PARAMETERS[repoScope][pluginId]) this.roleWrite.PARAMETERS[repoScope][pluginId] = {};
@@ -515,7 +517,9 @@ Class.create("RoleEditor", AbstractEditor, {
 
     feedPluginsSelectors : function(jsonData, select){
         var oManager = this;
+        window.jsd = jsonData;
         for(var key in jsonData.LIST){
+            if(!jsonData.LIST.hasOwnProperty(key)) continue;
             select.insert(new Element("option", {value:key}).update(key));
         }
         var nextSelect = select.up("div.SF_element").next().down("select");
@@ -543,7 +547,7 @@ Class.create("RoleEditor", AbstractEditor, {
             nextSelect.select("*").invoke("remove");
             nextSelect.insert(new Element("option", {value:-1}).update((type == "action" ? MessageHash["ajxp_role_editor.12a"]:MessageHash["ajxp_role_editor.12b"])));
             for(var key in actions){
-                if(!actions[key][type]) continue;
+                if(!actions.hasOwnProperty(key) || !actions[key][type]) continue;
                 var label = actions[key]['label'];
                 if(label){
                     if(MessageHash[label]) label = actions[key][type] +" (" +MessageHash[label] +")";
@@ -575,6 +579,7 @@ Class.create("RoleEditor", AbstractEditor, {
             select.insert(new Element("option", {value:"AJXP_REPO_SCOPE_ALL"}).update(MessageHash["ajxp_role_editor.12d"]));
             select.insert(new Element("option", {value:"AJXP_REPO_SCOPE_SHARED"}).update(MessageHash["ajxp_role_editor.12e"]));
             for(var key in repositories){
+                if(!repositories.hasOwnProperty(key)) continue;
                 select.insert(new Element("option", {value:key}).update(repositories[key]));
             }
             //select.disabled = false;
@@ -589,6 +594,7 @@ Class.create("RoleEditor", AbstractEditor, {
         if(!Object.keys(repositories).length) return;
         //repositories.sortBy(function(element) {return XPathGetSingleNodeText(element, "label");});
    		for(var repoId in repositories){
+            if(!repositories.hasOwnProperty(repoId)) continue;
    			var repoLabel = repositories[repoId];
    			var readBox = new Element('input', {type:'checkbox', id:'chck_'+repoId+'_read'});
    			var writeBox = new Element('input', {type:'checkbox', id:'chck_'+repoId+'_write'});