Do no reinvent dibi (use (%s))

Signed-off-by: Etienne CHAMPETIER <etienne.champetier@fiducial.net>
pydio · Oct 7, 2013 · dbdd9a3 · dbdd9a3
1 parent 18d1479
commit dbdd9a3
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/core/src/plugins/conf.sql/class.sqlConfDriver.php b/core/src/plugins/conf.sql/class.sqlConfDriver.php
@@ -200,13 +200,12 @@ public function listRepositories($user = null)
             $acls = $user->mergedRole->listAcls();
             $limitRepositories = array_keys($acls);
             if(!count($limitRepositories)) return array();
-            foreach($limitRepositories as $i => $k) $limitRepositories[$i] = "'$k'";
-            $query = 'SELECT * FROM [ajxp_repo] WHERE uuid IN ('.implode(",",$limitRepositories).') ORDER BY [display] ASC';
+            // we use (%s) instead of %in to pass int as string ('1' instead of 1)
+            $res = dibi::query('SELECT * FROM [ajxp_repo] WHERE [uuid] IN (%s) ORDER BY [display] ASC', $limitRepositories);
         } else {
-            $query = 'SELECT * FROM [ajxp_repo] ORDER BY [display] ASC';
+            $res = dibi::query('SELECT * FROM [ajxp_repo] ORDER BY [display] ASC');
         }
 
-        $res = dibi::query($query);
         $all = $res->fetchAll();
 
         $repositories = Array();