Skip to content
This repository has been archived by the owner on Nov 25, 2020. It is now read-only.

Commit

Permalink
Fix remoteNodeProvider: empty response could end up in the node stayi…
Browse files Browse the repository at this point in the history
…ng in _loading mode.
  • Loading branch information
cdujeu committed Jul 17, 2015
1 parent deecb10 commit e6d1da1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Expand Up @@ -180,12 +180,12 @@ var RemoteNodeProvider = (function () {

RemoteNodeProvider.prototype.parseNodes = function parseNodes(origNode, transport, nodeCallback, childCallback, childrenOnly) {
if (!transport.responseXML || !transport.responseXML.documentElement) {
Logger.debug('Loading node ' + origNode.getPath() + ' has wrong response: ' + transport.responseText);
if (nodeCallback) nodeCallback(origNode);
origNode.setLoaded(false);
if (!transport.responseText) {
throw new Error('Empty response!');
}
Logger.debug(transport.responseText);
if (nodeCallback) nodeCallback(origNode);
origNode.setLoaded(false);
throw new Error('Invalid XML Document (see console)');
}
var rootNode = transport.responseXML.documentElement;
Expand Down
Expand Up @@ -165,12 +165,12 @@ class RemoteNodeProvider{
*/
parseNodes (origNode, transport, nodeCallback, childCallback, childrenOnly){
if(!transport.responseXML || !transport.responseXML.documentElement) {
Logger.debug('Loading node ' + origNode.getPath() + ' has wrong response: ' + transport.responseText);
if(nodeCallback) nodeCallback(origNode);
origNode.setLoaded(false);
if(!transport.responseText){
throw new Error('Empty response!');
}
Logger.debug(transport.responseText);
if(nodeCallback) nodeCallback(origNode);
origNode.setLoaded(false);
throw new Error('Invalid XML Document (see console)');
}
var rootNode = transport.responseXML.documentElement;
Expand Down

0 comments on commit e6d1da1

Please sign in to comment.