{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":7469158,"defaultBranch":"master","name":"richdem","ownerLogin":"r-barnes","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2013-01-06T15:33:34.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/3118036?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1688684377.0","currentOid":""},"activityList":{"items":[{"before":"3b067d68ada7e997913e8ec89a3c141d0dd992cf","after":"20448510c685ce9df629303734064a638317a038","ref":"refs/heads/richard/simpler_hash","pushedAt":"2023-07-07T18:13:27.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"Remove OutletLink class and simplify hash function","shortMessageHtmlLink":"Remove OutletLink class and simplify hash function"}},{"before":"02985ca4cbfe0f223f531cb4652ff46481a81056","after":"3b067d68ada7e997913e8ec89a3c141d0dd992cf","ref":"refs/heads/richard/simpler_hash","pushedAt":"2023-07-07T18:09:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"Remove OutletLink class and simplify hash function","shortMessageHtmlLink":"Remove OutletLink class and simplify hash function"}},{"before":null,"after":"02985ca4cbfe0f223f531cb4652ff46481a81056","ref":"refs/heads/richard/simpler_hash","pushedAt":"2023-07-06T22:59:37.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"Simplify hash function","shortMessageHtmlLink":"Simplify hash function"}},{"before":"c5a183ada30fbd1b8587121e0d313b4cda9390c0","after":null,"ref":"refs/heads/richard/similar_elev","pushedAt":"2023-07-06T22:58:02.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"}},{"before":"5ac329e803718b02deeb61d5cf545d00aeb31104","after":"c5a183ada30fbd1b8587121e0d313b4cda9390c0","ref":"refs/heads/master","pushedAt":"2023-07-06T22:57:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"Adds CachingOutletChecker.\n\nIn tests on the Steele County 3m dataset this decreases wall-time for marginal volume calculations from ~14s to ~7s.","shortMessageHtmlLink":"Adds CachingOutletChecker."}},{"before":"a358bfb7e6727f63b869b817495ceed3165e73f1","after":"c5a183ada30fbd1b8587121e0d313b4cda9390c0","ref":"refs/heads/richard/similar_elev","pushedAt":"2023-07-06T22:57:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"Adds CachingOutletChecker.\n\nIn tests on the Steele County 3m dataset this decreases wall-time for marginal volume calculations from ~14s to ~7s.","shortMessageHtmlLink":"Adds CachingOutletChecker."}},{"before":"155193b2ff62e55eec555000fe42ebb36004bf3b","after":"a358bfb7e6727f63b869b817495ceed3165e73f1","ref":"refs/heads/richard/similar_elev","pushedAt":"2023-07-06T22:47:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"CachingOutletChecker","shortMessageHtmlLink":"CachingOutletChecker"}},{"before":"41d2944f3500d4740c339f0a8964c833340586dd","after":"155193b2ff62e55eec555000fe42ebb36004bf3b","ref":"refs/heads/richard/similar_elev","pushedAt":"2023-07-05T18:47:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"CachingOutletChecker","shortMessageHtmlLink":"CachingOutletChecker"}},{"before":null,"after":"41d2944f3500d4740c339f0a8964c833340586dd","ref":"refs/heads/richard/similar_elev","pushedAt":"2023-07-05T18:31:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"CachingOutletChecker","shortMessageHtmlLink":"CachingOutletChecker"}},{"before":"7c309e83885478ecfb59fa9f098e0316e9e1386e","after":null,"ref":"refs/heads/richard/stop_mv_search_earlier","pushedAt":"2023-07-05T18:29:57.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"}},{"before":"e821e7a88f47cbc1529a35c96cf606df40ef95bc","after":"5ac329e803718b02deeb61d5cf545d00aeb31104","ref":"refs/heads/master","pushedAt":"2023-07-05T18:29:46.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"BUGFIX: Stop MV search at ocean link\n\nWhen calculating marginal volumes for depressions we sum the total elevation of the cells contained within the depression.\n\nIf a cell's elevation is higher than the outlet for the depression it's in, we go to the parent depression and make the same check there. This continues until we reach the ocean. But that means that a cell's elevation can contribute to a depression we reach through an ocean link! That is, if a cell's elevation exceeds that of any outlet of a depression it's part of, then we continue looking for a place to add its elevation in downhill depressions. But this cell cannot contribute marginal volume to any such depression because no such depression contains it.\n\nThis bug likely doesn't manifest much (if ever?) because the outlets of downhill depressions are almost certainly lower than the elevation of the cell - after all, we're looking in downhill depressions because the cell's elevation was higher than that of its outlet depression and the downhill depression is downhill because its outlet is lower.\n\nMaybe the only way this would ever be an issue would be if outlets were somehow equal? But in that case I think (it's been a while since I've run this through in my head) that they would be part of the same meta-depression.\n\nSo maybe this never actually manifests as an issue, but it does mean that we can stop looking for places to add marginal volume early! That'll be a perf improvement.\n\nAn example of this issue is here:\n\n21(36.000000) -> 30(36.000000)  -> 31(37.000000) -> 34(41.000000)  ->\n                 38(43.000000) o-> 16(41.000000) -> 36(42.000000) o->\n                 10(35.000000) o-> 0(inf)\n\nA cell with an elevation of 78 doesn't contribute marginal volume to depression 21 because 21's outlet elevation is 36.\n\nSo we look at 36's parent, Dep 30, but the outlet elevation there is also 36. We continue until we reach Dep 38, with an outlet elevation of 43. Now we follow an oceanlink to Dep 16, whose outlet elevation is still too low. We expect this because Dep 16 is downhill of Dep 38. At this point we can continue following the hierarchy to the ocean, but that's unnecessary both because it would be incorrect to add the cell's marginal volume to any depression past 38 but also because all of the downhill outlets will be too low.","shortMessageHtmlLink":"BUGFIX: Stop MV search at ocean link"}},{"before":"5520625d9a20a17cd38de04ec5493f29dcc9b808","after":"e821e7a88f47cbc1529a35c96cf606df40ef95bc","ref":"refs/heads/master","pushedAt":"2023-07-05T17:29:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"Remove extraneous newlines","shortMessageHtmlLink":"Remove extraneous newlines"}},{"before":"931cee964b86f4ab9faae233fccc5677f8317eb1","after":"7c309e83885478ecfb59fa9f098e0316e9e1386e","ref":"refs/heads/richard/stop_mv_search_earlier","pushedAt":"2023-07-05T17:18:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"BUGFIX: Stop MV search at ocean link\n\nWhen calculating marginal volumes for depressions we sum the total elevation of the cells contained within the depression.\n\nIf a cell's elevation is higher than the outlet for the depression it's in, we go to the parent depression and make the same check there. This continues until we reach the ocean. But that means that a cell's elevation can contribute to a depression we reach through an ocean link! That is, if a cell's elevation exceeds that of any outlet of a depression it's part of, then we continue looking for a place to add its elevation in downhill depressions. But this cell cannot contribute marginal volume to any such depression because no such depression contains it.\n\nThis bug likely doesn't manifest much (if ever?) because the outlets of downhill depressions are almost certainly lower than the elevation of the cell - after all, we're looking in downhill depressions because the cell's elevation was higher than that of its outlet depression and the downhill depression is downhill because its outlet is lower.\n\nMaybe the only way this would ever be an issue would be if outlets were somehow equal? But in that case I think (it's been a while since I've run this through in my head) that they would be part of the same meta-depression.\n\nSo maybe this never actually manifests as an issue, but it does mean that we can stop looking for places to add marginal volume early! That'll be a perf improvement.\n\nAn example of this issue is here:\n\n21(36.000000) -> 30(36.000000)  -> 31(37.000000) -> 34(41.000000)  ->\n                 38(43.000000) o-> 16(41.000000) -> 36(42.000000) o->\n                 10(35.000000) o-> 0(inf)\n\nA cell with an elevation of 78 doesn't contribute marginal volume to depression 21 because 21's outlet elevation is 36.\n\nSo we look at 36's parent, Dep 30, but the outlet elevation there is also 36. We continue until we reach Dep 38, with an outlet elevation of 43. Now we follow an oceanlink to Dep 16, whose outlet elevation is still too low. We expect this because Dep 16 is downhill of Dep 38. At this point we can continue following the hierarchy to the ocean, but that's unnecessary both because it would be incorrect to add the cell's marginal volume to any depression past 38 but also because all of the downhill outlets will be too low.","shortMessageHtmlLink":"BUGFIX: Stop MV search at ocean link"}},{"before":"5490608d5f9077eb1467a53858502de8218e698f","after":"5520625d9a20a17cd38de04ec5493f29dcc9b808","ref":"refs/heads/master","pushedAt":"2023-07-05T17:17:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"Add more fine-grained timing info to DH","shortMessageHtmlLink":"Add more fine-grained timing info to DH"}},{"before":"1ce8db2631784fb6ec9bad1296154262a9d02fde","after":"931cee964b86f4ab9faae233fccc5677f8317eb1","ref":"refs/heads/richard/stop_mv_search_earlier","pushedAt":"2023-07-05T17:11:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"BUGFIX: Stop MV search at ocean link\n\nWhen calculating marginal volumes for depressions we sum the total elevation of the cells contained within the depression.\n\nIf a cell's elevation is higher than the outlet for the depression it's in, we go to the parent depression and make the same check there. This continues until we reach the ocean. But that means that a cell's elevation can contribute to a depression we reach through an ocean link! That is, if a cell's elevation exceeds that of any outlet of a depression it's part of, then we continue looking for a place to add its elevation in downhill depressions. But this cell cannot contribute marginal volume to any such depression because no such depression contains it.\n\nThis bug likely doesn't manifest much (if ever?) because the outlets of downhill depressions are almost certainly lower than the elevation of the cell - after all, we're looking in downhill depressions because the cell's elevation was higher than that of its outlet depression and the downhill depression is downhill because its outlet is lower.\n\nMaybe the only way this would ever be an issue would be if outlets were somehow equal? But in that case I think (it's been a while since I've run this through in my head) that they would be part of the same meta-depression.\n\nSo maybe this never actually manifests as an issue, but it does mean that we can stop looking for places to add marginal volume early! That'll be a perf improvement.\n\nAn example of this issue is here:\n\n21(36.000000) -> 30(36.000000)  -> 31(37.000000) -> 34(41.000000)  ->\n                 38(43.000000) o-> 16(41.000000) -> 36(42.000000) o->\n                 10(35.000000) o-> 0(inf)\n\nA cell with an elevation of 78 doesn't contribute marginal volume to depression 21 because 21's outlet elevation is 36.\n\nSo we look at 36's parent, Dep 30, but the outlet elevation there is also 36. We continue until we reach Dep 38, with an outlet elevation of 43. Now we follow an oceanlink to Dep 16, whose outlet elevation is still too low. We expect this because Dep 16 is downhill of Dep 38. At this point we can continue following the hierarchy to the ocean, but that's unnecessary both because it would be incorrect to add the cell's marginal volume to any depression past 38 but also because all of the downhill outlets will be too low.","shortMessageHtmlLink":"BUGFIX: Stop MV search at ocean link"}},{"before":"be357ec601f6613967e932ac775e8841b1c713de","after":"1ce8db2631784fb6ec9bad1296154262a9d02fde","ref":"refs/heads/richard/stop_mv_search_earlier","pushedAt":"2023-07-02T23:12:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"BUGFIX: Stop MV search at ocean link\n\nWhen calculating marginal volumes for depressions we sum the total elevation of the cells contained within the depression.\n\nIf a cell's elevation is higher than the outlet for the depression it's in, we go to the parent depression and make the same check there. This continues until we reach the ocean. But that means that a cell's elevation can contribute to a depression we reach through an ocean link! That is, if a cell's elevation exceeds that of any outlet of a depression it's part of, then we continue looking for a place to add its elevation in downhill depressions. But this cell cannot contribute marginal volume to any such depression because no such depression contains it.\n\nThis bug likely doesn't manifest much (if ever?) because the outlets of downhill depressions are almost certainly lower than the elevation of the cell - after all, we're looking in downhill depressions because the cell's elevation was higher than that of its outlet depression and the downhill depression is downhill because its outlet is lower.\n\nMaybe the only way this would ever be an issue would be if outlets were somehow equal? But in that case I think (it's been a while since I've run this through in my head) that they would be part of the same meta-depression.\n\nSo maybe this never actually manifests as an issue, but it does mean that we can stop looking for places to add marginal volume early! That'll be a perf improvement.\n\nAn example of this issue is here:\n\n21(36.000000) -> 30(36.000000)  -> 31(37.000000) -> 34(41.000000)  ->\n                 38(43.000000) o-> 16(41.000000) -> 36(42.000000) o->\n                 10(35.000000) o-> 0(inf)\n\nA cell with an elevation of 78 doesn't contribute marginal volume to depression 21 because 21's outlet elevation is 36.\n\nSo we look at 36's parent, Dep 30, but the outlet elevation there is also 36. We continue until we reach Dep 38, with an outlet elevation of 43. Now we follow an oceanlink to Dep 16, whose outlet elevation is still too low. We expect this because Dep 16 is downhill of Dep 38. At this point we can continue following the hierarchy to the ocean, but that's unnecessary both because it would be incorrect to add the cell's marginal volume to any depression past 38 but also because all of the downhill outlets will be too low.","shortMessageHtmlLink":"BUGFIX: Stop MV search at ocean link"}},{"before":"c98ac9611c2e5cc3bf0c6d034ae0c0d53987a0a9","after":"5490608d5f9077eb1467a53858502de8218e698f","ref":"refs/heads/master","pushedAt":"2023-07-02T23:11:59.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"Check that DH is same size","shortMessageHtmlLink":"Check that DH is same size"}},{"before":null,"after":"be357ec601f6613967e932ac775e8841b1c713de","ref":"refs/heads/richard/stop_mv_search_earlier","pushedAt":"2023-07-02T23:10:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"BUGFIX: Stop MV search at ocean link\n\nWhen calculating marginal volumes for depressions we sum the total elevation of the cells contained within the depression.\n\nIf a cell's elevation is higher than the outlet for the depression it's in, we go to the parent depression and make the same check there. This continues until we reach the ocean. But that means that a cell's elevation can contribute to a depression we reach through an ocean link! That is, if a cell's elevation exceeds that of any outlet of a depression it's part of, then we continue looking for a place to add its elevation in downhill depressions. But this cell cannot contribute marginal volume to any such depression because no such depression contains it.\n\nThis bug likely doesn't manifest much (if ever?) because the outlets of downhill depressions are almost certainly lower than the elevation of the cell - after all, we're looking in downhill depressions because the cell's elevation was higher than that of its outlet depression and the downhill depression is downhill because its outlet is lower.\n\nMaybe the only way this would ever be an issue would be if outlets were somehow equal? But in that case I think (it's been a while since I've run this through in my head) that they would be part of the same meta-depression.\n\nSo maybe this never actually manifests as an issue, but it does mean that we can stop looking for places to add marginal volume early! That'll be a perf improvement.\n\nAn example of this issue is here:\n\n21(36.000000) -> 30(36.000000)  -> 31(37.000000) -> 34(41.000000)  ->\n                 38(43.000000) o-> 16(41.000000) -> 36(42.000000) o->\n                 10(35.000000) o-> 0(inf)\n\nA cell with an elevation of 78 doesn't contribute marginal volume to depression 21 because 21's outlet elevation is 36.\n\nSo we look at 36's parent, Dep 30, but the outlet elevation there is also 36. We continue until we reach Dep 38, with an outlet elevation of 43. Now we follow an oceanlink to Dep 16, whose outlet elevation is still too low. We expect this because Dep 16 is downhill of Dep 38. At this point we can continue following the hierarchy to the ocean, but that's unnecessary both because it would be incorrect to add the cell's marginal volume to any depression past 38 but also because all of the downhill outlets will be too low.","shortMessageHtmlLink":"BUGFIX: Stop MV search at ocean link"}},{"before":"be3793dba82759804de674499e6f86469b04f844","after":"baac6df4123f35dd6d94ce1040195f0ae0798856","ref":"refs/heads/richard/abseil_for_fsm","pushedAt":"2023-07-02T21:53:05.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"Add abseil to FSM","shortMessageHtmlLink":"Add abseil to FSM"}},{"before":"e2aa4e16a84249657cf81dc16f28f03652672d73","after":"be3793dba82759804de674499e6f86469b04f844","ref":"refs/heads/richard/abseil_for_fsm","pushedAt":"2023-06-29T16:30:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"Add abseil to FSM","shortMessageHtmlLink":"Add abseil to FSM"}},{"before":"91ded4af9becc584207841e8a2e71c51745b1a57","after":"c98ac9611c2e5cc3bf0c6d034ae0c0d53987a0a9","ref":"refs/heads/master","pushedAt":"2023-06-29T16:29:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"Rename outlet hashing class for clarity; fix spelling mistake","shortMessageHtmlLink":"Rename outlet hashing class for clarity; fix spelling mistake"}},{"before":"d4123b31799e5b0351cee8521ff99a9da9eaefbc","after":"91ded4af9becc584207841e8a2e71c51745b1a57","ref":"refs/heads/master","pushedAt":"2023-06-28T15:21:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"Fix logging","shortMessageHtmlLink":"Fix logging"}},{"before":"7b42e2700756bef1e2a7a2df73e3e429212f4435","after":"d4123b31799e5b0351cee8521ff99a9da9eaefbc","ref":"refs/heads/master","pushedAt":"2023-06-28T15:15:26.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"Merge branch 'master' of github.com:r-barnes/richdem","shortMessageHtmlLink":"Merge branch 'master' of github.com:r-barnes/richdem"}},{"before":null,"after":"e2aa4e16a84249657cf81dc16f28f03652672d73","ref":"refs/heads/richard/abseil_for_fsm","pushedAt":"2023-06-27T20:36:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"r-barnes","name":"Richard Barnes","path":"/r-barnes","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3118036?s=80&v=4"},"commit":{"message":"Add abseil to FSM","shortMessageHtmlLink":"Add abseil to FSM"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADUQ0f7gA","startCursor":null,"endCursor":null}},"title":"Activity · r-barnes/richdem"}