@@ -253,8 +253,8 @@ module PageAttachmentTags options = { :order => "#{by} #{order}", - :limit => attr[:limit] || nil, :offset => attr[:offset] || nil, + :limit => attr[:limit] || (attr[:offset] ? 9999 : nil), :conditions => conditions } end app/models/page_attachment_tags.rb @@ -118,6 +118,10 @@ class PageAttachmentsExtensionTest < Test::Unit::TestCase %{<r:attachment:each limit="1" offset="1" by="filename"><r:link/></r:attachment:each>}, '/' assert_renders %{<a href="#{txt.public_filename}">foo.txt</a>}, %{<r:attachment:each limit="1" offset="0" by="filename"><r:link/></r:attachment:each>}, '/' + assert_renders %{<a href="#{txt.public_filename}">foo.txt</a>}, + %{<r:attachment:each limit="1" by="filename"><r:link/></r:attachment:each>}, '/' + assert_renders %{<a href="#{img.public_filename}">rails.png</a>}, + %{<r:attachment:each offset="1" by="filename"><r:link/></r:attachment:each>}, '/' end def test_attachment_inheritance test/functional/page_attachments_extension_test.rb 33579b03d32a6960e4e4608b6b00d433d309a1ca Jason Garber jg@jasongarber.com http://github.com/radiant/radiant-page-attachments-extension/commit/4eb43b8ebbcea80803faec2145ce50dcff9b0bff 4eb43b8ebbcea80803faec2145ce50dcff9b0bff 2009-06-11T11:20:55-07:00 2009-06-11T11:20:55-07:00 Define appropriate behavior in iterator when limit or offset is specified, but not both. Makes the offset attribute more intuitive. I ran into this bug when trying to use offset but with no limit. Took me a long time to figure out I had to specify a limit to get offset to work, but I didn't want a limit. c7a7c2fe695266843cb235ce788cf4c11798d799 Jason Garber jg@jasongarber.com