Issues - radiant/radiant

radiant / radiant

158

784

Description:

Radiant is a no-fluff, open source content management system designed for small teams.

Sort by: Priority | Votes | Last Updated

Loading…

63.

0 votes

change non-conforming `onsubmit_status` attributes to `data-onsubmit_status`
1 comment Created 23 days ago by johnmuhl

Title

Body
is there any reason not to use the `data-*` attributes again here? http://github.com/johnmuhl/radiant/commit/9883615a289f41b2ab4a5d39e0647626c8a349cd has it done.
or cancel

is there any reason not to use the data-* attributes again here?

http://github.com/johnmuhl/radiant/commit/9883615a289f41b2ab4a5d39e0647626c8a349cd has it done.

Comments

johnmuhl Tue Oct 20 09:09:36 -0700 2009 | link

oops, i guess i accidentally pushed this to radiant/radiant. just revert it or tell me to if you want it reverted

Comment
oops, i guess i accidentally pushed this to radiant/radiant. just revert it or tell me to if you want it reverted
or cancel

Parsed with GitHub Flavored Markdown
62.

0 votes

jgarber
x

Tag introspection and eager loading
2 comments Created 24 days ago by jgarber

Title

Body
Tags that load other pages should look at their AST and see what will be needed inside so it can use eager loading and save db calls
or cancel
Tags that load other pages should look at their AST and see what will be needed inside so it can use eager loading and save db calls

Comments
jgarber Thu Oct 22 12:26:02 -0700 2009 | link
I did some benchmarking on this to determine if it's even worth doing. I think I could make it fairly elegant and out-of-the-way, but is there lower-hanging fruit? The research:

Given a parent with 50 children, each of which has two page parts...

A regular page.children.each {|c| c.part('body') } (repeated ten times after a rehearsal cycle) takes 0.68 seconds total.

Eager loading, including just the body parts with the children takes 0.34 total.

Eager loading all parts associated with children is 0.54.

Of course, with eager loading you also have to find the part in child.parts array. Otherwise, child.part('body') does a separate SQL query and then eager loading is worse (0.91).

Eager loading with only the needed parts of children (#2 above) is better than non-eager-loading (#1) when number of children is > 3. Without conditions specifying which parts to eager load (#3), there must be > 5 children.

So, if I could have children tags look inside and determine which associated page_parts, attachments, or other children to eager load, I'd save 340 ms--no small amount when optimizing the load time of a page! Just identifying that parts need to be eager loaded saves only 140 ms and the threshold for number of children is higher, so it will save the average page load a lot less than I'd hoped.

The code for a children:each tag to look for other children:each tags or content tags within itself wouldn't be so hard, but building the nested conditions to achieve the efficiencies of #2 would be quite difficult. The code looks like this:

@page.children.find(:all, :include => :parts, :conditions => {:page_parts => {:name => 'body'}})

The benchmark I used can be found at http://gist.github.com/216206
Comment
I did some benchmarking on this to determine if it's even worth doing. I think I could make it fairly elegant and out-of-the-way, but is there lower-hanging fruit? The research: Given a parent with 50 children, each of which has two page parts... 1. A regular page.children.each {|c| c.part('body') } (repeated ten times after a rehearsal cycle) takes 0.68 seconds total. 2. Eager loading, including just the body parts with the children takes 0.34 total. 3. Eager loading all parts associated with children is 0.54. 4. Of course, with eager loading you also have to find the part in child.parts array. Otherwise, child.part('body') does a separate SQL query and then eager loading is worse (0.91). Eager loading with only the needed parts of children (#2 above) is better than non-eager-loading (#1) when number of children is > 3. Without conditions specifying which parts to eager load (#3), there must be > 5 children. So, if I could have children tags look inside and determine which associated page_parts, attachments, or other children to eager load, I'd save 340 ms--no small amount when optimizing the load time of a page! Just identifying that parts need to be eager loaded saves only 140 ms and the threshold for number of children is higher, so it will save the average page load a lot less than I'd hoped. The code for a children:each tag to look for other children:each tags or content tags within itself wouldn't be so hard, but building the nested conditions to achieve the efficiencies of #2 would be quite difficult. The code looks like this: @page.children.find(:all, :include => :parts, :conditions => {:page_parts => {:name => 'body'}}) The benchmark I used can be found at http://gist.github.com/216206
or cancel
jgarber Wed Oct 28 12:09:42 -0700 2009 | link

I closed this issue because it would be so difficult to do. Wish it weren't, though, because the speed of some of my complex pages is really annoying!

Comment
I closed this issue because it would be so difficult to do. Wish it weren't, though, because the speed of some of my complex pages is really annoying!
or cancel

Parsed with GitHub Flavored Markdown
61.

0 votes

jgarber
x

Speed up Radius parser
1 comment Created 24 days ago by jgarber

Title

Body
Just a reminder for me to look at it and see if it can be improved.
or cancel

Just a reminder for me to look at it and see if it can be improved.

Comments

jgarber Mon Oct 19 12:38:32 -0700 2009 | link

I re-implemented Radius parsing in Treetop and it was 27% slower. Based on my experience with RedCloth, I thought Ragel's generated parsers were slow and inefficient, but I guess not!

Last time I checked, though, Ragel parsers in Ruby weren't 1.9 compatible.

Comment
I re-implemented Radius parsing in Treetop and it was 27% slower. Based on my experience with RedCloth, I thought Ragel's generated parsers were slow and inefficient, but I guess not! Last time I checked, though, Ragel parsers in Ruby weren't 1.9 compatible.
or cancel

Parsed with GitHub Flavored Markdown
60.

0 votes

Add distributions to extension registry
1 comment Created 26 days ago by jgarber

Title

Body
I just stumbled across http://github.com/netzpirat/radiant-multisite/. It's an instance with extensions that all work together. These distros should be registered somewhere.
or cancel

I just stumbled across http://github.com/netzpirat/radiant-multisite/. It's an instance with extensions that all work together. These distros should be registered somewhere.

Comments

jlong Sun Nov 01 18:28:29 -0800 2009 | link

Possibly. I think that once we have radiant broken into a couple of gems, with a standard mechanism for creating a distro gem and installing using it, that might be the time to introduce something official like this to the registry. I'm closing this for now.

Comment
Possibly. I think that once we have radiant broken into a couple of gems, with a standard mechanism for creating a distro gem and installing using it, that might be the time to introduce something official like this to the registry. I'm closing this for now.
or cancel

Parsed with GitHub Flavored Markdown
58.

0 votes

admin.layout.index.add :top, 'sitemap'
2 comments Created 27 days ago by cristi

Title

Body
Radiant 0.8.1 had a "help_text" region - render_region :top do |top| - top.help_text do This doesn't exist in 0.9. But in admin_ui.rb there still is a refference. So, you need to either add back the "help_text" or remove the reference from admin_ui.rb. I took the liberty of choosing a solution (and removed the reference). Here's the commit: http://github.com/cristi/radiant/commit/d2c4367d45e8d0e8d0c3532cefb3a027d6770329
or cancel
Radiant 0.8.1 had a "help_text" region
- render_region :top do |top|
  - top.help_text do
This doesn't exist in 0.9. But in admin_ui.rb there still is a refference.

So, you need to either add back the "help_text" or remove the reference from admin_ui.rb.

I took the liberty of choosing a solution (and removed the reference). Here's the commit:

http://github.com/cristi/radiant/commit/d2c4367d45e8d0e8d0c3532cefb3a027d6770329
Comments

cristi Thu Oct 15 06:42:02 -0700 2009 | link

commit picked up. Closed

Comment
commit picked up. Closed
or cancel

jlong Thu Oct 15 21:07:41 -0700 2009 | link

Actually closed then.

Comment
Actually closed then.
or cancel

Parsed with GitHub Flavored Markdown
52.

1 vote

0.9.0 maybe
x

page part tabs are broken in ie8
3 comments Created about 1 month ago by johnmuhl

Title

Body
default ie8 install on windows xp. http://skitch.com/johnmuhl/nn23q/windows-xp switching to compatibility mode fixes the issue (as does switching to the real ie7)
or cancel

default ie8 install on windows xp. http://skitch.com/johnmuhl/nn23q/windows-xp
switching to compatibility mode fixes the issue (as does switching to the real ie7)

Comments

jlong Tue Oct 13 20:24:40 -0700 2009 | link

Do you have time to troubleshoot this John?

Comment
Do you have time to troubleshoot this John?
or cancel

johnmuhl Wed Oct 14 08:37:27 -0700 2009 | link

sure. can anyone confirm the broken tabs on their ie8?

Comment
sure. can anyone confirm the broken tabs on their ie8?
or cancel

johnmuhl Mon Oct 19 11:42:54 -0700 2009 | link

fix page part tabs in IE8. closed by f63997b

Comment
fix page part tabs in IE8. closed by f63997b87f8f451b7b917b7a3bbaac14cb66618e
or cancel

Parsed with GitHub Flavored Markdown
45.

0 votes

Breadcrumb links broken when used inside <r:navigation>
4 comments Created about 1 month ago by andrewreid

Title

Body
Consider the case where you may only want breadcrumbs displayed on your child pages, not the home page. You might use a <r:navigation> block like this: <r:navigation urls="Home: /"> <r:normal><div id="header"><p>My website: <r:breadcrumbs /></p></div></r:normal> <r:here></r:here> <r:selected><div id="header"><p>My website: <r:breadcrumbs /></p></div></r:selected> </r:navigation> So, when you visit, say www.myradiantsite.com/products/apples, you'd expect to see breadcrumbs generated that look like: Home > Products > Apples ... Which is what happens, but the links generated on 'Home' and 'Products' both point to '/'. That is, Products should link to '/products' but links to '/'. This appears to only occur when the breadcrumbs are inside the <r:navigation> block.
or cancel

Consider the case where you may only want breadcrumbs displayed on your child pages, not the home page. You might use a <r:navigation> block like this:

<r:navigation urls="Home: /">
<r:normal>
My website: <r:breadcrumbs />
</r:normal> <r:here></r:here> <r:selected>
My website: <r:breadcrumbs />
</r:selected> </r:navigation>

So, when you visit, say www.myradiantsite.com/products/apples, you'd expect to see breadcrumbs generated that look like:

Home > Products > Apples

... Which is what happens, but the links generated on 'Home' and 'Products' both point to '/'. That is, Products should link to '/products' but links to '/'. This appears to only occur when the breadcrumbs are inside the <r:navigation> block.

Comments

seancribbs Mon Oct 05 04:45:45 -0700 2009 | link

<r:navigation> defines its own <r:link /> tag which is different from the default. This is by design. If you need to use breadcrumbs within this scenario, consider using something other than <r:navigation>.

Comment
<r:navigation> defines its own <r:link /> tag which is different from the default. This is by design. If you need to use breadcrumbs within this scenario, consider using something other than <r:navigation>.
or cancel

jlong Tue Oct 06 20:33:26 -0700 2009 | link

Or... can you explain why you would want to use the breadcrumbs tag inside of the navigation tag?

Comment
Or... can you explain why you would want to use the breadcrumbs tag inside of the navigation tag?
or cancel

andrewreid Tue Oct 06 20:36:57 -0700 2009 | link

I wanted conditional breadcrumbs - essentially, if the page was one of my "heading" pages, do not display breadcrumbs, if it was a child "content" page, display them.

I've managed to work around the problem by displaying breadcrumbs for every page except the home page using <r:if_parent>, so my issue is moot. I suppose it's a case of me using navigation for something other than its intended purpose, so whether or not this should be considered a "bug" is a matter of interpretation! :-)

Comment
I wanted conditional breadcrumbs - essentially, if the page was one of my "heading" pages, do not display breadcrumbs, if it was a child "content" page, display them. I've managed to work around the problem by displaying breadcrumbs for every page except the home page using <r:if_parent>, so my issue is moot. I suppose it's a case of me using navigation for something other than its intended purpose, so whether or not this should be considered a "bug" is a matter of interpretation! :-)
or cancel

jlong Tue Oct 06 20:44:21 -0700 2009 | link

Yah, we never intended for it to be used that way. Interesting use case though. I am going to close this ticket for now.

Comment
Yah, we never intended for it to be used that way. Interesting use case though. I am going to close this ticket for now.
or cancel

Parsed with GitHub Flavored Markdown
41.

1 vote

CouchDB Support
2 comments Created about 1 month ago by shenoudab

Title

Body
Dears, is supporting CouchDB in Radinat CMS Plan is included and in which road map Thanks,
or cancel

Dears,

is supporting CouchDB in Radinat CMS Plan is included and in which road map

Thanks,

Comments

seancribbs Fri Oct 02 06:09:31 -0700 2009 | link

This is non-trivial and will need to wait until there is better support in Rails for switching out the database layer.

Comment
This is non-trivial and will need to wait until there is better support in Rails for switching out the database layer.
or cancel

jlong Tue Oct 06 20:47:45 -0700 2009 | link

I'm going to close this one for now. Feel free to reopen it if this ever becomes a serious option.

Comment
I'm going to close this one for now. Feel free to reopen it if this ever becomes a serious option.
or cancel

Parsed with GitHub Flavored Markdown
18.

0 votes

Hidden pages are visible in dev mode
2 comments Created about 1 month ago by seancribbs

Title

Body
If you request a hidden page in live mode, you get FileNotFound, but if you request it in dev mode, you get the page, just like a draft. Seems like 'hidden' should mean never visible in any mode. (formerly lighthouse #65)
or cancel

If you request a hidden page in live mode, you get FileNotFound, but if you request it in dev mode, you get the page, just like a draft. Seems like 'hidden' should mean never visible in any mode.

(formerly lighthouse #65)

Comments

jlong Wed Sep 30 12:48:23 -0700 2009 | link

Well, I agree that "hidden" pages should not show up in queries made by tags (like <r:children>) in dev mode, but also believe that they should still be accessible via URL.

Comment
Well, I agree that "hidden" pages should not show up in queries made by tags (like <r:children>) in dev mode, but also believe that they should still be accessible via URL.
or cancel

jlong Wed Sep 30 12:50:45 -0700 2009 | link

Closed in favor of #34

Comment
Closed in favor of #34
or cancel

Parsed with GitHub Flavored Markdown
17.

0 votes

seancribbs
x

The radiant:import:prototype:* rake tasks should be hidden in instance mode
1 comment Created about 1 month ago by jlong

Title

Body

or cancel

Comments

seancribbs Sun Sep 27 11:56:56 -0700 2009 | link

Undefine prototype rake tasks in instance mode. Closed by b3a4b69

Comment
Undefine prototype rake tasks in instance mode. Closed by b3a4b690e5605018eed28a2845ca51ae08282f82
or cancel

Parsed with GitHub Flavored Markdown
16.

0 votes

seancribbs
x

Page parts that have been saved and then deleted reappear after saving
1 comment Created about 1 month ago by jlong

Title

Body
To reproduce: 1. Add a page part to a page. 2. Save the page. 3. Delete the page part. 4. Save the page again.
or cancel
To reproduce:
1. Add a page part to a page.
2. Save the page.
3. Delete the page part.
4. Save the page again.
Comments

seancribbs Sun Sep 27 11:31:29 -0700 2009 | link

Fix page-part deletion in JS. Closed by 209c327

Comment
Fix page-part deletion in JS. Closed by 209c3271d2d2411adf7a5bb2980f8c66b283fcf2
or cancel

Parsed with GitHub Flavored Markdown
14.

0 votes

0.9.0
x

"X has been deleted" flash messages
1 comment Created about 1 month ago by jlong

Title

Body
These messages are annoying and should be removed.
or cancel

These messages are annoying and should be removed.

Comments

radiant Wed Sep 30 23:01:36 -0700 2009 | link

Also added "Removing X..." messages when deleting pages, snippets, layouts, and users

Comment
Also added "Removing X..." messages when deleting pages, snippets, layouts, and users
or cancel

Parsed with GitHub Flavored Markdown
13.

0 votes

0.9.0
x

Can't delete a block of text in textarea
1 comment Created about 1 month ago by jlong

Title

Body
The new code for indentation is interfering with deleting a block of text. To reproduce select a block of text and press the delete key.
or cancel

The new code for indentation is interfering with deleting a block of text. To reproduce select a block of text and press the delete key.

Comments

jlong Fri Oct 09 17:27:32 -0700 2009 | link

Fixed.

Comment
Fixed.
or cancel

Parsed with GitHub Flavored Markdown
12.

0 votes

seancribbs
x

application (500) errors without tmp/cache/entity and/or tmp/cache/meta
1 comment Created 2 months ago by johnmuhl

Title

Body
often when i'm having trouble with differences between the browser's cache and radiant's cache i just `rm -r tmp/cache`, clear the browser cache and reload. up until 0.8.1 this worked fine; radiant would just recreate the necessary folders as needed. now i get an application error until i manually recreate the cache directories; e.g. `mkdir -p tmp/cache/entity tmp/cache/meta`
or cancel

often when i'm having trouble with differences between the browser's cache and radiant's cache i just rm -r tmp/cache, clear the browser cache and reload. up until 0.8.1 this worked fine; radiant would just recreate the necessary folders as needed. now i get an application error until i manually recreate the cache directories; e.g. mkdir -p tmp/cache/entity tmp/cache/meta

Comments

seancribbs Sun Sep 27 11:46:54 -0700 2009 | link

Verify that the cache directory exists before trying to store a response. Closed by 3682d66

Comment
Verify that the cache directory exists before trying to store a response. Closed by 3682d66ff42f395331c31d2dc8c73b3a9f2383a1
or cancel

Parsed with GitHub Flavored Markdown
11.

0 votes

Bug in mailer extension: wrong number of arguments
3 comments Created 3 months ago by nicolasconnault

Title

Body
I'm not sure where to submit this, there doesn't seem to be an issue tracker page for this extension. Here is the form I created: <r:mailer:form> <fieldset> <legend>Enter your contact information and message.</legend> <table> <tr><td> <r:if_error on='name'><p class="error">Name is required</p></r:if_error> <label for="name">Name</label></td><td><r:text id="name" name='name' required='true'/> </td></tr> <tr><td> <r:if_error on='email'><p class="error">Email is required</p></r:if_error> <label for="email">Email</label></td><td><r:text id="email" name='email' required='true'/> </td></tr> <tr><td> <r:if_error on='message'><p class="error">Message is required</p></r:if_error> <label for="email">Message</label></td><td><r:textarea name='message' required='true'/> </td></tr> <tr><td colspan="2"><input type="submit" value="Send" /></td></tr> </table> </fieldset> </r:mailer:form> Now the "mailer" part: subject: "Sent from your mailer form" redirect_to: /contact/thanks from_field: email recipients: - email@gmail.com And the "email" part: from: <r:mailer:get name='name'/>, <r:mailer:get name='email'/> message: <r:mailer:get name='message'/> Finally, the stack trace that is printed when I submit an empty form: /!\ FAILSAFE /!\ Sat Aug 01 10:07:29 +0800 2009 Status: 500 Internal Server Error wrong number of arguments (1 for 2) /usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rack-cache/lib/rack/cache/metastore.rb:94:in `restore_response' /usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rack-cache/lib/rack/cache/metastore.rb:94:in `invalidate' /usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rack-cache/lib/rack/cache/metastore.rb:93:in `map' /usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rack-cache/lib/rack/cache/metastore.rb:93:in `invalidate' /usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rack-cache/lib/rack/cache/context.rb:137:in `invalidate' /usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rack-cache/lib/rack/cache/context.rb:69:in `call!' /usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rack-cache/lib/rack/cache/context.rb:50:in `call' /usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/head.rb:9:in `call' /usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/methodoverride.rb:24:in `call' /usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/actionpack/lib/action_controller/params_parser.rb:15:in `call' /usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/actionpack/lib/action_controller/rewindable_input.rb:25:in `call' /usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/actionpack/lib/action_controller/session/cookie_store.rb:93:in `call' /usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/actionpack/lib/action_controller/reloader.rb:9:in `call' /usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/actionpack/lib/action_controller/failsafe.rb:11:in `call' /usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/lock.rb:11:in `call' /usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/lock.rb:11:in `synchronize' /usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/lock.rb:11:in `call' /usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/actionpack/lib/action_controller/dispatcher.rb:106:in `call' /usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/railties/lib/rails/rack/static.rb:31:in `call' /usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/urlmap.rb:46:in `call' /usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/urlmap.rb:40:in `each' /usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/urlmap.rb:40:in `call' /usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/railties/lib/rails/rack/log_tailer.rb:17:in `call' /usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/content_length.rb:13:in `call' /usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/chunked.rb:15:in `call' /usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/handler/mongrel.rb:61:in `process' /usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:159:in `process_client' /usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:158:in `each' /usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:158:in `process_client' /usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `run' /usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `initialize' /usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `new' /usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `run' /usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `initialize' /usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `new' /usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `run' /usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/handler/mongrel.rb:34:in `run' /usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/railties/lib/commands/server.rb:111 /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require' /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require' script/server:3
or cancel
I'm not sure where to submit this, there doesn't seem to be an issue tracker page for this extension.

Here is the form I created:
<r:mailer:form>
```
<legend>Enter your contact information and message.</legend>
<table>
  <tr><td>
    <r:if_error on='name'><p class="error">Name is required</p></r:if_error>
    <label for="name">Name</label></td><td><r:text id="name" name='name' required='true'/>
  </td></tr>
  <tr><td>
    <r:if_error on='email'><p class="error">Email is required</p></r:if_error>
    <label for="email">Email</label></td><td><r:text id="email" name='email' required='true'/>
  </td></tr>
  <tr><td>
    <r:if_error on='message'><p class="error">Message is required</p></r:if_error>
    <label for="email">Message</label></td><td><r:textarea name='message' required='true'/>
  </td></tr>
  <tr><td colspan="2"><input type="submit" value="Send" /></td></tr>
</table>
```
</r:mailer:form>

Now the "mailer" part:

subject: "Sent from your mailer form"
redirect_to: /contact/thanks
from_field: email
recipients:
- email@gmail.com

And the "email" part:

from: <r:mailer:get name='name'/>, <r:mailer:get name='email'/>

message:
<r:mailer:get name='message'/>

Finally, the stack trace that is printed when I submit an empty form:

/!\ FAILSAFE /!\ Sat Aug 01 10:07:29 +0800 2009 Status: 500 Internal Server Error wrong number of arguments (1 for 2)
```
/usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rack-cache/lib/rack/cache/metastore.rb:94:in `restore_response'
/usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rack-cache/lib/rack/cache/metastore.rb:94:in `invalidate'
/usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rack-cache/lib/rack/cache/metastore.rb:93:in `map'
/usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rack-cache/lib/rack/cache/metastore.rb:93:in `invalidate'
/usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rack-cache/lib/rack/cache/context.rb:137:in `invalidate'
/usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rack-cache/lib/rack/cache/context.rb:69:in `call!'
/usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rack-cache/lib/rack/cache/context.rb:50:in `call'
/usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/head.rb:9:in `call'
/usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/methodoverride.rb:24:in `call'
/usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/actionpack/lib/action_controller/params_parser.rb:15:in `call'
/usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/actionpack/lib/action_controller/rewindable_input.rb:25:in `call'
/usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/actionpack/lib/action_controller/session/cookie_store.rb:93:in `call'
/usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/actionpack/lib/action_controller/reloader.rb:9:in `call'
/usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/actionpack/lib/action_controller/failsafe.rb:11:in `call'
/usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/lock.rb:11:in `call'
/usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/lock.rb:11:in `synchronize'
/usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/lock.rb:11:in `call'
/usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/actionpack/lib/action_controller/dispatcher.rb:106:in `call'
/usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/railties/lib/rails/rack/static.rb:31:in `call'
/usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/urlmap.rb:46:in `call'
/usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/urlmap.rb:40:in `each'
/usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/urlmap.rb:40:in `call'
/usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/railties/lib/rails/rack/log_tailer.rb:17:in `call'
/usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/content_length.rb:13:in `call'
/usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/chunked.rb:15:in `call'
/usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/handler/mongrel.rb:61:in `process'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:159:in `process_client'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:158:in `each'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:158:in `process_client'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `initialize'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `new'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `initialize'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `new'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `run'
/usr/lib/ruby/gems/1.8/gems/rack-1.0.0/lib/rack/handler/mongrel.rb:34:in `run'
/usr/lib/ruby/gems/1.8/gems/radiant-0.8.0/vendor/rails/railties/lib/commands/server.rb:111
/usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
/usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
script/server:3
```
Comments

saturnflyer Fri Jul 31 19:30:09 -0700 2009 | link

You may submit issues here: http://github.com/radiant/radiant-mailer-extension/issues

Comment
You may submit issues here: http://github.com/radiant/radiant-mailer-extension/issues
or cancel

nicolasconnault Fri Jul 31 20:30:33 -0700 2009 | link

Posted in the wrong place, sorry.

Comment
Posted in the wrong place, sorry.
or cancel

ehaselwanter Mon Nov 02 02:08:26 -0800 2009 | link

this one is already fixed by seancribbs, I guess (POST and cache as keywords ...)

Comment
this one is already fixed by seancribbs, I guess (POST and cache as keywords ...)
or cancel

Parsed with GitHub Flavored Markdown
10.

1 vote

expanding pages in admin breaks if deployed to suburi
3 comments Created 3 months ago by yeah

Title

Body
when radiant is deployed to a suburi (e.g. http://myhost.com/radiant/ ), the following line breaks the expanding of pages: http://github.com/radiant/radiant/blob/1880ef84b219893ea971f489791aa1160eb4217e/public/javascripts/admin/sitemap.js#L116 reason for that is the absolute link to '/admin/pages/...' there.
or cancel

when radiant is deployed to a suburi (e.g. http://myhost.com/radiant/ ), the following line breaks the expanding of pages:

http://github.com/radiant/radiant/blob/1880ef84b219893ea971f489791aa1160eb4217e/public/javascripts/admin/sitemap.js#L116

reason for that is the absolute link to '/admin/pages/...' there.

Comments

saturnflyer Sat Aug 01 06:10:22 -0700 2009 | link

I suggest you alter the script to suit your application path. Just make it '/radiant/admin/pages'

Comment
I suggest you alter the script to suit your application path. Just make it `'/radiant/admin/pages'`
or cancel

yeah Sat Aug 01 06:13:37 -0700 2009 | link

thats what i did. i just wanted to raise this here so that people would know. i think radiant should make a statement on whether suburi installations are supported or not. if they are, this is a bug that needs to be fixed. if they aren't thats cool, we could just set up a wiki page which describes this (and maybe other) issues that you have to deal with if you try it anyways...

Comment
thats what i did. i just wanted to raise this here so that people would know. i think radiant should make a statement on whether suburi installations are supported or not. if they are, this is a bug that needs to be fixed. if they aren't thats cool, we could just set up a wiki page which describes this (and maybe other) issues that you have to deal with if you try it anyways...
or cancel

saturnflyer Sat Aug 01 11:18:15 -0700 2009 | link

Considering that this is a static file, I don't think there's much we can do. If there are other issues related to this, please do submit them. Or feel free to create a wiki page.

Comment
Considering that this is a static file, I don't think there's much we can do. If there are other issues related to this, please do submit them. Or feel free to create a wiki page.
or cancel

Parsed with GitHub Flavored Markdown
9.

1 vote

saturnflyer
x

edge breaks the ability to deploy to a read-only server (e.g. heroku)
3 comments Created 3 months ago by johnmuhl

Title

Body
commit 4f2ba63484ce8ef7ef3b3f482317eea7d87879d5 specifically the ensure_cache_file method breaks the ability to deploy to heroku by forcing the creation of cache/entity on boot up. apparently this all happens before the environment is loaded so settings there that change the cache location are ignored and heroku complains about you trying to write to a read-only file system.
or cancel

commit 4f2ba63 specifically the ensure_cache_file method breaks the ability to deploy to heroku by forcing the creation of cache/entity on boot up. apparently this all happens before the environment is loaded so settings there that change the cache location are ignored and heroku complains about you trying to write to a read-only file system.

Comments

saturnflyer Thu Jul 30 08:29:13 -0700 2009 | link

This is on my radar. I'll check it out.

Comment
This is on my radar. I'll check it out.
or cancel

saturnflyer Fri Jul 31 20:45:52 -0700 2009 | link

Store config_cache file in tmp. Closed by 981c1d6

Comment
Store config_cache file in tmp. Closed by 981c1d689a64a32b6b76b4c9dd520c3089dca4de
or cancel

johnmuhl Sun Aug 02 08:45:13 -0700 2009 | link

it seems to break if you upgrade an existing site that doesn't already have a tmp directory, maybe the radiant:update task could make sure the folder exists

Comment
it seems to break if you upgrade an existing site that doesn't already have a tmp directory, maybe the radiant:update task could make sure the folder exists
or cancel

Parsed with GitHub Flavored Markdown
8.

0 votes

admin.js "valid_part_name()" function doesn't accurately check for duplicate page part names
1 comment Created 3 months ago by alexmek

Title

Body
Line 126 of public/javascripts/admin/admin.js should be: if (tabControl.tabs.get(pair.key).label == name) { instead of if (tabControl.tabs.get(pair.key).caption == name) { Or, alternatively, line 105 of public/javascripts/admin/tabcontrol.js should be this.caption = label || id; instead of this.label = label || id;
or cancel

Line 126 of public/javascripts/admin/admin.js should be:

if (tabControl.tabs.get(pair.key).label == name) {

instead of

if (tabControl.tabs.get(pair.key).caption == name) {

Or, alternatively, line 105 of public/javascripts/admin/tabcontrol.js should be

this.caption = label || id;

instead of

this.label = label || id;

Comments

saturnflyer Fri Jul 31 20:12:32 -0700 2009 | link

Properly check for existing page parts when creating a new part. Closed by 6f7676c

Comment
Properly check for existing page parts when creating a new part. Closed by 6f7676cd450013e78b5bf40cc7a7a9443769363c
or cancel

Parsed with GitHub Flavored Markdown
7.

1 vote

[patch] prevent users from busting the cache
1 comment Created 3 months ago by johnmuhl

Title

Body
any user to a radiant site can use refresh or shift+refresh (aka "force reload") to bust the cache for all assets on the page. adding `:allow_reload => false` and `:allow_revalidate => false` cause rack-cache to ignore such request, thus limiting the cache busting to radiant's internal validation. the bottom of <http://tomayko.com/src/rack-cache/configuration> has more information. <http://github.com/johnmuhl/radiant/commit/bb1741fcae68e3c0550dce221b744609b009c022> contains the patch
or cancel

any user to a radiant site can use refresh or shift+refresh (aka "force reload") to bust the cache for all assets on the page. adding :allow_reload => false and :allow_revalidate => false cause rack-cache to ignore such request, thus limiting the cache busting to radiant's internal validation. the bottom of http://tomayko.com/src/rack-cache/configuration has more information.

http://github.com/johnmuhl/radiant/commit/bb1741fcae68e3c0550dce221b744609b009c022 contains the patch

Comments

saturnflyer Fri Jul 31 20:58:59 -0700 2009 | link

Merged. Thanks!

Comment
Merged. Thanks!
or cancel

Parsed with GitHub Flavored Markdown
6.

2 votes

setting config.extensions -= [ :ext_name ] in environment.rb doesn't work
3 comments Created 4 months ago by johnmuhl

Title

Body
see: http://gist.github.com/139708 for the error message
or cancel

see: http://gist.github.com/139708 for the error message

Comments

saturnflyer Sat Aug 01 06:07:25 -0700 2009 | link

This works for me on edge.

Comment
This works for me on edge.
or cancel

johnmuhl Sat Aug 01 07:58:10 -0700 2009 | link

right-o must have been fixed since i reported it.

Comment
right-o must have been fixed since i reported it.
or cancel

saturnflyer Sat Aug 01 11:18:39 -0700 2009 | link

done!

Comment
done!
or cancel

Parsed with GitHub Flavored Markdown
5.

0 votes

seancribbs
x

cucumber.rake fails if an older version of cucumber is installed
1 comment Created 4 months ago by seancribbs

Title

Body
rake aborted! undefined method `fork=' for #<Cucumber::Rake::Task:0x187c4bc> /Library/Ruby/Gems/1.8/gems/radiant-0.8.0/Rakefile:10
or cancel

rake aborted!
undefined method `fork=' for #<Cucumber::Rake::Task:0x187c4bc>
/Library/Ruby/Gems/1.8/gems/radiant-0.8.0/Rakefile:10

Comments

saturnflyer Tue Jun 30 13:23:18 -0700 2009 | link

Require Cucumber version 0.3.9 or greater from cucumber.rake Closed by b718dd6

Comment
Require Cucumber version 0.3.9 or greater from cucumber.rake Closed by b718dd616fcb2440830cac4f0ea7abd4e10faebe
or cancel

Parsed with GitHub Flavored Markdown
3.

3 votes

it "should return the view paths in inverse order to the loaded" fails
1 comment Created 5 months ago by ebrett

Title

Body
1) 'Radiant::ExtensionLoader should return the view paths in inverse order to the loaded' FAILED expected: ["/Users/developer/Activeshift/liam/test/fixtures/extensions/02_overriding/app/views", "/Users/developer/Activeshift/liam/test/fixtures/extensions/01_basic/app/views"], got: ["/Users/developer/Activeshift/liam/vendor/radiant/test/fixtures/extensions/02_overriding/app/views", "/Users/developer/Activeshift/liam/vendor/radiant/test/fixtures/extensions/01_basic/app/views"] (using ==) /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/expectations/fail_with.rb:35:in `fail_with' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/matchers/operator_matcher.rb:39:in `fail_with_message' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/matchers/operator_matcher.rb:61:in `__delegate_operator' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/matchers/operator_matcher.rb:51:in `eval_match' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/matchers/operator_matcher.rb:29:in `==' /Users/developer/Activeshift/liam/vendor/radiant/spec/lib/radiant/extension_loader_spec.rb:134: /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/example/example_methods.rb:40:in `instance_eval' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/example/example_methods.rb:40:in `execute' /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/timeout.rb:53:in `timeout' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/example/example_methods.rb:37:in `execute' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/example/example_group_methods.rb:207:in `run_examples' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/example/example_group_methods.rb:205:in `each' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/example/example_group_methods.rb:205:in `run_examples' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/example/example_group_methods.rb:103:in `run' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/runner/example_group_runner.rb:23:in `run' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/runner/example_group_runner.rb:22:in `each' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/runner/example_group_runner.rb:22:in `run' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/runner/options.rb:119:in `run_examples' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/runner/command_line.rb:9:in `run' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/bin/spec:4: Finished in 1.763736 seconds 257 examples, 1 failure
or cancel
1)
'Radiant::ExtensionLoader should return the view paths in inverse order to the loaded' FAILED expected: ["/Users/developer/Activeshift/liam/test/fixtures/extensions/02_overriding/app/views", "/Users/developer/Activeshift/liam/test/fixtures/extensions/01_basic/app/views"],
```
 got: ["/Users/developer/Activeshift/liam/vendor/radiant/test/fixtures/extensions/02_overriding/app/views", "/Users/developer/Activeshift/liam/vendor/radiant/test/fixtures/extensions/01_basic/app/views"] (using ==)
```
/Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/expectations/fail_with.rb:35:in fail_with' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/matchers/operator_matcher.rb:39:infail_with_message' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/matchers/operator_matcher.rb:61:in __delegate_operator' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/matchers/operator_matcher.rb:51:ineval_match' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/matchers/operator_matcher.rb:29:in ==' /Users/developer/Activeshift/liam/vendor/radiant/spec/lib/radiant/extension_loader_spec.rb:134: /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/example/example_methods.rb:40:ininstance_eval' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/example/example_methods.rb:40:in execute' /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/timeout.rb:53:intimeout' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/example/example_methods.rb:37:in execute' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/example/example_group_methods.rb:207:inrun_examples' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/example/example_group_methods.rb:205:in each' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/example/example_group_methods.rb:205:inrun_examples' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/example/example_group_methods.rb:103:in run' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/runner/example_group_runner.rb:23:inrun' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/runner/example_group_runner.rb:22:in each' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/runner/example_group_runner.rb:22:inrun' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/runner/options.rb:119:in run_examples' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/lib/spec/runner/command_line.rb:9:inrun' /Library/Ruby/Gems/1.8/gems/rspec-1.2.6/bin/spec:4:

Finished in 1.763736 seconds

257 examples, 1 failure
Comments

radiant Sun Jun 07 07:47:23 -0700 2009 | link

I can't reproduce this failure. Also, the expected and actual do appear equivalent.

Comment
I can't reproduce this failure. Also, the expected and actual do appear equivalent.
or cancel

Parsed with GitHub Flavored Markdown
2.

0 votes

rake radiant:update should update environments
1 comment Created 6 months ago by johnmuhl

Title

Body
config/environments/development, production, test.rb need to be updated to remove references to ResponseCache when upgrading from 0.6.x or 0.7.x versions
or cancel

config/environments/development, production, test.rb need to be updated to remove references to ResponseCache when upgrading from 0.6.x or 0.7.x versions

Comments

saturnflyer Wed Jun 10 18:32:33 -0700 2009 | link

radiant:update:configs now updates instance config/environments. Closed by 7aaa2da

Comment
radiant:update:configs now updates instance config/environments. Closed by 7aaa2dabeba5b18260941c30ff311ecc6a8b428d
or cancel

Parsed with GitHub Flavored Markdown
1.

0 votes

undefined local variable or method `template_extensions' for #<Mailman:0xb7082f70>
1 comment Created 6 months ago by jmonteiro

Title

Body
With ActionMailer, I have created a Mailer where I try to deliver some email. But when I does this, I got the following error: NameError (undefined local variable or method `template_extensions' for #<Mailman:0xb7082f70>) How to reproduce the error: 1. Clone Radiant 2. Create a mailer (for example, script/generate mailer Mailman) 3. Write a method 4. Call the deliver_method_name 5. You got the error! This error is happening in the line 43 of the file http://github.com/radiant/radiant/blob/e4b8fc8f3281d2888556d569f2241e14a1942ec9/lib/plugins/extension_patches/lib/mailer_view_paths_extension.rb#L43, where template_extensions isn't being found.
or cancel
With ActionMailer, I have created a Mailer where I try to deliver some email.

But when I does this, I got the following error:
```
NameError (undefined local variable or method `template_extensions' for #<Mailman:0xb7082f70>)
```
How to reproduce the error:
1. Clone Radiant
2. Create a mailer (for example, script/generate mailer Mailman)
3. Write a method
4. Call the deliver_method_name
5. You got the error!
This error is happening in the line 43 of the file http://github.com/radiant/radiant/blob/e4b8fc8f3281d2888556d569f2241e14a1942ec9/lib/plugins/extension_patches/lib/mailer_view_paths_extension.rb#L43, where template_extensions isn't being found.
Comments

radiant Sat May 09 09:54:40 -0700 2009 | link

This is already fixed in the Rails 2.3 branch - that patch is no longer needed.

Comment
This is already fixed in the Rails 2.3 branch - that patch is no longer needed.
or cancel

Parsed with GitHub Flavored Markdown