test/exception_notifier_helper_test.rb test/test_helper.rb @@ -23,6 +23,7 @@ require 'pp' module ExceptionNotifierHelper VIEW_PATH = "views/exception_notifier" APP_PATH = "#{RAILS_ROOT}/app/#{VIEW_PATH}" + PARAM_FILTER_REPLACEMENT = "[FILTERED]" def render_section(section) RAILS_DEFAULT_LOGGER.info("rendering section #{section.inspect}") @@ -60,4 +61,17 @@ module ExceptionNotifierHelper def object_to_yaml(object) object.to_yaml.sub(/^---\s*/m, "") end + + def exclude_raw_post_parameters? + @controller && @controller.respond_to?(:filter_parameters) + end + + def filter_sensitive_post_data_parameters(parameters) + exclude_raw_post_parameters? ? @controller.filter_parameters(parameters) : parameters + end + + def filter_sensitive_post_data_from_env(env_key, env_value) + return env_value unless exclude_raw_post_parameters? + (env_key =~ /RAW_POST_DATA/i) ? PARAM_FILTER_REPLACEMENT : env_value + end end lib/exception_notifier_helper.rb @@ -1,6 +1,6 @@ <% max = @request.env.keys.max { |a,b| a.length <=> b.length } -%> <% @request.env.keys.sort.each do |key| -%> -* <%= "%*-s: %s" % [max.length, key, @request.env[key].to_s.strip] %> +* <%= "%*-s: %s" % [max.length, key, filter_sensitive_post_data_from_env(key, @request.env[key].to_s.strip)] %> <% end -%> * Process: <%= $$ %> views/exception_notifier/_environment.rhtml @@ -1,3 +1,3 @@ * URL: <%= @request.protocol %><%= @host %><%= @request.request_uri %> -* Parameters: <%= @request.parameters.inspect %> +* Parameters: <%= filter_sensitive_post_data_parameters(@request.parameters).inspect %> * Rails root: <%= @rails_root %> views/exception_notifier/_request.rhtml cf0a564da6da6e5675c92bb3275db1f35d7035b3 Jamis Buck jamis@37signals.com http://github.com/rails/exception_notification/commit/f00c3bf26163b032d924de7d008901a1c7f985a1 f00c3bf26163b032d924de7d008901a1c7f985a1 2007-06-26T19:52:48-07:00 2007-06-26T19:52:48-07:00 param filtering for exception notification (closes #8432, thanks for the excellent patch!) 9fad3bd571c290330b1db61ec46a8796311c8860 Jamis Buck jamis@37signals.com