@@ -1,3 +1,5 @@ +* OpenID 2.0 recommends that forms should use the field name "openid_identifier" rather than "openid_url" [Josh Peek] + * Return open_id_response.display_identifier to the application instead of .endpoints.claimed_id. [nbibler] * Add Timeout protection [Rick] CHANGELOG @@ -90,8 +90,8 @@ app/views/sessions/new.erb </p> <p> - <label for="openid_url">OpenID:</label> - <%= text_field_tag "openid_url" %> + <label for="openid_identifier">OpenID:</label> + <%= text_field_tag "openid_identifier" %> </p> <p> README @@ -83,13 +83,21 @@ module OpenIdAuthentication OpenIdAuthentication.normalize_url(url) end - # The parameter name of "openid_url" is used rather than the Rails convention "open_id_url" + # The parameter name of "openid_identifier" is used rather than the Rails convention "open_id_identifier" # because that's what the specification dictates in order to get browser auto-complete working across sites - def using_open_id?(identity_url = params[:openid_url]) #:doc: + def using_open_id?(identity_url = params[:openid_identifier]) #:doc: + if params.has_key?(:openid_url) + puts '[OPENID] The conventional field name has changed from "openid_url" to "openid_identifier"' + end + !identity_url.blank? || params[:open_id_complete] end - def authenticate_with_open_id(identity_url = params[:openid_url], options = {}, &block) #:doc: + def authenticate_with_open_id(identity_url = params[:openid_identifier], options = {}, &block) #:doc: + if params.has_key?(:openid_url) + puts '[OPENID] The conventional field name has changed from "openid_url" to "openid_identifier"' + end + if params[:open_id_complete].nil? begin_open_id_authentication(identity_url, options, &block) else lib/open_id_authentication.rb 8a47d6e5da4e333e59e161410b0f45f237408548 Joshua Peek josh@joshpeek.com http://github.com/rails/open_id_authentication/commit/9efbd254f3b274a52f8517cc631201b8b0224bde 9efbd254f3b274a52f8517cc631201b8b0224bde 2008-07-27T15:07:35-07:00 2008-07-27T15:07:35-07:00 Changed default identity url parameter from "openid_url" to "openid_identifier" as recommended in the OpenID 2.0 spec 0f4719df98aab8afb4cc76103ab3e677aa171a72 Joshua Peek josh@joshpeek.com