public
Description: Ruby on Rails
Homepage: http://rubyonrails.org
Clone URL: git://github.com/rails/rails.git

Comments for rails's rails   feed

janx commented on rails/rails Fri Nov 06 09:19:54 -0800 2009
Comment in d627c93:

thanks :-)

josevalim commented on rails/rails Fri Nov 06 06:47:51 -0800 2009
Comment in d627c93:

I think you just need to change "generators/named_base" to "rails/generators/named_base". We namespaced everything in railties to /rails.

janx commented on rails/rails Fri Nov 06 01:29:17 -0800 2009
Comment in d627c93:

Hey @josevalim,

For 'dependency hell', I mean the 'require' statement I need to put in file when I tried to write a generator in lib/generator folder (like you). I tried your generators in third_rails but they don't work:

@@@ [WARNING] Could not load generator at "/tmp/lala/lib/generators/datamapper/model/model_generator.rb". Error: no such file to load -- generators/named_base [WARNING] Could not load generator at "/tmp/lala/lib/generators/rspec/model/model_generator.rb". Error: no such file to load -- generators/named_base Could not find generator rspec:model.
@@@

All old style generators won't work after the refactor on rails generator recently (?). I can't find an easy way to write new generator in lib/generators. Any idea?

rubys commented on rails/rails Thu Nov 05 15:23:14 -0800 2009
josevalim commented on rails/rails Thu Nov 05 03:00:09 -0800 2009
Comment in d627c93:

@janx, when you talk about dependency hell, you mean the dependencies declared in bundler?

I just posted a pastie explaining how to have your Rails 3 app working from edge without having to install gems or bundling twice:

http://pastie.org/684600

And if you want rspec generators, I created some in this branch:

http://github.com/josevalim/third_rails

However the rails used in vendor as a submodule is outdated. At least you can reuse lib/generators without problems.

janx commented on rails/rails Thu Nov 05 01:52:02 -0800 2009
Comment in d627c93:

I wrote a rspec built-in generator for rails3 yesterday (in my fork). I tried to write it as a plugin generator (like in lib/generators) but gave up finally due to the dependency hell :(

Is there any public api for plugin generator now?

josevalim commented on rails/rails Wed Nov 04 05:27:09 -0800 2009
Comment in d627c93:

No. Just that Rails 3 provides proper hooks to rpsec, so no more need for hacks and/or code duplication.

kaichen commented on rails/rails Wed Nov 04 05:03:58 -0800 2009
Comment in d627c93:

Is this means that Rails 3 will integrate rspec as build-in? like Merb?

radar commented on rails/rails Mon Nov 02 21:11:05 -0800 2009
Comment in 8ed82df:

Go qrush!

freerobby commented on rails/rails Mon Nov 02 20:59:19 -0800 2009
Comment in 8ed82df:

ftw!

zapnap commented on rails/rails Mon Nov 02 20:54:00 -0800 2009
Comment in 8ed82df:

gemcutter++

samsoffes commented on rails/rails Mon Nov 02 20:46:17 -0800 2009
Comment in 8ed82df:

Congrats @qrush!

jenseng commented on rails/rails Mon Nov 02 17:53:33 -0800 2009
Comment in 1d93464:

gah, sorry for the double post. /me fails at github

jenseng commented on rails/rails Mon Nov 02 17:51:01 -0800 2009
Comment on activesupport/lib/active_support/core_ext/string/conversions.rb in 1d93464:

In ruby 1.8.6 and prior, date.rb has a bug wherein fractional seconds above 59 result in an invalid date. Try a "2005-02-27T23:50:59.275038".to_datetime and you'll see what I mean. Should we hack this to ignore fractional seconds above 59 when on broken ruby versions? It's kind of annoying when a method only works 59 times out of 60.

http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/23501

jenseng commented on rails/rails Mon Nov 02 17:50:11 -0800 2009
Comment in 1d93464:

In ruby 1.8.6 and prior, date.rb has a bug wherein fractional seconds above 59 result in an invalid date. Try a "2005-02-27T23:50:59.275038".to_datetime and you'll see what I mean. Should we hack this to ignore fractional seconds above 59 when on broken ruby versions? It's kind of annoying when a method only works 59 times out of 60.

http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/23501

carlosantoniodasilva commented on rails/rails Wed Oct 28 12:00:27 -0700 2009
Comment in f5f7c40:

Thanks for that!

pixeltrix commented on rails/rails Wed Oct 28 01:25:05 -0700 2009
Comment in 7c850e2:

Not sure why this appeared in the events feed for rails/rails (I assume it was so that the branch could be deleted) but it had me worried for a while. No more commits ripping out the guts of important modules with messages like this one, please!

markwfoster commented on rails/rails Mon Oct 26 12:58:14 -0700 2009
Comment in 4932f7b:

Broke down and created a plugin to do it. Manages seeds like models and allows rake db:seed to run individual model seeds, not just a batch.

http://github.com/markwfoster/seeded-generation

scrum8 commented on rails/rails Sun Oct 25 03:51:26 -0700 2009
Comment in a840c8a:

I think this changeset cause this error:
vendor/plugins/rack-mount/lib/rack/mount/route.rb:34:in `initialize': app must be a valid rack application and respond to call (ArgumentError)

from vendor/plugins/rack-mount/lib/rack/mount/generation/route.rb:9:in `initialize'
from vendor/plugins/rack-mount/lib/rack/mount/recognition/route.rb:9:in `initialize'
from vendor/plugins/rack-mount/lib/rack/mount/mixover.rb:25:in `new'
from vendor/plugins/rack-mount/lib/rack/mount/route_set.rb:46:in `add_route'
from vendor/plugins/rack-mount/lib/rack/mount/generation/route_set.rb:17:in `add_route'
from vendor/plugins/rack-mount/lib/rack/mount/recognition/route_set.rb:19:in `add_route'
from vendor/rails/actionpack/lib/action_dispatch/routing/route_set.rb:290:in `add_route'
from vendor/rails/actionpack/lib/action_dispatch/routing/deprecated_mapper.rb:147:in `connect'
from vendor/rails/actionpack/lib/action_dispatch/routing/deprecated_mapper.rb:213:in `named_route'
from vendor/rails/activesupport/lib/active_support/option_merger.rb:22:in `method_missing'
from vendor/rails/actionpack/lib/action_dispatch/routing/deprecated_mapper.rb:849:in `map_resource_routes'
from vendor/rails/actionpack/lib/action_dispatch/routing/deprecated_mapper.rb:801:in `map_default_collection_actions'
from vendor/rails/actionpack/lib/action_dispatch/routing/deprecated_mapper.rb:731:in `block in map_resource'
from vendor/rails/activesupport/lib/active_support/core_ext/object/with_options.rb:22:in `with_options'
from vendor/rails/actionpack/lib/action_dispatch/routing/deprecated_mapper.rb:723:in `map_resource'
from vendor/rails/actionpack/lib/action_dispatch/routing/deprecated_mapper.rb:642:in `block in resources'
from vendor/rails/actionpack/lib/action_dispatch/routing/deprecated_mapper.rb:642:in `each'
from vendor/rails/actionpack/lib/action_dispatch/routing/deprecated_mapper.rb:642:in `resources'
from config/routes.rb:2:in `block in <top (required)>'
from vendor/rails/actionpack/lib/action_dispatch/routing/route_set.rb:208:in `instance_exec'
from vendor/rails/actionpack/lib/action_dispatch/routing/route_s

I've already used your version of rack-mount. Is there anything missed?

weppos commented on rails/rails Fri Oct 23 06:20:13 -0700 2009