All 2xx requests are considered successful [#217 state:resolved]

rails · Aug 24, 2008 · 0e10e93 · 0e10e93
1 parent 6fbd6c0
commit 0e10e93
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/actionpack/CHANGELOG b/actionpack/CHANGELOG
@@ -1,5 +1,7 @@
 *2.1.1 (next release)*
 
+* All 2xx requests are considered successful [Josh Peek]
+
 * Deprecate the limited follow_redirect in functional tests.  If you wish to follow redirects, use integration tests. [Michael Koziarski]
 
 * Deprecate define_javascript_functions, javascript_include_tag and friends are much better [Michael Koziarski]

diff --git a/actionpack/lib/action_controller/test_process.rb b/actionpack/lib/action_controller/test_process.rb
@@ -171,7 +171,7 @@ def message
 
     # Was the response successful?
     def success?
-      response_code == 200
+      (200..299).include?(response_code)
     end
 
     # Was the URL not found?