@@ -1,5 +1,7 @@ *SVN* +* Fixed that change_column should be able to use :null => true on a field that formerly had false [Nate Wiger] [#26] + * Added that the MySQL adapter should map integer to either smallint, int, or bigint depending on the :limit just like PostgreSQL [DHH] * Change validates_uniqueness_of :case_sensitive option default back to true (from [9160]). Love your database columns, don't LOWER them. [rick] activerecord/CHANGELOG @@ -297,7 +297,14 @@ module ActiveRecord def add_column_options!(sql, options) #:nodoc: sql << " DEFAULT #{quote(options[:default], options[:column])}" if options_include_default?(options) - sql << " NOT NULL" if options[:null] == false + # must explcitly check for :null to allow change_column to work on migrations + if options.has_key? :null + if options[:null] == false + sql << " NOT NULL" + else + sql << " NULL" + end + end end # SELECT DISTINCT clause for a given set of columns and a given ORDER BY clause. activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb 5514baf63d6d5e19a84c59a0c2cf74f442daed9c David Heinemeier Hansson david@envy8-2.local http://github.com/rails/rails/commit/10ef65a3b054270ed3d458ec8eb7c2b9a3e638f7 10ef65a3b054270ed3d458ec8eb7c2b9a3e638f7 2008-04-29T14:52:52-07:00 2008-04-29T14:52:52-07:00 Fixed that change_column should be able to use :null => true on a field that formerly had false [Nate Wiger] [#26 state:resolved] 8e7f42e2f296280a039e5c0017a81771144d3169 David Heinemeier Hansson david@envy8-2.local