Allow Nokogiri XmlMini backend to process cdata elements

[#3219 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
rails · Sep 17, 2009 · 179b451 · 179b451
1 parent ff0377d
commit 179b451
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/activesupport/lib/active_support/xml_mini/nokogiri.rb b/activesupport/lib/active_support/xml_mini/nokogiri.rb
@@ -38,7 +38,7 @@ def to_hash(hash = {})
           walker = lambda { |memo, parent, child, callback|
             next if child.blank? && 'file' != parent['type']
 
-            if child.text?
+            if child.text? || child.cdata?
               (memo[CONTENT_ROOT] ||= '') << child.content
               next
             end

diff --git a/activesupport/test/xml_mini/nokogiri_engine_test.rb b/activesupport/test/xml_mini/nokogiri_engine_test.rb
@@ -147,6 +147,17 @@ def test_children_with_non_adjacent_text
     eoxml
   end
 
+  def test_children_with_cdata
+    assert_equal_rexml(<<-eoxml)
+    <root>
+      <products>
+        hello <![CDATA[everyone]]>
+        morning
+      </products>
+    </root>
+    eoxml
+  end
+
   private
   def assert_equal_rexml(xml)
     hash = XmlMini.with_backend('REXML') { XmlMini.parse(xml) }