public
Description: Ruby on Rails
Homepage: http://rubyonrails.org
Clone URL: git://github.com/rails/rails.git
Remove deprecated render_component. Please use the plugin from 
http://github.com/rails/render_component/tree/master
lifo (author)
Wed Nov 19 04:11:55 -0800 2008
commit  27c03e69e94655482b0d77d3ae0ca902ce537f8c
tree    2b71a3ec9ac2e11d75fc008755bf53c07a3d36b3
parent  0c9f677e7861ef2aae36d91811d72794e4709f58
...
1
2
 
 
3
4
5
...
1
2
3
4
5
6
7
0
@@ -1,5 +1,7 @@
0
 *2.3.0/3.0*
0
 
0
+* Remove deprecated render_component. Please use the plugin from http://github.com/rails/render_component/tree/master [Pratik]
0
+
0
 * Fixed RedCloth and BlueCloth shouldn't preload. Instead just assume that they're available if you want to use textilize and markdown and let autoload require them [DHH]
0
 
0
 
...
49
50
51
52
53
54
55
...
72
73
74
75
76
77
78
...
49
50
51
 
52
53
54
...
71
72
73
 
74
75
76
0
@@ -49,7 +49,6 @@ require 'action_controller/verification'
0
 require 'action_controller/streaming'
0
 require 'action_controller/session_management'
0
 require 'action_controller/http_authentication'
0
-require 'action_controller/components'
0
 require 'action_controller/rack_process'
0
 require 'action_controller/record_identifier'
0
 require 'action_controller/request_forgery_protection'
0
@@ -72,7 +71,6 @@ ActionController::Base.class_eval do
0
   include ActionController::Streaming
0
   include ActionController::SessionManagement
0
   include ActionController::HttpAuthentication::Basic::ControllerMethods
0
-  include ActionController::Components
0
   include ActionController::RecordIdentifier
0
   include ActionController::RequestForgeryProtection
0
   include ActionController::Translation
...
529
530
531
532
 
533
534
535
...
529
530
531
 
532
533
534
535
0
@@ -529,7 +529,7 @@ module ActionController #:nodoc:
0
       end
0
 
0
       def send_response
0
-        response.prepare! unless component_request?
0
+        response.prepare!
0
         response
0
       end
0
 
...
165
166
167
168
 
169
170
171
...
165
166
167
 
168
169
170
171
0
@@ -165,7 +165,7 @@ module ActionController #:nodoc:
0
         def assign_shortcuts_with_flash(request, response) #:nodoc:
0
           assign_shortcuts_without_flash(request, response)
0
           flash(:refresh)
0
-          flash.sweep if @_session && !component_request?
0
+          flash.sweep if @_session
0
         end
0
     end
0
   end

Comments

josh Wed Nov 19 07:04:59 -0800 2008

Wow, that was easy to remove. Maybe something to do with how modular the Rails internals are?

greatseth Wed Nov 19 07:34:26 -0800 2008

aww

matthewrudy Wed Nov 19 16:40:00 -0800 2008

yeah, I still use render_component in one place (for a good reason)

but fair enough. it’s been deprecated for a long time.

I think the deprecation said “it’ll be removed with rails 2.0” but it never was :s