Navigation Menu

Skip to content

Commit

Permalink
Remove deprecated render_component. Please use the plugin from http:/…
Browse files Browse the repository at this point in the history
  • Loading branch information
lifo committed Nov 19, 2008
1 parent 0c9f677 commit 27c03e6
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 325 deletions.
2 changes: 2 additions & 0 deletions actionpack/CHANGELOG
@@ -1,5 +1,7 @@
*2.3.0/3.0*

* Remove deprecated render_component. Please use the plugin from http://github.com/rails/render_component/tree/master [Pratik]

* Fixed RedCloth and BlueCloth shouldn't preload. Instead just assume that they're available if you want to use textilize and markdown and let autoload require them [DHH]


Expand Down
2 changes: 0 additions & 2 deletions actionpack/lib/action_controller.rb
Expand Up @@ -49,7 +49,6 @@
require 'action_controller/streaming'
require 'action_controller/session_management'
require 'action_controller/http_authentication'
require 'action_controller/components'
require 'action_controller/rack_process'
require 'action_controller/record_identifier'
require 'action_controller/request_forgery_protection'
Expand All @@ -72,7 +71,6 @@
include ActionController::Streaming
include ActionController::SessionManagement
include ActionController::HttpAuthentication::Basic::ControllerMethods
include ActionController::Components
include ActionController::RecordIdentifier
include ActionController::RequestForgeryProtection
include ActionController::Translation
Expand Down
2 changes: 1 addition & 1 deletion actionpack/lib/action_controller/base.rb
Expand Up @@ -529,7 +529,7 @@ def process(request, response, method = :perform_action, *arguments) #:nodoc:
end

def send_response
response.prepare! unless component_request?
response.prepare!
response
end

Expand Down
169 changes: 0 additions & 169 deletions actionpack/lib/action_controller/components.rb

This file was deleted.

2 changes: 1 addition & 1 deletion actionpack/lib/action_controller/flash.rb
Expand Up @@ -165,7 +165,7 @@ def flash(refresh = false) #:doc:
def assign_shortcuts_with_flash(request, response) #:nodoc:
assign_shortcuts_without_flash(request, response)
flash(:refresh)
flash.sweep if @_session && !component_request?
flash.sweep if @_session
end
end
end
Expand Down
152 changes: 0 additions & 152 deletions actionpack/test/controller/components_test.rb

This file was deleted.

3 comments on commit 27c03e6

@josh
Copy link
Contributor

@josh josh commented on 27c03e6 Nov 19, 2008

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was easy to remove. Maybe something to do with how modular the Rails internals are?

@greatseth
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aww

@matthewrudy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah,
I still use render_component in one place (for a good reason)

but fair enough.
it’s been deprecated for a long time.

I think the deprecation said “it’ll be removed with rails 2.0”
but it never was
:s

Please sign in to comment.