rails / rails fork watch download tarball
public
Description: Ruby on Rails
Homepage: http://rubyonrails.org
Clone URL: git://github.com/rails/rails.git 
Enable partial updates by default
jeremy (author)
Fri May 30 04:16:57 -0700 2008
commit  2ce1be3ac4823ccdfbe36ff5548a562aa5106d2e
tree    3425d26c06104f522d51e33f776b90fc60a42a2f
parent  946f51449a2531b8c1a92035b4482ae633d56894
0
activerecord/lib/active_record/dirty.rb 
...
43
44
45
46
 
47
48
49
 
...
43
44
45
 
46
47
48
49
 
0
@@ -43,7 +43,7 @@ module ActiveRecord
0
       base.alias_method_chain :reload,          :dirty
0
 
0
       base.superclass_delegating_accessor :partial_updates
0
-      base.partial_updates = false
0
+      base.partial_updates = true
0
     end
0
 
0
     # Do any attributes have unsaved changes?

Comments

  • DefV Fri May 30 06:10:09 -0700 2008

    This kind of makes this commit (http://github.com/rails/rails/commit/888d5059bdb71e6d034d0c09d7e3b3e235fd8507) useless..

  • trevorturk Fri May 30 07:09:02 -0700 2008

    Yeah, I’m not sure how to read this either. Are partial updates on by default now?

  • geoffgarside Fri May 30 15:01:59 -0700 2008

    Its likely that partial updates are not enabled by default for Rails 2.1, but if you stay on edge then they are enabled by default as per the commit message.

  • bdude Sat May 31 01:43:24 -0700 2008

    This setting has been on and off more than Ross and Rachel

  • ncr Sat May 31 03:14:18 -0700 2008

    I think it needs stronger “opinion”. I like it on by default.

  • NZKoz Sat May 31 18:08:26 -0700 2008

    It’s on by default, if you have contention-heavy data and you’re not using optimistic locking at present you’re already breaking stuff.

    The discussions which resulted in this happened face to face, sorry for the confusion :)

  • trevorturk Sun Jun 01 20:34:43 -0700 2008

    Thanks for the clarification. I think this is a good default, personally.