@@ -1,5 +1,7 @@ *2.2.1 [RC2 or 2.2 final]* +* Fixed regex in redirect_to to fully support URI schemes #1247 [Seth Fitzsimmons] + * Fixed bug with asset timestamping when using relative_url_root #1265 [Joe Goldwasser] actionpack/CHANGELOG @@ -1053,7 +1053,10 @@ module ActionController #:nodoc: logger.info("Redirected to #{options}") if logger && logger.info? case options - when %r{^\w+://.*} + # The scheme name consist of a letter followed by any combination of + # letters, digits, and the plus ("+"), period ("."), or hyphen ("-") + # characters; and is terminated by a colon (":"). + when %r{^\w[\w\d+.-]*:.*} redirect_to_full_url(options, status) when String redirect_to_full_url(request.protocol + request.host_with_port + options, status) actionpack/lib/action_controller/base.rb @@ -73,6 +73,10 @@ class RedirectController < ActionController::Base redirect_to "http://dev.rubyonrails.org/query?status=new" end + def redirect_to_url_with_complex_scheme + redirect_to "x-test+scheme.complex:redirect" + end + def redirect_to_back redirect_to :back end @@ -198,6 +202,12 @@ class RedirectTest < Test::Unit::TestCase assert_redirected_to "http://dev.rubyonrails.org/query?status=new" end + def test_redirect_to_url_with_complex_scheme + get :redirect_to_url_with_complex_scheme + assert_response :redirect + assert_equal "x-test+scheme.complex:redirect", redirect_to_url + end + def test_redirect_to_back @request.env["HTTP_REFERER"] = "http://www.example.com/coming/from" get :redirect_to_back actionpack/test/controller/redirect_test.rb ef53d915164da7f757d03c4a70fe38e374c08b14 Seth Fitzsimmons seth@mojodna.net http://github.com/rails/rails/commit/47b4fa4a621ee48ab17545b1e9fb38efef53b28e 47b4fa4a621ee48ab17545b1e9fb38efef53b28e 2008-10-30T13:07:50-07:00 2008-10-30T12:03:47-07:00 Fixed regex in redirect_to to fully support URI schemes [#1247 state:committed] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> 2cf5c92154ff0cdefb4b09e16cb788802369cb4b David Heinemeier Hansson david@loudthinking.com