@@ -233,7 +233,7 @@ module ActiveRecord method_name = method_id.to_s if self.class.private_method_defined?(method_name) - raise NoMethodError("Attempt to call private method", method_name, args) + raise NoMethodError.new("Attempt to call private method", method_name, args) end # If we haven't generated any methods yet, generate them, then activerecord/lib/active_record/attribute_methods.rb @@ -233,8 +233,9 @@ class AttributeMethodsTest < ActiveRecord::TestCase topic = @target.new(:title => "The pros and cons of programming naked.") assert !topic.respond_to?(:title) - assert_raise(NoMethodError) { topic.title } - topic.send(:title) + exception = assert_raise(NoMethodError) { topic.title } + assert_equal "Attempt to call private method", exception.message + assert_equal "I'm private", topic.send(:title) end def test_write_attributes_respect_access_control @@ -242,7 +243,8 @@ class AttributeMethodsTest < ActiveRecord::TestCase topic = @target.new assert !topic.respond_to?(:title=) - assert_raise(NoMethodError) { topic.title = "Pants"} + exception = assert_raise(NoMethodError) { topic.title = "Pants"} + assert_equal "Attempt to call private method", exception.message topic.send(:title=, "Very large pants") end @@ -251,7 +253,8 @@ class AttributeMethodsTest < ActiveRecord::TestCase topic = @target.new(:title => "Isaac Newton's pants") assert !topic.respond_to?(:title?) - assert_raise(NoMethodError) { topic.title? } + exception = assert_raise(NoMethodError) { topic.title? } + assert_equal "Attempt to call private method", exception.message assert topic.send(:title?) end activerecord/test/cases/attribute_methods_test.rb 5cf932344a4482a0cfbda57e9f69ebe64e70a261 Mike Gunderloy ffmike MikeG1@larkfarm.com http://github.com/rails/rails/commit/5c97d4ff29cfd944da751f01177a3024626d57bb 5c97d4ff29cfd944da751f01177a3024626d57bb 2008-10-25T02:22:44-07:00 2008-10-25T02:19:39-07:00 "raise NoMethodError" raises NoMethodError. Raise it with NoMethodError.new instead. Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 4142a8173f00fa3ff1e03e513d18aeef89be3042 Pratik Naik lifo pratiknaik@gmail.com