public
Description: Ruby on Rails
Homepage: http://rubyonrails.org
Clone URL: git://github.com/rails/rails.git
Fixed session related memory leak [#1558 state:resolved]

Signed-off-by: Joshua Peek <josh@joshpeek.com>
fcheung (author)
Thu Dec 11 08:20:33 -0800 2008
josh (committer)
Thu Dec 11 08:20:33 -0800 2008
commit  5ede4ce188d29aef94af78f27d89169ac4ee54cd
tree    f634fe68c4c4ecc100ba094eccc6bacdbf7c9950
parent  7cfa6c535bc54f16a3fc7fa39969d4410de3e483
...
1160
1161
1162
 
 
 
1163
1164
1165
...
1160
1161
1162
1163
1164
1165
1166
1167
1168
0
@@ -1160,6 +1160,9 @@ module ActionController #:nodoc:
0
       def reset_session #:doc:
0
         request.reset_session
0
         @_session = request.session
0
+        #http://rails.lighthouseapp.com/projects/8994/tickets/1558-memory-problem-on-reset_session-in-around_filter#ticket-1558-1
0
+        #MRI appears to have a GC related memory leak to do with the finalizer that is defined on CGI::Session 
0
+        ObjectSpace.undefine_finalizer(@_session)
0
         response.session = @_session
0
       end
0
 

Comments