Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Removing prototype and just using vanilla js
- Loading branch information
Showing
1 changed file
with
17 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6193be2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, in the name of unobtrusive-javascript and javascript-framework-agnosticism. While I like prototype.js, I also like the consistent direction rails 3 is taking. One question, though - why add an
onSubmit
attribute rather than attach the handler from within thewindow.onload
handler?6193be2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yfeldblum, this is only for the Welcome to Rails page you get when you generate a new app. Since the app may use any javascript library, we can't really rely on any one of them. Do feel free to tweak this page to improve it and submit a patch!