Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Removing prototype and just using vanilla js
  • Loading branch information
mikel authored and jeremy committed Mar 3, 2010
1 parent d78e3fe commit 6193be2
Showing 1 changed file with 17 additions and 17 deletions.
34 changes: 17 additions & 17 deletions railties/lib/generators/rails/app/templates/public/index.html
Expand Up @@ -181,27 +181,27 @@
}

</style>
<script type="text/javascript" src="javascripts/prototype.js"></script>
<script type="text/javascript" src="javascripts/effects.js"></script>
<script type="text/javascript">
function about() {
if (Element.empty('about-content')) {
new Ajax.Updater('about-content', 'rails/info/properties', {
method: 'get',
onFailure: function() {Element.classNames('about-content').add('failure')},
onComplete: function() {new Effect.BlindDown('about-content', {duration: 0.25})}
});
} else {
new Effect[Element.visible('about-content') ?
'BlindUp' : 'BlindDown']('about-content', {duration: 0.25});
}
info = document.getElementById('about-content');
if (window.XMLHttpRequest)
{ xhr = new XMLHttpRequest(); }
else
{ xhr = new ActiveXObject("Microsoft.XMLHTTP"); }
xhr.open("GET","rails/info/properties",false);
xhr.send("");
info.innerHTML = xhr.responseText;
info.style.display = 'block'
}

function prepend() {
search = document.getElementById('search-text');
text = search.value;
search.value = 'site:rubyonrails.org ' + text;
}

window.onload = function() {
$('search-text').value = '';
$('search').onsubmit = function() {
$('search-text').value = 'site:rubyonrails.org ' + $F('search-text');
}
document.getElementById('search-text').value = '';
}
</script>
</head>
Expand All @@ -210,7 +210,7 @@
<div id="sidebar">
<ul id="sidebar-items">
<li>
<form id="search" action="http://www.google.com/search" method="get">
<form id="search" action="http://www.google.com/search" method="get" onSubmit="prepend();">
<input type="hidden" name="hl" value="en" />
<input type="text" id="search-text" name="q" value="site:rubyonrails.org " />
<input type="submit" value="Search" /> the Rails site
Expand Down

2 comments on commit 6193be2

@yfeldblum
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, in the name of unobtrusive-javascript and javascript-framework-agnosticism. While I like prototype.js, I also like the consistent direction rails 3 is taking. One question, though - why add an onSubmit attribute rather than attach the handler from within the window.onload handler?

@jeremy
Copy link
Member

@jeremy jeremy commented on 6193be2 Mar 3, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yfeldblum, this is only for the Welcome to Rails page you get when you generate a new app. Since the app may use any javascript library, we can't really rely on any one of them. Do feel free to tweak this page to improve it and submit a patch!

Please sign in to comment.